Skip to contentSkip to conversation

build regression in brcmfmac

wl-testing/master Arend van Spriel 3 participants 6 messages May 9, 2018

lore
Share & tools
lore

Arend van Spriel

author
#0 lore raw

Since yesterday I get the following build error on wl-testing/master:

CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.o
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c: In function ‘brcmf_notify_connect_status_ap’:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:5530:1: error: the frame size of 1592 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
}
^

In the function brcmf_notify_connect_status_ap() I do have following on the stack:

static s32
brcmf_notify_connect_status_ap(struct brcmf_cfg80211_info *cfg,
struct net_device *ndev,
const struct brcmf_event_msg *e, void *data)

{
        static int generation;
        u32 event = e->event_code;
        u32 reason = e->reason;
        struct station_info sinfo;

I guess the struct station_info grew bigger by these commits:

52539ca cfg80211: Expose TXQ stats and parameters to userspace +816
81d5439 cfg80211: average ack rssi support for data frames +1

There are a number of other (cfg80211-based) drivers doing the same thing, ie. mwifiex, ath6kl, qtnfmac.

Regards,
Arend

#1 lore raw
Quoted 24 lines · Arend van Spriel

Since yesterday I get the following build error on wl-testing/master:

   CC [M]  drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.o

drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c: In function ‘brcmf_notify_connect_status_ap’:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:5530:1:
error: the frame size of 1592 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
}
^

In the function brcmf_notify_connect_status_ap() I do have following on the stack:

static s32
brcmf_notify_connect_status_ap(struct brcmf_cfg80211_info *cfg,
struct net_device *ndev,
const struct brcmf_event_msg *e, void *data)

{
         static int generation;
         u32 event = e->event_code;
         u32 reason = e->reason;
         struct station_info sinfo;
Quoted 7 lines

I guess the struct station_info grew bigger by these commits:

52539ca cfg80211: Expose TXQ stats and parameters to userspace +816
81d5439 cfg80211: average ack rssi support for data frames +1

There are a number of other (cfg80211-based) drivers doing the same thing, ie. mwifiex, ath6kl, qtnfmac.

Yeah. Toke said this morning he was working on fixes.

johannes

#2 lore raw
Quoted 5 lines · Johannes Berg
Quoted 4 lines · Arend van Spriel

Since yesterday I get the following build error on wl-testing/master:
=20
CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.o
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c: In function=

=20

Quoted 8 lines
Quoted 8 lines

=E2=80=98brcmf_notify_connect_status_ap=E2=80=99:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:5530:1:=20
error: the frame size of 1592 bytes is larger than 1024 bytes=20 [-Werror=3Dframe-larger-than=3D]
}
^
=20
In the function brcmf_notify_connect_status_ap() I do have following on=

=20

Quoted 6 lines
Quoted 6 lines

the stack:
=20
static s32
brcmf_notify_connect_status_ap(struct brcmf_cfg80211_info *cfg,
struct net_device *ndev, const struct brcmf_event_msg *e, void *d=

ata)

Quoted 14 lines
Quoted 5 lines
{
         static int generation;
         u32 event =3D e->event_code;
         u32 reason =3D e->reason;
         struct station_info sinfo;
Quoted 8 lines

=20
I guess the struct station_info grew bigger by these commits:
=20
52539ca cfg80211: Expose TXQ stats and parameters to userspace +816
81d5439 cfg80211: average ack rssi support for data frames +1
=20
There are a number of other (cfg80211-based) drivers doing the same=20 thing, ie. mwifiex, ath6kl, qtnfmac.

Quoted 1 line

Yeah. Toke said this morning he was working on fixes.

That would be these:

https://patchwork.kernel.org/patch/10389333/
https://patchwork.kernel.org/patch/10389331/
https://patchwork.kernel.org/patch/10389335/

-Toke

#4 lore raw
Quoted 9 lines · Johannes Berg
Quoted 6 lines · On Wed, 2018-05-09 at 23:27 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote:

That would be these:
=20
https://patchwork.kernel.org/patch/10389333/
https://patchwork.kernel.org/patch/10389331/
https://patchwork.kernel.org/patch/10389335/
=20

Quoted 5 lines

D'oh, how did I miss that?!

Your fixes line is slightly wrong, it should be

Fixes 12-digitid ("subject")

You mean it's missing the parenthesis?

-Toke

#5 lore raw
Quoted 11 lines · Toke Høiland-Jørgensen
Quoted 9 lines · Johannes Berg
Quoted 6 lines · Toke Høiland-Jørgensen

That would be these:

https://patchwork.kernel.org/patch/10389333/
https://patchwork.kernel.org/patch/10389331/
https://patchwork.kernel.org/patch/10389335/

Quoted 7 lines
Quoted 5 lines

D'oh, how did I miss that?!

Your fixes line is slightly wrong, it should be

Fixes 12-digitid ("subject")

You mean it's missing the parenthesis?

Right, and the quotes.

johannes