Can we use SIGRTMIN when vdso disabled on X86?
After I executed "echo 0 > /proc/sys/abi/vsyscall32" to disable vdso, the rt_sigaction01 test case from ltp_2015 failed. The test case source code please refer to the attachment, and the output as blow:
-----------------
./rt_sigaction01
rt_sigaction01 0 TINFO : signal: 34 rt_sigaction01 1 TPASS : rt_sigaction call succeeded: result = 0 rt_sigaction01 0 TINFO : sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01 0 TINFO : Signal Handler Called with signal number 34
Segmentation fault
------------------
Is this the desired result? In function ia32_setup_rt_frame, I found below code:
if (ksig->ka.sa.sa_flags & SA_RESTORER) restorer = ksig->ka.sa.sa_restorer; else restorer = current->mm->context.vdso + vdso_image_32.sym___kernel_rt_sigreturn; put_user_ex(ptr_to_compat(restorer), &frame->pretcode);
Because the vdso is disabled, so current->mm->context.vdso is NULL, which cause the result of frame->pretcode invalid.
I'm not sure whether this is a kernel bug or just an error of test case itself. Can anyone help me?
Signature · 2 lines
Thanks! BestRegards
/******************************************************************************/
/* Copyright (c) Crackerjack Project., 2007 */ /* */ /* This program is free software; you can redistribute it and/or modify */ /* it under the terms of the GNU General Public License as published by */ /* the Free Software Foundation; either version 2 of the License, or */ /* (at your option) any later version. */ /* */ /* This program is distributed in the hope that it will be useful, */ /* but WITHOUT ANY WARRANTY; without even the implied warranty of */ /* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See */ /* the GNU General Public License for more details. */ /* */ /* You should have received a copy of the GNU General Public License */ /* along with this program; if not, write to the Free Software Foundation, */ /* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ /* */ /* History: Porting from Crackerjack to LTP is done by */ /* Manas Kumar Nayak [email protected]> */
/******************************************************************************/
/******************************************************************************/
/* Description: This tests the rt_sigaction() syscall */
/* rt_sigaction alters an action taken by a process on receipt */
/* of a particular signal. The action is specified by the */
/* sigaction structure. The previous action on the signal is */
/* saved in oact.sigsetsize should indicate the size of a */
/* sigset_t type. */
/******************************************************************************/
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include <signal.h>
#include <errno.h>
#include <sys/syscall.h>
#include <string.h>
#include "test.h"
#include "linux_syscall_numbers.h"
#include "lapi/rt_sigaction.h"
char *TCID = "rt_sigaction01";
static int testno;
int TST_TOTAL = 1;
static void cleanup(void)
{
tst_rmdir();
}static void setup(void)
{
TEST_PAUSE;
tst_tmpdir();
}static int test_flags[] =
{ SA_RESETHAND | SA_SIGINFO, SA_RESETHAND, SA_RESETHAND | SA_SIGINFO,SA_RESETHAND | SA_SIGINFO, SA_NOMASK };
char *test_flags_list[] =
{ "SA_RESETHAND|SA_SIGINFO", "SA_RESETHAND", "SA_RESETHAND|SA_SIGINFO",
"SA_RESETHAND|SA_SIGINFO", "SA_NOMASK" };
static void handler(int sig)
{
tst_resm(TINFO, "Signal Handler Called with signal number %d\n", sig);
return;
}static int set_handler(int sig, int sig_to_mask, int mask_flags)
{
struct sigaction sa, oldaction;
sa.sa_handler = (void *)handler;
sa.sa_flags = mask_flags;
sigemptyset(&sa.sa_mask);
sigaddset(&sa.sa_mask, sig);
return ltp_rt_sigaction(sig, &sa, &oldaction, SIGSETSIZE);
}int main(int ac, char **av)
{
unsigned int flag;
int signal;
int lc;
tst_parse_opts(ac, av, NULL, NULL);
setup();
for (lc = 0; TEST_LOOPING(lc); ++lc) {
tst_count = 0;
for (testno = 0; testno < TST_TOTAL; ++testno) {
for (signal = SIGRTMIN; signal <= SIGRTMAX; signal++) {
for (flag = 0;
flag <
(sizeof(test_flags) /
sizeof(test_flags[0])); flag++) {
TEST(set_handler
(signal, 0, test_flags[flag]));
if (TEST_RETURN == 0) {
tst_resm(TINFO, "signal: %d ",
signal);
tst_resm(TPASS,
"rt_sigaction call succeeded: result = %ld ",
TEST_RETURN);
tst_resm(TINFO,
"sa.sa_flags = %s ",
test_flags_list[flag]);
kill(getpid(), signal);
} else {
tst_resm(TFAIL | TTERRNO,
"rt_sigaction call "
"failed");
}
}
}
}
}
cleanup();
tst_exit();
}Is this a kernel BUG? ///Re: [Question] Can we use SIGRTMIN when vdso disabled on X86?
Quoted 27 lines · Leizhen (ThunderTown)
After I executed "echo 0 >
/proc/sys/abi/vsyscall32" to disable vdso, thert_sigaction01test case fromltp_2015failed. The test case source code please refer to the attachment, and the output as blow:-----------------
./rt_sigaction01rt_sigaction01 0 TINFO : signal: 34 rt_sigaction01 1 TPASS : rt_sigaction call succeeded: result = 0 rt_sigaction01 0 TINFO : sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01 0 TINFO : Signal Handler Called with signal number 34Segmentation fault
------------------Is this the desired result? In function
ia32_setup_rt_frame, I found below code:if (ksig->ka.sa.sa_flags & SA_RESTORER) restorer = ksig->ka.sa.sa_restorer; else restorer = current->mm->context.vdso + vdso_image_32.sym___kernel_rt_sigreturn; put_user_ex(ptr_to_compat(restorer), &frame->pretcode);Because the vdso is disabled, so
current->mm->context.vdsois NULL, which cause the result offrame->pretcodeinvalid.I'm not sure whether this is a kernel bug or just an error of test case itself. Can anyone help me?
Signature · 2 lines
Thanks! BestRegards
Re: Is this a kernel BUG? ///Re: [Question] Can we use SIGRTMIN when vdso disabled on X86?
I found that glibc has already dealt with this case. So this issue must have been met before, should it be maintained by libc/user?
if (GLRO(dl_sysinfo_dso) == NULL)
{
kact.sa_flags |= SA_RESTORER;
kact.sa_restorer = ((act->sa_flags & SA_SIGINFO)
? &restore_rt : &restore);
}Quoted 31 lines · Leizhen (ThunderTown)
Quoted 27 lines · Leizhen (ThunderTown)
After I executed "echo 0 >
/proc/sys/abi/vsyscall32" to disable vdso, thert_sigaction01test case fromltp_2015failed. The test case source code please refer to the attachment, and the output as blow:-----------------
./rt_sigaction01rt_sigaction01 0 TINFO : signal: 34 rt_sigaction01 1 TPASS : rt_sigaction call succeeded: result = 0 rt_sigaction01 0 TINFO : sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01 0 TINFO : Signal Handler Called with signal number 34Segmentation fault
------------------Is this the desired result? In function
ia32_setup_rt_frame, I found below code:if (ksig->ka.sa.sa_flags & SA_RESTORER) restorer = ksig->ka.sa.sa_restorer; else restorer = current->mm->context.vdso + vdso_image_32.sym___kernel_rt_sigreturn; put_user_ex(ptr_to_compat(restorer), &frame->pretcode);Because the vdso is disabled, so
current->mm->context.vdsois NULL, which cause the result offrame->pretcodeinvalid.I'm not sure whether this is a kernel bug or just an error of test case itself. Can anyone help me?
Signature · 2 lines
Thanks! BestRegards
Re: Is this a kernel BUG? ///Re: [Question] Can we use SIGRTMIN when vdso disabled on X86?
Quoted 12 lines · Leizhen (ThunderTown)
I found that glibc has already dealt with this case. So this issue must have been met before, should it be maintained by libc/user?
if (GLRO(dl_sysinfo_dso) == NULL) { kact.sa_flags |= SA_RESTORER; kact.sa_restorer = ((act->sa_flags & SA_SIGINFO) ? &restore_rt : &restore); }
Quoted 34 lines
Quoted 31 lines · Leizhen (ThunderTown)
Quoted 27 lines · Leizhen (ThunderTown)
After I executed "echo 0 >
/proc/sys/abi/vsyscall32" to disable vdso, thert_sigaction01test case fromltp_2015failed. The test case source code please refer to the attachment, and the output as blow:-----------------
./rt_sigaction01rt_sigaction01 0 TINFO : signal: 34 rt_sigaction01 1 TPASS : rt_sigaction call succeeded: result = 0 rt_sigaction01 0 TINFO : sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01 0 TINFO : Signal Handler Called with signal number 34Segmentation fault
------------------Is this the desired result? In function
ia32_setup_rt_frame, I found below code:if (ksig->ka.sa.sa_flags & SA_RESTORER) restorer = ksig->ka.sa.sa_restorer; else restorer = current->mm->context.vdso + vdso_image_32.sym___kernel_rt_sigreturn; put_user_ex(ptr_to_compat(restorer), &frame->pretcode);Because the vdso is disabled, so
current->mm->context.vdsois NULL, which cause the result offrame->pretcodeinvalid.I'm not sure whether this is a kernel bug or just an error of test case itself. Can anyone help me?
I can't tell from your email what you're testing, what behavior you expect, and what you saw. A program that sets up a signal handler without supplying a restorer will not work if the vDSO is off, and this is by design.
(FWIW, there is a very longstanding libc bug that causes this case to get severely screwed up if the user's SS is not the expected value, and that bug was just fixed very recently. But I doubt this is what you're seeing.)
I suppose we could improve the kernel to at least push NULL instead of some random address a bit above 0, but it'll still crash.
Re: Is this a kernel BUG? ///Re: [Question] Can we use SIGRTMIN when vdso disabled on X86?
In reply to Leizhen (ThunderTown)Quoted 44 lines · Leizhen (ThunderTown)
I found that glibc has already dealt with this case. So this issue must have been met before, should it be maintained by libc/user?
if (GLRO(dl_sysinfo_dso) == NULL) { kact.sa_flags |= SA_RESTORER; kact.sa_restorer = ((act->sa_flags & SA_SIGINFO) ? &restore_rt : &restore); }Quoted 4 lines · Leizhen (ThunderTown)
Quoted 1 line · Leizhen (ThunderTown)
After I executed "echo 0 >
/proc/sys/abi/vsyscall32" to disablevdso, the
rt_sigaction01test case fromltp_2015failed.Quoted 1 line
Quoted 1 line
The test case source code please refer to the attachment, and the
output as blow:
Quoted 5 lines
Quoted 5 lines
-----------------
./rt_sigaction01rt_sigaction01 0 TINFO : signal: 34 rt_sigaction01 1 TPASS : rt_sigaction call succeeded: result =0
Quoted 2 lines
Quoted 2 lines
rt_sigaction01 0 TINFO : sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01 0 TINFO : Signal Handler Called with signalnumber 34
Quoted 6 lines
Quoted 6 lines
Segmentation fault
------------------Is this the desired result? In function
ia32_setup_rt_frame, I foundbelow code:
Quoted 8 lines
Quoted 8 lines
if (ksig->ka.sa.sa_flags & SA_RESTORER) restorer = ksig->ka.sa.sa_restorer; else restorer = current->mm->context.vdso + vdso_image_32.sym___kernel_rt_sigreturn; put_user_ex(ptr_to_compat(restorer), &frame->pretcode);
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Because the vdso is disabled, so
current->mm->context.vdsois NULL,which cause the result of
frame->pretcodeinvalid.Quoted 2 lines
Quoted 2 lines
I'm not sure whether this is a kernel bug or just an error of test
case itself. Can anyone help me?
Quoted 2 lines
Quoted 1 line
The use of signals without SA_RESTORER is considered obsolete, but it's somewhat surprising that the vdso isn't there; it should be mapped even for static binaries esp. on i386 since it is the preferred way to do system calls (you don't need to parse the ELF for that.) Are you explicitly disabling the VDSO? If so, Don't Do That.
Signature · 1 line
Sent from my Android device with K-9 Mail. Please excuse my brevity.
Re: Is this a kernel BUG? ///Re: [Question] Can we use SIGRTMIN when vdso disabled on X86?
Quoted 46 lines · On 2018/6/7 1:48, [email protected] wrote:
Quoted 45 lines · Leizhen (ThunderTown)
I found that glibc has already dealt with this case. So this issue must have been met before, should it be maintained by libc/user?
if (GLRO(dl_sysinfo_dso) == NULL) { kact.sa_flags |= SA_RESTORER; kact.sa_restorer = ((act->sa_flags & SA_SIGINFO) ? &restore_rt : &restore); }Quoted 4 lines · Leizhen (ThunderTown)
Quoted 1 line · Leizhen (ThunderTown)
After I executed "echo 0 >
/proc/sys/abi/vsyscall32" to disablevdso, the
rt_sigaction01test case fromltp_2015failed.Quoted 1 line
Quoted 1 line
The test case source code please refer to the attachment, and the
output as blow:
Quoted 5 lines
Quoted 5 lines
-----------------
./rt_sigaction01rt_sigaction01 0 TINFO : signal: 34 rt_sigaction01 1 TPASS : rt_sigaction call succeeded: result =0
Quoted 2 lines
Quoted 2 lines
rt_sigaction01 0 TINFO : sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01 0 TINFO : Signal Handler Called with signalnumber 34
Quoted 6 lines
Quoted 6 lines
Segmentation fault
------------------Is this the desired result? In function
ia32_setup_rt_frame, I foundbelow code:
Quoted 9 lines
Quoted 9 lines
if (ksig->ka.sa.sa_flags & SA_RESTORER) restorer = ksig->ka.sa.sa_restorer; else restorer = current->mm->context.vdso + vdso_image_32.sym___kernel_rt_sigreturn; put_user_ex(ptr_to_compat(restorer), &frame->pretcode);Because the vdso is disabled, so
current->mm->context.vdsois NULL,
Quoted 8 lines
Quoted 6 lines
which cause the result of
frame->pretcodeinvalid.Quoted 2 lines
Quoted 2 lines
I'm not sure whether this is a kernel bug or just an error of test
case itself. Can anyone help me?
Quoted 2 lines
Quoted 1 line
The use of signals without
SA_RESTORERis considered obsolete, but it's somewhat surprising that the vdso isn't there; it should be mapped even for static binaries esp. on i386 since it is the preferred way to do system calls (you don't need to parse the ELF for that.) Are you explicitly disabling the VDSO? If so, Don't Do That.
Yes, the vdso was explicitly disabled by the tester. Thanks.
Quoted 1 line
Signature · 2 lines
Thanks! BestRegards
Re: Is this a kernel BUG? ///Re: [Question] Can we use SIGRTMIN when vdso disabled on X86?
In reply to Andy LutomirskiQuoted 49 lines · Andy Lutomirski
Quoted 12 lines · Leizhen (ThunderTown)
I found that glibc has already dealt with this case. So this issue must have been met before, should it be maintained by libc/user?
if (GLRO(dl_sysinfo_dso) == NULL) { kact.sa_flags |= SA_RESTORER; kact.sa_restorer = ((act->sa_flags & SA_SIGINFO) ? &restore_rt : &restore); }Quoted 34 lines
Quoted 31 lines · Leizhen (ThunderTown)
Quoted 27 lines · Leizhen (ThunderTown)
After I executed "echo 0 >
/proc/sys/abi/vsyscall32" to disable vdso, thert_sigaction01test case fromltp_2015failed. The test case source code please refer to the attachment, and the output as blow:-----------------
./rt_sigaction01rt_sigaction01 0 TINFO : signal: 34 rt_sigaction01 1 TPASS : rt_sigaction call succeeded: result = 0 rt_sigaction01 0 TINFO : sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01 0 TINFO : Signal Handler Called with signal number 34Segmentation fault
------------------Is this the desired result? In function
ia32_setup_rt_frame, I found below code:if (ksig->ka.sa.sa_flags & SA_RESTORER) restorer = ksig->ka.sa.sa_restorer; else restorer = current->mm->context.vdso + vdso_image_32.sym___kernel_rt_sigreturn; put_user_ex(ptr_to_compat(restorer), &frame->pretcode);Because the vdso is disabled, so
current->mm->context.vdsois NULL, which cause the result offrame->pretcodeinvalid.I'm not sure whether this is a kernel bug or just an error of test case itself. Can anyone help me?
Quoted 4 lines
I can't tell from your email what you're testing, what behavior you expect, and what you saw. A program that sets up a signal handler without supplying a restorer will not work if the vDSO is off, and this is by design.
OK, so that the user should take care whether the vDSO is disabled by itself or not, and use different strategies to process it appropriately, like glibc.
Quoted 8 lines
(FWIW, there is a very longstanding libc bug that causes this case to get severely screwed up if the user's SS is not the expected value, and that bug was just fixed very recently. But I doubt this is what you're seeing.)
I suppose we could improve the kernel to at least push NULL instead of some random address a bit above 0, but it'll still crash.
Should we add a warning? Which may help the user to aware this error in time.
Quoted 3 lines
.
Signature · 2 lines
Thanks! BestRegards
Re: Is this a kernel BUG? ///Re: [Question] Can we use SIGRTMIN when vdso disabled on X86?
Quoted 63 lines · Leizhen (ThunderTown)
Quoted 53 lines · Andy Lutomirski
Quoted 46 lines · Leizhen (ThunderTown)
I found that glibc has already dealt with this case. So this issue must have been met before, should it be maintained by libc/user?
if (GLRO(dl_sysinfo_dso) == NULL) { kact.sa_flags |= SA_RESTORER; kact.sa_restorer = ((act->sa_flags & SA_SIGINFO) ? &restore_rt : &restore); }Quoted 32 lines · Leizhen (ThunderTown)
Quoted 30 lines · Leizhen (ThunderTown)
After I executed "echo 0 >
/proc/sys/abi/vsyscall32" to disable vdso, thert_sigaction01test case fromltp_2015failed. The test case source code please refer to the attachment, and the output as blow:-----------------
./rt_sigaction01rt_sigaction01 0 TINFO : signal: 34 rt_sigaction01 1 TPASS : rt_sigaction call succeeded: result = 0 rt_sigaction01 0 TINFO : sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01 0 TINFO : Signal Handler Called with signal number 34Segmentation fault
------------------Is this the desired result? In function
ia32_setup_rt_frame, I found below code:if (ksig->ka.sa.sa_flags & SA_RESTORER) restorer = ksig->ka.sa.sa_restorer; else restorer = current->mm->context.vdso + vdso_image_32.sym___kernel_rt_sigreturn; put_user_ex(ptr_to_compat(restorer), &frame->pretcode);Because the vdso is disabled, so
current->mm->context.vdsois NULL, which cause the result offrame->pretcodeinvalid.I'm not sure whether this is a kernel bug or just an error of test case itself. Can anyone help me?
Quoted 4 lines
I can't tell from your email what you're testing, what behavior you expect, and what you saw. A program that sets up a signal handler without supplying a restorer will not work if the vDSO is off, and this is by design.
OK, so that the user should take care whether the vDSO is disabled by itself or not, and use different strategies to process it appropriately, like glibc.
Quoted 1 line
Quoted 9 lines
Quoted 7 lines
(FWIW, there is a very longstanding libc bug that causes this case to get severely screwed up if the user's SS is not the expected value, and that bug was just fixed very recently. But I doubt this is what you're seeing.)
I suppose we could improve the kernel to at least push NULL instead of some random address a bit above 0, but it'll still crash.
Should we add a warning? Which may help the user to aware this error in time.
It’s entirely valid to have a non working restorer if you never plan to return from a signal handler. And anyone who writes their own libc should be able to figure this out on their own, I think.
Quoted 8 lines
Quoted 3 lines
.
Signature · 2 lines
Thanks! BestRegards
Re: Is this a kernel BUG? ///Re: [Question] Can we use SIGRTMIN when vdso disabled on X86?
Quoted 68 lines · Andy Lutomirski
Quoted 68 lines · Leizhen (ThunderTown)
Quoted 53 lines · Andy Lutomirski
Quoted 46 lines · Leizhen (ThunderTown)
I found that glibc has already dealt with this case. So this issue must have been met before, should it be maintained by libc/user?
if (GLRO(dl_sysinfo_dso) == NULL) { kact.sa_flags |= SA_RESTORER; kact.sa_restorer = ((act->sa_flags & SA_SIGINFO) ? &restore_rt : &restore); }Quoted 32 lines · Leizhen (ThunderTown)
Quoted 30 lines · Leizhen (ThunderTown)
After I executed "echo 0 >
/proc/sys/abi/vsyscall32" to disable vdso, thert_sigaction01test case fromltp_2015failed. The test case source code please refer to the attachment, and the output as blow:-----------------
./rt_sigaction01rt_sigaction01 0 TINFO : signal: 34 rt_sigaction01 1 TPASS : rt_sigaction call succeeded: result = 0 rt_sigaction01 0 TINFO : sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01 0 TINFO : Signal Handler Called with signal number 34Segmentation fault
------------------Is this the desired result? In function
ia32_setup_rt_frame, I found below code:if (ksig->ka.sa.sa_flags & SA_RESTORER) restorer = ksig->ka.sa.sa_restorer; else restorer = current->mm->context.vdso + vdso_image_32.sym___kernel_rt_sigreturn; put_user_ex(ptr_to_compat(restorer), &frame->pretcode);Because the vdso is disabled, so
current->mm->context.vdsois NULL, which cause the result offrame->pretcodeinvalid.I'm not sure whether this is a kernel bug or just an error of test case itself. Can anyone help me?
Quoted 4 lines
I can't tell from your email what you're testing, what behavior you expect, and what you saw. A program that sets up a signal handler without supplying a restorer will not work if the vDSO is off, and this is by design.
OK, so that the user should take care whether the vDSO is disabled by itself or not, and use different strategies to process it appropriately, like glibc.
Quoted 6 lines
(FWIW, there is a very longstanding libc bug that causes this case to get severely screwed up if the user's SS is not the expected value, and that bug was just fixed very recently. But I doubt this is what you're seeing.)
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
I suppose we could improve the kernel to at least push NULL instead of some random address a bit above 0, but it'll still crash.
Should we add a warning? Which may help the user to aware this error in time.
It’s entirely valid to have a non working restorer if you never plan to return from a signal handler. And anyone who writes their own libc should be able to figure this out on their own, I think.
OK. Thanks a lot.
Quoted 12 lines
Quoted 9 lines
Quoted 4 lines
.
Signature · 2 lines
Thanks! BestRegards.
Signature · 2 lines
Thanks! BestRegards
Re: Is this a kernel BUG? ///Re: [Question] Can we use SIGRTMIN when vdso disabled on X86?
In reply to Leizhen (ThunderTown)Quoted 5 lines · Leizhen (ThunderTown)
Quoted 2 lines
The use of signals without
SA_RESTORERis considered obsolete, but it's somewhat surprising that the vdso isn't there; it should be mapped even for static binaries esp. on i386 since it is the preferred way to do system calls (you don't need to parse the ELF for that.) Are you explicitly disabling the VDSO? If so, Don't Do That.Yes, the vdso was explicitly disabled by the tester. Thanks.
Are there any use cases that calls for this? Maybe we should drop this option.
-hpa