Skip to contentSkip to conversation

9p/net/protocol.c: return -ENOMEM when kmalloc() failed

PATCH In review piaojun 2 participants 2 messages Jul 11, 2018 9P file system

lore
Share & tools
lore

piaojun

author
#0 lore raw

PATCH 1/1 9p/net/protocol.c: return -ENOMEM when kmalloc() failed

We should return -ENOMEM to upper user when kmalloc failed to indicate accurate errno.

Signed-off-by Jun Piao <[email protected]>
---
 net/9p/protocol.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/9p/protocol.c +1 -1
index 931ea00..4a1e1dd 100644
@@ -156,7 +156,7 @@ static size_t pdu_write(struct p9_fcall *pdu, const void *data, size_t size)
 
 				*sptr = kmalloc(len + 1, GFP_NOFS);
 				if (*sptr == NULL) {
-					errcode = -EFAULT;
+					errcode = -ENOMEM;
 					break;
 				}
 				if (pdu_read(pdu, *sptr, len)) {
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · piaojun

We should return -ENOMEM to upper user when kmalloc failed to indicate accurate errno.

Signed-off-by Jun Piao <[email protected]>
Reviewed-by Yiwen Jiang <[email protected]>
Quoted 18 lines
---
 net/9p/protocol.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/9p/protocol.c +1 -1
index 931ea00..4a1e1dd 100644
@@ -156,7 +156,7 @@ static size_t pdu_write(struct p9_fcall *pdu, const void *data, size_t size)
 
 				*sptr = kmalloc(len + 1, GFP_NOFS);
 				if (*sptr == NULL) {
-					errcode = -EFAULT;
+					errcode = -ENOMEM;
 					break;
 				}
 				if (pdu_read(pdu, *sptr, len)) {