Skip to contentSkip to conversation

usb: dwc3: Support option to disable USB2 LPM

PATCH New Roger Quadros 1 participant 1 message Nov 12, 2018 USB

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 usb: dwc3: Support option to disable USB2 LPM

Quoted 9 lines · Felipe Balbi

Hi,

Quoted 5 lines · Roger Quadros
Quoted 4 lines
Quoted 1 line

Also can we have some consistency in usage of '-' vs '_'?

Right.. I agree. I've been using '-' as it is the preferred syntax as most of the properties, but some old properties use '_'. Do you have any suggestion?

Quoted 8 lines
Quoted 3 lines

I'd keep it consistent to "snps,usb3_lpm_capable" so we avoid mistakes when writing the DT.
Felipe?

_ are not really accepted in DT, except for legacy properties. What we can do is rename usb3_lpm_capable to usb3-lpm-capable and change code to try with _ if - fails. Then we can introduce the new property using -

I agree. This is a better approach.

cheers,
-roger