Skip to contentSkip to conversation

question about xfstests case xfs/297

DISCUSSION Darrick J. Wong 2 participants 3 messages May 7, 2019 – May 9, 2019 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

[cc fstests]

Quoted 11 lines · xuyang

Hi darrick

since commit d0e484a("check: wipe scratch devices between tests")is merged into xfstests, when I running xfs/297 on kernel 5.1.0-rc5+ with xfsprogs-4.18.0-3.el8.x86_64, it causes a failure that log size is too small to reach the minimum size, as below:

#wipefs -a /dev/sda11 (20G)
/dev/sda11: 4 bytes were erased at offset 0x00000000 (xfs): 58 46 53 42 #mkfs.xfs -f -d agcount=16,su=256k,sw=12 -l su=256k,size=5120b /dev/sda11 log size 5120 blocks too small, minimum size is 5184 blocks

That's not related to wipefs at all.

The problem here is that your vendor's xfsprogs package turns on reflink by default. The reflink feature increases the minimum log size requirements, which this test doesn't account for, and hence it misses by 64 blocks. Evidently nobody at your vendor's QA department noticed?

I only noticed because I started carrying an "enable reflink by default" patch last Thursday and it caused a bunch of regressions on tests that call mkfs.xfs without looping in MKFS_OPTIONS. I will be sending out patches to fix all that shortly and will cc you on them.

Quoted 1 line

upstream xfsprogs doesn't have this problem.

Upstream xfsprogs doesn't enable reflink by default.

Quoted 3 lines

I am confused about why the min_logblocks becomes larger after wipefs. Is it a calculating minimum log size bug? Perhaps, I can adjust the logsize to 5184b. Can you give some advise?

Wait for the corrections and help me test them, please? :)

--D

Quoted 6 lines

Kind regards,
Yang Xu

#2 lore raw
Quoted 21 lines · Darrick J. Wong

[cc fstests]

Quoted 11 lines · xuyang

Hi darrick

since commit d0e484a("check: wipe scratch devices between tests")is merged into xfstests, when I running xfs/297 on kernel 5.1.0-rc5+ with xfsprogs-4.18.0-3.el8.x86_64, it causes a failure that log size is too small to reach the minimum size, as below:

#wipefs -a /dev/sda11 (20G)
/dev/sda11: 4 bytes were erased at offset 0x00000000 (xfs): 58 46 53 42 #mkfs.xfs -f -d agcount=16,su=256k,sw=12 -l su=256k,size=5120b /dev/sda11 log size 5120 blocks too small, minimum size is 5184 blocks

That's not related to wipefs at all.

The problem here is that your vendor's xfsprogs package turns on reflink by default. The reflink feature increases the minimum log size requirements, which this test doesn't account for, and hence it misses by 64 blocks. Evidently nobody at your vendor's QA department noticed?

Quoted 4 lines

I only noticed because I started carrying an "enable reflink by default" patch last Thursday and it caused a bunch of regressions on tests that call mkfs.xfs without looping in MKFS_OPTIONS. I will be sending out patches to fix all that shortly and will cc you on them.

I got it .

Quoted 10 lines
Quoted 1 line

upstream xfsprogs doesn't have this problem.

Upstream xfsprogs doesn't enable reflink by default.

Quoted 3 lines

I am confused about why the min_logblocks becomes larger after wipefs. Is it a calculating minimum log size bug? Perhaps, I can adjust the logsize to 5184b. Can you give some advise?

Wait for the corrections and help me test them, please? :)

--D

Hi Darrick

I have tested your patchset for 20 times(run seven affected cases), it's ok on my machine.

Quoted 7 lines
Quoted 5 lines

Kind regards,
Yang Xu

#3 lore raw
Quoted 34 lines · xuyang
Quoted 21 lines · Darrick J. Wong

[cc fstests]

Quoted 11 lines · xuyang

Hi darrick

since commit d0e484a("check: wipe scratch devices between tests")is merged into xfstests, when I running xfs/297 on kernel 5.1.0-rc5+ with xfsprogs-4.18.0-3.el8.x86_64, it causes a failure that log size is too small to reach the minimum size, as below:

#wipefs -a /dev/sda11 (20G)
/dev/sda11: 4 bytes were erased at offset 0x00000000 (xfs): 58 46 53 42 #mkfs.xfs -f -d agcount=16,su=256k,sw=12 -l su=256k,size=5120b /dev/sda11 log size 5120 blocks too small, minimum size is 5184 blocks

That's not related to wipefs at all.

The problem here is that your vendor's xfsprogs package turns on reflink by default. The reflink feature increases the minimum log size requirements, which this test doesn't account for, and hence it misses by 64 blocks. Evidently nobody at your vendor's QA department noticed?

Quoted 4 lines

I only noticed because I started carrying an "enable reflink by default" patch last Thursday and it caused a bunch of regressions on tests that call mkfs.xfs without looping in MKFS_OPTIONS. I will be sending out patches to fix all that shortly and will cc you on them.

I got it .

Quoted 6 lines
Quoted 1 line

upstream xfsprogs doesn't have this problem.

Upstream xfsprogs doesn't enable reflink by default.

Quoted 3 lines

I am confused about why the min_logblocks becomes larger after wipefs. Is it a calculating minimum log size bug? Perhaps, I can adjust the logsize to 5184b. Can you give some advise?

Quoted 7 lines
Quoted 4 lines

Wait for the corrections and help me test them, please? :)

--D

Hi Darrick

I have tested your patchset for 20 times(run seven affected cases), it's ok on my machine.

Cool! Could you reply to the patchset with your Tested-by, please? :)

--D

Quoted 10 lines
Quoted 8 lines
Quoted 6 lines

Kind regards,
Yang Xu