Skip to contentSkip to conversation

next/master build: 198 builds: 1 failed, 197 passed, 1 error, 148 warnings (next-20180110)

DISCUSSION Arnd Bergmann 4 participants 5 messages Jan 10, 2018 – Jan 11, 2018 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 5 lines · kernelci.org bot

next/master build: 198 builds: 1 failed, 197 passed, 1 error, 148 warnings (next-20180110)

Errors summary:
1 drivers/perf/arm_dsu_pmu.c:661:2: error: implicit declaration of function 'bitmap_from_u32array' [-Werror=implicit-function-declaration]

I sent a patch, waiting for it to get merged

Quoted 3 lines

Warnings summary:

1 arch/x86/kvm/mmu.c:5485:2: warning: ignoring return value of 'register_shrinker', declared with attribute warn_unused_result [-Wunused-result]

I have a patch for this, will send after some more testing.

Quoted 2 lines

14 drivers/gpu/drm/ttm/ttm_page_alloc_dma.c:1186:2: warning: ignoring return value of 'register_shrinker', declared with attribute warn_unused_result [-Wunused-result] 14 drivers/gpu/drm/ttm/ttm_page_alloc.c:485:2: warning: ignoring return value of 'register_shrinker', declared with attribute warn_unused_result [-Wunused-result]

ttm and kvm are now the last user of register_shrinker that doesn't propagate the return code to its
caller, all other callers got fixed in one way or another.

I tried to fix this one too, but couldn't come up with a proper way of unwinding both
kobject_init_and_add() and ttm_pool_mm_shrink_init():

        ret = kobject_init_and_add(&_manager->kobj, &ttm_pool_kobj_type,
                                   &glob->kobj, "pool");
        if (unlikely(ret != 0)) {
                kobject_put(&_manager->kobj);
                _manager = NULL;
                return ret;
        }

        ttm_pool_mm_shrink_init(_manager);

Calling kobject_put() after a failed kobject_init_and_add() seemed wrong, and it also appears to be missing a kfree(), so I didn't want to mess it up any further. Added a few people to Cc that touched this file most, maybe one of them can have a look, or they already have a patch waiting to get merged.

Quoted 2 lines

4 WARNING: modpost: missing MODULE_LICENSE() in net/9p/9pnet_xen.o
4 WARNING: modpost: missing MODULE_LICENSE() in drivers/auxdisplay/img-ascii-lcd.o

Patches for these two got posted a while ago but never picked up. I've merged those
into my tree, and plan to forward them to Andrew Morton.

Quoted 7 lines

3 WARNING: modpost: missing MODULE_LICENSE() in sound/soc/ux500/snd-soc-ux500-plat-dma.o 3 WARNING: modpost: missing MODULE_LICENSE() in sound/soc/ux500/snd-soc-ux500-mach-mop500.o 3 WARNING: modpost: missing MODULE_LICENSE() in drivers/video/fbdev/mmp/mmp_disp.o 2 WARNING: modpost: missing MODULE_LICENSE() in drivers/phy/qualcomm/phy-qcom-ufs.o 2 WARNING: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/cirrus/cs89x0.o 2 WARNING: modpost: missing MODULE_LICENSE() in arch/arm/mach-pxa/tosa-bt.o 2 WARNING: modpost: missing MODULE_LICENSE() in arch/arm/common/bL_switcher_dummy_if.o

I made patches for these now, will send them in a bit.

Quoted 5 lines

7 arch/arm/boot/dts/spear1340-evb.dtb: Warning (dmas_property): Property 'dmas', cell 4 is not a phandle reference in /ahb/apb/serial@b4100000
7 arch/arm/boot/dts/spear1340-evb.dtb: Warning (dmas_property): Missing property '#dma-cells' in node /interrupt-controller@ec801000 or bad phandle (referred from /ahb/apb/serial@b4100000:dmas[4]) 7 arch/arm/boot/dts/spear1310-evb.dtb: Warning (gpios_property): Property 'cs-gpios', cell 6 is not a phandle reference in /ahb/apb/spi@e0100000
7 arch/arm/boot/dts/spear1310-evb.dtb: Warning (gpios_property): Missing property '#gpio-cells' in node /interrupt-controller@ec801000 or bad phandle (referred from /ahb/apb/spi@e0100000:cs-gpios[6]) 2 arch/arm/boot/dts/spear600-evb.dtb: Warning (interrupts_property): Missing interrupt-parent for /ahb/apb/rtc@fc900000

Viresh, could you have a look here?

Quoted 2 lines

2 arch/arm/boot/dts/ste-nomadik-s8815.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000 2 arch/arm/boot/dts/ste-nomadik-nhk15.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000

Linus, can you look at this? I don't know which interrupt-parent is the right one here, maybe
you can find out from the hardware or some documentation you have.

Quoted 4 lines

2 arch/arm/boot/dts/lpc3250-phy3250.dtb: Warning (gpios_property): reset-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18 2 arch/arm/boot/dts/lpc3250-phy3250.dtb: Warning (gpios_property): power-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18 2 arch/arm/boot/dts/lpc3250-ea3250.dtb: Warning (gpios_property): reset-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18 2 arch/arm/boot/dts/lpc3250-ea3250.dtb: Warning (gpios_property): power-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18

I finally found the answer here and got a patch now.

Quoted 3 lines

6 arch/arm/boot/dts/stih410-b2260.dtb: Warning (gpios_property): hdmi,hpd-gpio property size (8) too small for cell size 2 in /soc/sti-display-subsystem/sti-hdmi@8d04000 6 arch/arm/boot/dts/stih410-b2120.dtb: Warning (gpios_property): hdmi,hpd-gpio property size (8) too small for cell size 2 in /soc/sti-display-subsystem/sti-hdmi@8d04000 6 arch/arm/boot/dts/stih407-b2120.dtb: Warning (gpios_property): hdmi,hpd-gpio property size (8) too small for cell size 2 in /soc/sti-display-subsystem/sti-hdmi@8d04000

Patrice Chotard sent a patch.

Quoted 2 lines

5 arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: Warning (cooling_device_property): Missing property '#cooling-cells' in node /cpus/cpu@100 or bad phandle (referred from /thermal-zones/cpu_thermal/cooling-maps/map@1:cooling-device[0]) 5 arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: Warning (cooling_device_property): Missing property '#cooling-cells' in node /cpus/cpu@0 or bad phandle (referred from /thermal-zones/cpu_thermal/cooling-maps/map@0:cooling-device[0])

I have an older patch that I should send.

Quoted 1 line

5 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dtb: Warning (interrupts_property): Missing interrupt-parent for /pmu

I'll get this one.

Quoted 2 lines

2 fs/cifs/smbdirect.c: In function 'smbd_recv_buf':
2 include/linux/spinlock.h:260:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]

Haven't seen this one yet, needs more investigation

Quoted 5 lines

2 arch/arm/boot/dts/s5pv210-torbreck.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000 2 arch/arm/boot/dts/s5pv210-smdkv210.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000 2 arch/arm/boot/dts/s5pv210-smdkc110.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000 2 arch/arm/boot/dts/s5pv210-goni.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000 2 arch/arm/boot/dts/s5pv210-aquila.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000

I need to pick up the right patch here.

Quoted 1 line

1 arch/x86/kernel/cpu/mcheck/mce.c:237:21: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

I have a patch, will send in a bit.

Quoted 1 line

2 arch/x86/kernel/cpu/bugs.c:79:12: warning: 'spectre_v2_enabled' defined but not used [-Wunused-variable]

Haven't run into this one yet.

Quoted 2 lines

1 arch/arm/mm/cache-b15-rac.c:353:1: warning: label 'out_unmap' defined but not used [-Wunused-label] 1 arch/arm/mm/cache-b15-rac.c:351:1: warning: label 'out_cpu_dead' defined but not used [-Wunused-label]

My patch is in Russell's patch tracker now.

Quoted 1 line

1 arch/arm/configs/omap2plus_defconfig:322:warning: symbol value 'm' invalid for LIRC

I need to address this.

Arnd
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw

Hi Arnd,

Am 10.01.2018 um 16:45 schrieb Arnd Bergmann:

Quoted 20 lines
Quoted 2 lines

14 drivers/gpu/drm/ttm/ttm_page_alloc_dma.c:1186:2: warning: ignoring return value of 'register_shrinker', declared with attribute warn_unused_result [-Wunused-result] 14 drivers/gpu/drm/ttm/ttm_page_alloc.c:485:2: warning: ignoring return value of 'register_shrinker', declared with attribute warn_unused_result [-Wunused-result]

ttm and kvm are now the last user of register_shrinker that doesn't propagate the return code to its
caller, all other callers got fixed in one way or another.

I tried to fix this one too, but couldn't come up with a proper way of unwinding both
kobject_init_and_add() and ttm_pool_mm_shrink_init():

         ret = kobject_init_and_add(&_manager->kobj, &ttm_pool_kobj_type,
                                    &glob->kobj, "pool");
         if (unlikely(ret != 0)) {
                 kobject_put(&_manager->kobj);
                 _manager = NULL;
                 return ret;
         }

         ttm_pool_mm_shrink_init(_manager);
Quoted 5 lines

Calling kobject_put() after a failed kobject_init_and_add() seemed wrong, and it also appears to be missing a kfree(), so I didn't want to mess it up any further. Added a few people to Cc that touched this file most, maybe one of them can have a look, or they already have a patch waiting to get merged.

That isn't urgent, isn't it? So I would say I put it on my TODO list and I'm going to take care of it no later than 4.17.

Otherwise Roger or me could take a look tomorrow.

Regards,
Christian.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw
Quoted 36 lines · Christian König

Hi Arnd,

Am 10.01.2018 um 16:45 schrieb Arnd Bergmann:

Quoted 26 lines
Quoted 7 lines

14 drivers/gpu/drm/ttm/ttm_page_alloc_dma.c:1186:2: warning: ignoring return value of 'register_shrinker', declared with attribute warn_unused_result [-Wunused-result]
14 drivers/gpu/drm/ttm/ttm_page_alloc.c:485:2: warning: ignoring return value of 'register_shrinker', declared with attribute warn_unused_result [-Wunused-result]

ttm and kvm are now the last user of register_shrinker that doesn't propagate the return code to its
caller, all other callers got fixed in one way or another.

I tried to fix this one too, but couldn't come up with a proper way of unwinding both
kobject_init_and_add() and ttm_pool_mm_shrink_init():

         ret = kobject_init_and_add(&_manager->kobj, &ttm_pool_kobj_type,
                                    &glob->kobj, "pool");
         if (unlikely(ret != 0)) {
                 kobject_put(&_manager->kobj);
                 _manager = NULL;
                 return ret;
         }

         ttm_pool_mm_shrink_init(_manager);
Quoted 5 lines

Calling kobject_put() after a failed kobject_init_and_add() seemed wrong, and it also appears to be missing a kfree(), so I didn't want to mess it up any further. Added a few people to Cc that touched this file most, maybe one of them can have a look, or they already have a patch waiting to get merged.

Quoted 4 lines

That isn't urgent, isn't it? So I would say I put it on my TODO list and I'm going to take care of it no later than 4.17.

Otherwise Roger or me could take a look tomorrow.

My understanding is that the warning will be in 4.16, so the fix should be as well, if only to get a clean build again. There were around a dozen such warnings when the warn_unused_result got added, but the others are all fixed in linux-next.

This is how the flag got added:

commit 64067c5cbfa24a2202b92e8fda7323610cad3043

Author: Tetsuo Handa <[email protected]>
Date:   Fri Jan 5 13:25:45 2018 +1100

mm,vmscan: mark register_shrinker() as __must_check

There are users not checking for register_shrinker() failure. Continuing with ignoring failure can lead to later oops at unregister_shrinker().

Arnd
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw

Calling kobject_put() after a failed kobject_init_and_add() seemed wrong, and it also appears to be missing a kfree(), so I didn't want to mess it up any further.

ttm_pool_kobj_release will do that, so no need kfree() here. I will fix this warning today. Thanks.

Thanks
Roger(Hongbo.He)

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Arnd Bergmann
Sent: Thursday, January 11, 2018 12:18 AM
To: Koenig, Christian <[email protected]>
Cc: kernelci.org bot <[email protected]>; Kernel Build Reports Mailman List <[email protected]>; Linux Kernel Mailing List <[email protected]>; Thomas Hellstrom <[email protected]>; Dave Airlie <[email protected]>; He, Roger <[email protected]>; Maarten Lankhorst <[email protected]>; Francisco Jerez <[email protected]>; Viresh Kumar <[email protected]>; Shiraz Hashim <[email protected]>; Linus Walleij <[email protected]>; dri-devel <[email protected]>
Subject: Re: next/master build: 198 builds: 1 failed, 197 passed, 1 error, 148 warnings (next-20180110)

Quoted 36 lines · Christian König

Hi Arnd,

Am 10.01.2018 um 16:45 schrieb Arnd Bergmann:

Quoted 26 lines
Quoted 7 lines

14 drivers/gpu/drm/ttm/ttm_page_alloc_dma.c:1186:2: warning:
ignoring return value of 'register_shrinker', declared with attribute warn_unused_result [-Wunused-result]
14 drivers/gpu/drm/ttm/ttm_page_alloc.c:485:2: warning: ignoring return value of 'register_shrinker', declared with attribute warn_unused_result [-Wunused-result]

ttm and kvm are now the last user of register_shrinker that doesn't propagate the return code to its caller, all other callers got fixed in one way or another.

I tried to fix this one too, but couldn't come up with a proper way of unwinding both
kobject_init_and_add() and ttm_pool_mm_shrink_init():

         ret = kobject_init_and_add(&_manager->kobj, &ttm_pool_kobj_type,
                                    &glob->kobj, "pool");
         if (unlikely(ret != 0)) {
                 kobject_put(&_manager->kobj);
                 _manager = NULL;
                 return ret;
         }

         ttm_pool_mm_shrink_init(_manager);
Quoted 5 lines

Calling kobject_put() after a failed kobject_init_and_add() seemed wrong, and it also appears to be missing a kfree(), so I didn't want to mess it up any further. Added a few people to Cc that touched this file most, maybe one of them can have a look, or they already have a patch waiting to get merged.

Quoted 4 lines

That isn't urgent, isn't it? So I would say I put it on my TODO list and I'm going to take care of it no later than 4.17.

Otherwise Roger or me could take a look tomorrow.

My understanding is that the warning will be in 4.16, so the fix should be as well, if only to get a clean build again. There were around a dozen such warnings when the warn_unused_result got added, but the others are all fixed in linux-next.

This is how the flag got added:

commit 64067c5cbfa24a2202b92e8fda7323610cad3043

Author: Tetsuo Handa <[email protected]>
Date:   Fri Jan 5 13:25:45 2018 +1100

mm,vmscan: mark register_shrinker() as __must_check

There are users not checking for register_shrinker() failure. Continuing with ignoring failure can lead to later oops at unregister_shrinker().

Arnd
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#5 lore raw
In reply to Arnd Bergmann
Quoted 7 lines · Arnd Bergmann
Quoted 5 lines

7 arch/arm/boot/dts/spear1340-evb.dtb: Warning (dmas_property): Property 'dmas', cell 4 is not a phandle reference in /ahb/apb/serial@b4100000
7 arch/arm/boot/dts/spear1340-evb.dtb: Warning (dmas_property): Missing property '#dma-cells' in node /interrupt-controller@ec801000 or bad phandle (referred from /ahb/apb/serial@b4100000:dmas[4]) 7 arch/arm/boot/dts/spear1310-evb.dtb: Warning (gpios_property): Property 'cs-gpios', cell 6 is not a phandle reference in /ahb/apb/spi@e0100000
7 arch/arm/boot/dts/spear1310-evb.dtb: Warning (gpios_property): Missing property '#gpio-cells' in node /interrupt-controller@ec801000 or bad phandle (referred from /ahb/apb/spi@e0100000:cs-gpios[6]) 2 arch/arm/boot/dts/spear600-evb.dtb: Warning (interrupts_property): Missing interrupt-parent for /ahb/apb/rtc@fc900000

Viresh, could you have a look here?

Sent fixes for all of them to you.

Signature · 1 line
viresh