Skip to contentSkip to conversation

about the format problem at generic/556, and supply a fix patch

PATCH 蔡晓斌 3 participants 6 messages Apr 2, 2024 – Apr 13, 2024

lore
Share & tools
lore

蔡晓斌

author
#0 lore raw

Hi, when I test my project with xfstests, I found that format problem at generic/556, it looks no like a script, so I adjust format and look so well.

Below is the concent of the patch, and patch file at attachments:

From 40ff753ffb3dd4ab8789699dc45a83ece64a3626 Mon Sep 17 00:00:00 2001
From: "cai.xiaobin" <[email protected]>
Date: Wed, 20 Mar 2024 11:13:29 +0800
Subject: [PATCH] generic/556: reverse the order of comments to make the file look more like a script file

---
 tests/generic/556 | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/556 +0 -1
index 404a3243..ccefbcc4 100755
@@ -1,5 +1,5 @@
-# SPDX-License-Identifier: GPL-2.0+

 #!/bin/bash
+# SPDX-License-Identifier: GPL-2.0+
 # FS QA Test No. 556
 #
 # Test the basic functionality of filesystems with case-insensitive --
2.25.1

Thank you and looking forward to your reply.

From 40ff753ffb3dd4ab8789699dc45a83ece64a3626 Mon Sep 17 00:00:00 2001
From: "cai.xiaobin" <[email protected]>
Date: Wed, 20 Mar 2024 11:13:29 +0800
Subject: [PATCH] generic/556: reverse the order of comments to make the file
look more like a script file

---
 tests/generic/556 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/556 +1 -1
index 404a3243..ccefbcc4 100755
@@ -1,5 +1,5 @@
-# SPDX-License-Identifier: GPL-2.0+
 #!/bin/bash
+# SPDX-License-Identifier: GPL-2.0+
 # FS QA Test No. 556
 #
 # Test the basic functionality of filesystems with case-insensitive
Signature · 1 line
2.25.1
Reviewed-by
#1 lore raw

Hi,

On Tue, 2 Apr 2024 09:41:49 +0800 (CST), 蔡晓斌 wrote:
...

Quoted 17 lines

From 40ff753ffb3dd4ab8789699dc45a83ece64a3626 Mon Sep 17 00:00:00 2001
From: "cai.xiaobin" <[email protected]>
Date: Wed, 20 Mar 2024 11:13:29 +0800
Subject: [PATCH] generic/556: reverse the order of comments to make the file look more like a script file

---
 tests/generic/556 | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/556 +0 -0
index 404a3243..ccefbcc4 100755

tests/generic/556 line 5

Quoted 6 lines
tests/generic/556 +1 -1
@@ -1,5 +1,5 @@
-# SPDX-License-Identifier: GPL-2.0+
  #!/bin/bash
+# SPDX-License-Identifier: GPL-2.0+
  # FS QA Test No. 556
  #
  # Test the basic functionality of filesystems with case-insensitive

Looks fine to me, although I'd suggest a simpler patch description:
generic/556: move shebang to first line

author
#2 lore raw
Quoted 32 lines · David Disseldorp

Hi,

On Tue, 2 Apr 2024 09:41:49 +0800 (CST), 蔡晓斌 wrote:
...

Quoted 17 lines

From 40ff753ffb3dd4ab8789699dc45a83ece64a3626 Mon Sep 17 00:00:00 2001
From: "cai.xiaobin" <[email protected]>
Date: Wed, 20 Mar 2024 11:13:29 +0800
Subject: [PATCH] generic/556: reverse the order of comments to make the file look more like a script file

---
 tests/generic/556 | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/556 +0 -0
index 404a3243..ccefbcc4 100755

tests/generic/556 line 5

Quoted 6 lines
tests/generic/556 +1 -1
@@ -1,5 +1,5 @@
-# SPDX-License-Identifier: GPL-2.0+
  #!/bin/bash
+# SPDX-License-Identifier: GPL-2.0+
  # FS QA Test No. 556
  #
  # Test the basic functionality of filesystems with case-insensitive

Looks fine to me, although I'd suggest a simpler patch description:
generic/556: move shebang to first line

Quoted 1 line

Wow, your suggestion is good. Do I need to provide another patch with a correction commit? Thank you for your reply.

#3 lore raw
Quoted 36 lines · 蔡晓斌
Quoted 32 lines · David Disseldorp

Hi,

On Tue, 2 Apr 2024 09:41:49 +0800 (CST), 蔡晓斌 wrote:
...

Quoted 17 lines

From 40ff753ffb3dd4ab8789699dc45a83ece64a3626 Mon Sep 17 00:00:00 2001
From: "cai.xiaobin" <[email protected]>
Date: Wed, 20 Mar 2024 11:13:29 +0800
Subject: [PATCH] generic/556: reverse the order of comments to make the file look more like a script file

---
 tests/generic/556 | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/556 +0 -0
index 404a3243..ccefbcc4 100755

tests/generic/556 line 5

Quoted 6 lines
tests/generic/556 +1 -1
@@ -1,5 +1,5 @@
-# SPDX-License-Identifier: GPL-2.0+
  #!/bin/bash
+# SPDX-License-Identifier: GPL-2.0+
  # FS QA Test No. 556
  #
  # Test the basic functionality of filesystems with case-insensitive

Looks fine to me, although I'd suggest a simpler patch description:
generic/556: move shebang to first line

Quoted 5 lines
Quoted 1 line

Wow, your suggestion is good. Do I need to provide another patch with a correction commit? Thank you for your reply.

Looks like there're many special characters in this patch, please send a normal "pure text" patch, with a proper subject and commit log.

Thanks,
Zorro

author
#4 lore raw
Quoted 7 lines · Zorro Lang
Quoted 1 line · 蔡晓斌

Looks like there're many special characters in this patch, please send a normal "pure text" patch, with a proper subject and commit log.

The content of patch as below and see attachment for the file.

From edf74d60a83554ad2c85a86ab032767eafe75a9e Mon Sep 17 00:00:00 2001
From: cz0807bin <[email protected]>
Date: Sun, 7 Apr 2024 09:47:20 +0800
Subject: [PATCH] generic/556: move shebang to first line.

There is format problem of tests/generic/556 file and looks not like a script when it run. So makes a change of order of first line to looks well.

---
 tests/generic/556 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/556 +1 -1
index 404a3243..ccefbcc4 100755
@@ -1,5 +1,5 @@
-# SPDX-License-Identifier: GPL-2.0+
 #!/bin/bash
+# SPDX-License-Identifier: GPL-2.0+
 # FS QA Test No. 556
 #
 # Test the basic functionality of filesystems with case-insensitive
Signature · 4 lines
2.25.1

If there is any question about the patch, please tell me how to do, and I will fix it.
Thank you for reply.

From edf74d60a83554ad2c85a86ab032767eafe75a9e Mon Sep 17 00:00:00 2001
From: cz0807bin <[email protected]>
Date: Sun, 7 Apr 2024 09:47:20 +0800
Subject: [PATCH] generic/556: move shebang to first line.

There is format problem of tests/generic/556 file and looks not like a script when it run. So makes a change of order of first line to looks well.

---
 tests/generic/556 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/556 +1 -1
index 404a3243..ccefbcc4 100755
@@ -1,5 +1,5 @@
-# SPDX-License-Identifier: GPL-2.0+
 #!/bin/bash
+# SPDX-License-Identifier: GPL-2.0+
 # FS QA Test No. 556
 #
 # Test the basic functionality of filesystems with case-insensitive
Signature · 1 line
2.25.1
#5 lore raw
Quoted 10 lines · 蔡晓斌
Quoted 7 lines · Zorro Lang
Quoted 1 line · 蔡晓斌

Looks like there're many special characters in this patch, please send a normal "pure text" patch, with a proper subject and commit log.

The content of patch as below and see attachment for the file.

Generally we don't accept a patch as an attachment. But as this patch is simple, I don't mind manually changing it and commit with your name (for once). But ...

Quoted 3 lines

From edf74d60a83554ad2c85a86ab032767eafe75a9e Mon Sep 17 00:00:00 2001
From: cz0807bin <[email protected]>

Is the "cz0807bin" your name ?

Quoted 5 lines

Date: Sun, 7 Apr 2024 09:47:20 +0800
Subject: [PATCH] generic/556: move shebang to first line.

There is format problem of tests/generic/556 file and looks not like a script when it run. So makes a change of order of first line to looks well.

Don't you need a Signoff-by ?

Thanks,
Zorro

Quoted 20 lines
---
 tests/generic/556 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/556 +1 -1
index 404a3243..ccefbcc4 100755
@@ -1,5 +1,5 @@
-# SPDX-License-Identifier: GPL-2.0+
 #!/bin/bash
+# SPDX-License-Identifier: GPL-2.0+
 # FS QA Test No. 556
 #
 # Test the basic functionality of filesystems with case-insensitive
Signature · 4 lines
2.25.1

If there is any question about the patch, please tell me how to do, and I will fix it.
Thank you for reply.