Skip to contentSkip to conversation

nfs: remove incorrect fallthrough label

PATCH linmiaohe 1 participant 1 message Sep 17, 2020

Subsystems (2)
lore
Share & tools
lore

linmiaohe

author Reviewed-by
#0 lore raw
Quoted 13 lines · Nick Desaulniers

There is no case after the default from which to fallthrough to. Clang will error in this case (unhelpfully without context, see link below) and GCC will with -Wswitch-unreachable.

The previous commit should have just replaced the comment with a break statement.

If we consider implicit fallthrough to be a design mistake of C, then all case statements should be terminated with one of the following statements:
* break
* continue
* return
* __attribute__(__fallthrough__)
* goto (plz no)
* (call of function with __attribute__(__noreturn__))

Quoted 5 lines
Fixes 2a1390c95a69 ("nfs: Convert to use the preferred fallthrough macro")

---