Skip to contentSkip to conversation

MAC Address reading procedure in board.c

U-Boot Drasko DRASKOVIC 2 participants 3 messages May 25, 2009 – May 26, 2009

lore
Share & tools
lore
#0 lore raw

Hi all,
I have been looking at MAC addr obtaining procedure in lib_arm/board.c and I am puzzled with this implementation :

/* MAC Address */

    {
        int i;
        ulong reg;
        char *s, *e;
        char tmp[64];

        i = getenv_r ("ethaddr", tmp, sizeof (tmp));
        s = (i > 0) ? tmp : NULL;

        *for (reg = 0; reg < 6; ++reg) {
            gd->bd->bi_enetaddr[reg] = s ? simple_strtoul (s, &e, 16) : 0;
            if (s)
                s = (*e) ? e + 1 : e;*
        }
    }

Here are my questions:
1) In which format is kept the addr in environment (i.e. why do we allocate 64 byte buffer tmp)? This is a little bit tricky to see from the code, so I thought maybe somebody will know.

2) In my opinion - there should be some delimiters (maybe ':') in this eth addr string in environment, so we are here jumping over them :*

    if (s)
        s = (*e) ? e + 1 : e;

*but I still cannot see - how long are these strings between delimiters? (Because when you call simple_strtoul(), it will proceed to the first non-digit character, so who knows how long. As long as simple_stroul() is concerned, if it do not meet nonhexdigit char, it can go to Moon and beyond). Why we did not took two chars to represent each of 6 bytes + delimiters (':'), which would make 6*2 + 5 = 11, which should be the length of the tmp buffer. Then take two-by-two chars and transform them into number.
What am I missing here?

Thanks and best regards,
Drasko

#1 lore raw

Dear Drasko DRASKOVIC,

Quoted 6 lines · In message <[email protected]> you…

I have been looking at MAC addr obtaining procedure in lib_arm/board.c and I am puzzled with this implementation :

/* MAC Address */

Quoted 15 lines
    {
        int i;
        ulong reg;
        char *s, *e;
        char tmp[64];

        i = getenv_r ("ethaddr", tmp, sizeof (tmp));
        s = (i > 0) ? tmp : NULL;

        *for (reg = 0; reg < 6; ++reg) {
            gd->bd->bi_enetaddr[reg] = s ? simple_strtoul (s, &e, 16) : 0;
            if (s)
                s = (*e) ? e + 1 : e;*
        }
    }

That must be very old code. Please update to a recent version before trying to understand this.

Quoted 4 lines

Here are my questions:
1) In which format is kept the addr in environment (i.e. why do we allocate 64 byte buffer tmp)? This is a little bit tricky to see from the code, so I thought maybe somebody will know.

It's stored as a string "aa:bb:cc:dd:ee:ff". 64 is sufficiently large to catch most (acccidential) incorrect input.

Quoted 5 lines

2) In my opinion - there should be some delimiters (maybe ':') in this eth addr string in environment, so we are here jumping over them :*

    if (s)
        s = (*e) ? e + 1 : e;

*but I still cannot see - how long are these strings between delimiters?

Usually these are 2 characters long, but they can be aby size. You can write "0:1:2:3:4:5" or "0000:1:0002:2:04:000000005" as well, as long as you don't exceed the maximum of sizeof(tmp).

Quoted 5 lines

beyond). Why we did not took two chars to represent each of 6 bytes + delimiters (':'), which would make 6*2 + 5 = 11, which should be the length of the tmp buffer. Then take two-by-two chars and transform them into number.
What am I missing here?

Why should we make such a restriction? Why do you want to force me to type two characters when one may be sufficient?

Best regards,

Wolfgang Denk

Signature · 8 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Hello! I'm from outer space,  and I've made myself look like a signa-
ture.  While  you  are reading this, I'm having sex with your eyes. I
know it feels good to you, because you're smiling. I'm very horny, so
send me to someone else when you've had enough. Thanks!
                              Sincerely, A Stranger in a Strange Land
#2 lore raw

Hi Wolfgang,
first of all thanks a lot for your answers.

Quoted 22 lines · Wolfgang Denk

Dear Drasko DRASKOVIC,

In message <[email protected]>

Quoted 2 lines · you

I have been looking at MAC addr obtaining procedure in lib_arm/board.c

and I

Quoted 4 lines

am puzzled with this implementation :

/* MAC Address */

Quoted 11 lines
    {
        int i;
        ulong reg;
        char *s, *e;
        char tmp[64];

        i = getenv_r ("ethaddr", tmp, sizeof (tmp));
        s = (i > 0) ? tmp : NULL;

        *for (reg = 0; reg < 6; ++reg) {
            gd->bd->bi_enetaddr[reg] = s ? simple_strtoul (s, &e, 16) :
Quoted 9 lines

0;

Quoted 4 lines
            if (s)
                s = (*e) ? e + 1 : e;*
        }
    }

That must be very old code. Please update to a recent version before trying to understand this.

I know that you are strongly suggesting that newes code should be used, but sometimes it is just not my choice (although I always advocate for the newes version).

Quoted 10 lines
Quoted 3 lines

Here are my questions:
1) In which format is kept the addr in environment (i.e. why do we

allocate

Quoted 1 line

64 byte buffer tmp)? This is a little bit tricky to see from the code, so

I

Quoted 1 line

thought maybe somebody will know.

It's stored as a string "aa:bb:cc:dd:ee:ff". 64 is sufficiently large to catch most (acccidential) incorrect input.

Perfect! I started jumping through the tags and got lost in the see of code. "Go to the lists...", the inner voice was telling me.

Quoted 10 lines
Quoted 1 line

2) In my opinion - there should be some delimiters (maybe ':') in this

eth

Quoted 4 lines

addr string in environment, so we are here jumping over them :*

    if (s)
        s = (*e) ? e + 1 : e;

*but I still cannot see - how long are these strings between delimiters?

Usually these are 2 characters long, but they can be aby size. You can write "0:1:2:3:4:5" or "0000:1:0002:2:04:000000005" as well, as long as you don't exceed the maximum of sizeof(tmp).

Aaah. Now I get it ;)

Quoted 11 lines
Quoted 4 lines

beyond). Why we did not took two chars to represent each of 6 bytes + delimiters (':'), which would make 6*2 + 5 = 11, which should be the

length

Quoted 3 lines

of the tmp buffer. Then take two-by-two chars and transform them into number.
What am I missing here?

Why should we make such a restriction? Why do you want to force me to type two characters when one may be sufficient?

You are absolutly right (I guess that was frustration of the moment talking here).

Quoted 5 lines

Best regards,

Wolfgang Denk

Once again, thanks for your valuable answers. Perfect support - as always ;).

Best regards,
Drasko