open posix testsuite and names of testcases
Hi!
Quoted 13 lines
Quoted 13 lines
Quoted 12 lines
Quoted 6 lines
I'm not against renaming sources, just thinking if there is less intrusive way to achieve same result. I believe all Makefiles are generated,
so other option that comes to mind would be to modifyscripts/generate-makefiles.sh.
Any thoughts about this approach?We can hack the script to generate Makefiles that include the dir name
into the binary name which would be less intrusive but on the other hand
that would break the rule thatfoo.cgenerates foo.run_test...
Quoted 4 lines
Quoted 1 line
Caspar, Wanlong, any preference / thoughts?
I vote to changing the rule of generating the Makefiles, it's simple and the simple rule change is easy to be accepted. Agree?
Ok. I will look into this and hopefully commit a patch soon enough.
Signature · 12 lines
Cyril Hrubis [email protected] ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
Hi!
Quoted 4 lines
Quoted 2 lines
I vote to changing the rule of generating the Makefiles, it's simple and the simple rule change is easy to be accepted. Agree?
Ok. I will look into this and hopefully commit a patch soon enough.
I tried to change the generate-makefiles.sh script, but there are some problems.
Some tests are shell scripts that doesn't have build phase. I've workarounded them by adding build rules that just copy them to name_x-y.sh in the build phase, which unfortunatelly haven't fixed all the problems.
We have quite quite a lot of tests (~270) that are shell scripts that prints "This is tested implicitly via assertion xyz" and returns zero. I'm quite tempted to remove them. These just increase tests run time, log sizes, etc. but doesn't do any actual work.
Then there are more problematic ones, shell tests that calls one binary with different parameters. As in sigignore for example. The paths and names are obviously hardcoded, which makes them fail. The fix for such cases will depend case by case but what I will probably do is to make each test self-contained, but I haven't analyzed all the failures yet.
Signature · 12 lines
Cyril Hrubis [email protected] ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
Quoted 13 lines
I tried to change the
generate-makefiles.shscript, but there are some problems.Some tests are shell scripts that doesn't have build phase. I've workarounded them by adding build rules that just copy them to
name_x-y.shin the build phase, which unfortunatelly haven't fixed all the problems.We have quite quite a lot of tests (~270) that are shell scripts that prints "This is tested implicitly via assertion xyz" and returns zero. I'm quite tempted to remove them. These just increase tests run time, log sizes, etc. but doesn't do any actual work.
Quoted 5 lines
Then there are more problematic ones, shell tests that calls one binary with different parameters. As in sigignore for example. The paths and names are obviously hardcoded, which makes them fail. The fix for such cases will depend case by case but what I will probably do is to make each test self-contained, but I haven't analyzed all the failures yet.
Good news everyone, I've just commited a patch that modifies the script that generates the Makefiles (since I've fixed all the issues that blocked this change).
Now the test binaries and scripts are prefixed with the directory such as 'sigaction_'. I've did some testruns and everything seems fine.
Please tests.
Signature · 13 lines
Cyril Hrubis [email protected] ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
Hi!
Quoted 11 lines
I think I didn't see these ones failing before:
Failed testcases:
stress/mqueues/mqueues_multi_send_rev_1
stress/mqueues/mqueues_multi_send_rev_2from logfile.stress-test:
stress/mqueues/mqueues_multi_send_rev_1: execution: FAILED: Output:
Usage: ./mqueues_multi_send_rev_1.run-testnumber_of_threadsstress/mqueues/mqueues_multi_send_rev_2: execution: FAILED: Output:
Usage: ./mqueues_multi_send_rev_2.run-testnumber_of_threads
Quoted 5 lines
Tweaking
bin/run-tests.shor just renaming those ".args" files should do the trick.# find . | grep .args ./stress/mqueues/multi_send_rev_1.args ./stress/mqueues/multi_send_rev_2.args
Thanks I've missed this.
Given that these are only two occurencies I've commited a patch that just renames the arg files.
Signature · 13 lines
Cyril Hrubis [email protected] ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list