Skip to contentSkip to conversation

MT7915E doesn't work any more with v6.9

REGRESSION Oleksandr Natalenko 5 participants 14 messages May 14, 2024 – May 27, 2024

Subsystems (2)
Arm MediaTek Regressions
lore
Share & tools
lore

Oleksandr Natalenko

author
#0 lore raw

Hello Felix, Lorenzo et al.

With v6.9 kernel the following card:

01:00.0 Unclassified device [0002]: MEDIATEK Corp. MT7915E 802.11ax PCI Express Wireless Network Adapter [14c3:7915]

doesn't work any more. Upon mt7915e module insertion the following splat happens:

mt7915e 0000:01:00.0: enabling device (0000 -> 0002)

WARNING: CPU: 3 PID: 1648 at net/mac80211/main.c:794 ieee80211_alloc_hw_nm+0x9a3/0x9f0 [mac80211]
Call Trace:
 <TASK>
 mt76_alloc_device+0x24/0x290 [mt76 46e2c4f11be089903469a4d6045c71cb7842b4cd]
 mt7915_mmio_probe+0x33/0x1d0 [mt7915e 9657e1926e619568545a08636674805d5e665c85]
 mt7915_pci_probe+0xe1/0x3a0 [mt7915e 9657e1926e619568545a08636674805d5e665c85]
 pci_device_probe+0xf0/0x2d0
 really_probe+0xde/0x3b0
 __driver_probe_device+0x78/0x110
 driver_probe_device+0x1f/0x130
 __driver_attach+0x91/0x1e0
 bus_for_each_dev+0x105/0x160
 bus_add_driver+0x137/0x270
 driver_register+0x72/0xd0
 mt7915_init+0x44/0xff0 [mt7915e 9657e1926e619568545a08636674805d5e665c85]
 do_one_initcall+0x5b/0x310
 do_init_module+0x60/0x220
 init_module_from_file+0x89/0xe0
 idempotent_init_module+0x121/0x2b0
 __x64_sys_finit_module+0x5e/0xb0
 do_syscall_64+0x82/0x160
 entry_SYSCALL_64_after_hwframe+0x76/0x7e

mt7915e 0000:01:00.0: probe with driver mt7915e failed with error -12

and the card stays non-functional. Re-inserting the module triggers the same behaviour.

The following condition is triggered:

794 if (WARN_ON(!ops->add_chanctx ||

 795                             !ops->remove_chanctx ||
 796                             !ops->change_chanctx ||
 797                             !ops->assign_vif_chanctx ||
 798                             !ops->unassign_vif_chanctx))

799 return NULL;

This worked with v6.8 and earlier just fine.

Please help.

Thank you.

Signature · 1 line
Oleksandr Natalenko (post-factum)
author
#1 lore raw

Also /cc Johannes because of this commit:

6092077ad09ce wifi: mac80211: introduce 'channel request'

Quoted 51 lines · SELČ Oleksandr Natalenko

Hello Felix, Lorenzo et al.

With v6.9 kernel the following card:

01:00.0 Unclassified device [0002]: MEDIATEK Corp. MT7915E 802.11ax PCI Express Wireless Network Adapter [14c3:7915]

doesn't work any more. Upon mt7915e module insertion the following splat happens:

mt7915e 0000:01:00.0: enabling device (0000 -> 0002)

WARNING: CPU: 3 PID: 1648 at net/mac80211/main.c:794 ieee80211_alloc_hw_nm+0x9a3/0x9f0 [mac80211]
Call Trace:
 <TASK>
 mt76_alloc_device+0x24/0x290 [mt76 46e2c4f11be089903469a4d6045c71cb7842b4cd]
 mt7915_mmio_probe+0x33/0x1d0 [mt7915e 9657e1926e619568545a08636674805d5e665c85]
 mt7915_pci_probe+0xe1/0x3a0 [mt7915e 9657e1926e619568545a08636674805d5e665c85]
 pci_device_probe+0xf0/0x2d0
 really_probe+0xde/0x3b0
 __driver_probe_device+0x78/0x110
 driver_probe_device+0x1f/0x130
 __driver_attach+0x91/0x1e0
 bus_for_each_dev+0x105/0x160
 bus_add_driver+0x137/0x270
 driver_register+0x72/0xd0
 mt7915_init+0x44/0xff0 [mt7915e 9657e1926e619568545a08636674805d5e665c85]
 do_one_initcall+0x5b/0x310
 do_init_module+0x60/0x220
 init_module_from_file+0x89/0xe0
 idempotent_init_module+0x121/0x2b0
 __x64_sys_finit_module+0x5e/0xb0
 do_syscall_64+0x82/0x160
 entry_SYSCALL_64_after_hwframe+0x76/0x7e

mt7915e 0000:01:00.0: probe with driver mt7915e failed with error -12

and the card stays non-functional. Re-inserting the module triggers the same behaviour.

The following condition is triggered:

794 if (WARN_ON(!ops->add_chanctx ||

 795                             !ops->remove_chanctx ||
 796                             !ops->change_chanctx ||
 797                             !ops->assign_vif_chanctx ||
 798                             !ops->unassign_vif_chanctx))

799 return NULL;

This worked with v6.8 and earlier just fine.

Please help.

Thank you.

Signature · 1 line
Oleksandr Natalenko (post-factum)
#2 lore raw

(please don't top post)

Quoted 3 lines · Oleksandr Natalenko

Also /cc Johannes because of this commit:

6092077ad09ce wifi: mac80211: introduce 'channel request'

Have you tried reverting that commit?

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#3 lore raw
In reply to Oleksandr Natalenko
Quoted 13 lines · Oleksandr Natalenko

Also /cc Johannes because of this commit:

6092077ad09ce wifi: mac80211: introduce 'channel request'

Quoted 8 lines · SELČ Oleksandr Natalenko

Hello Felix, Lorenzo et al.

With v6.9 kernel the following card:

01:00.0 Unclassified device [0002]: MEDIATEK Corp. MT7915E 802.11ax PCI Express Wireless Network Adapter [14c3:7915]

doesn't work any more. Upon mt7915e module insertion the following splat happens:

6.9 didn't get commit 2f7cf3b61d85 ("wifi: mt76: mt7915: add missing chanctx ops")? Huh?

johannes

author
#4 lore raw

Hello Johannes.

Quoted 10 lines · SELČ Johannes Berg
Quoted 9 lines · Oleksandr Natalenko

Also /cc Johannes because of this commit:

6092077ad09ce wifi: mac80211: introduce 'channel request'

Quoted 4 lines · SELČ Oleksandr Natalenko

Hello Felix, Lorenzo et al.

With v6.9 kernel the following card:

Quoted 7 lines
Quoted 4 lines
Quoted 4 lines

01:00.0 Unclassified device [0002]: MEDIATEK Corp. MT7915E 802.11ax PCI Express Wireless Network Adapter [14c3:7915]

doesn't work any more. Upon mt7915e module insertion the following splat happens:

6.9 didn't get commit 2f7cf3b61d85 ("wifi: mt76: mt7915: add missing chanctx ops")? Huh?

Yes, you are right, this commit is not present in v6.9, and I can find it in the "next" branch only.

I can also confirm this commit fixes the regression for me.

Thank you.

Quoted 2 lines

johannes

Signature · 1 line
Oleksandr Natalenko (post-factum)
#5 lore raw
Quoted 9 lines · Oleksandr Natalenko
Quoted 8 lines · SELČ Johannes Berg
Quoted 7 lines · Oleksandr Natalenko

Also /cc Johannes because of this commit:

6092077ad09ce wifi: mac80211: introduce 'channel request'

Quoted 2 lines · SELČ Oleksandr Natalenko

Hello Felix, Lorenzo et al.

Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
Quoted 4 lines

With v6.9 kernel the following card:

01:00.0 Unclassified device [0002]: MEDIATEK Corp. MT7915E 802.11ax PCI Express Wireless Network Adapter [14c3:7915] doesn't work any more. Upon mt7915e module insertion the following splat happens:

6.9 didn't get commit 2f7cf3b61d85 ("wifi: mt76: mt7915: add missing chanctx ops")? Huh?

FWIW, seems there was and earlier report about this that I missed:
https://lore.kernel.org/all/CAAMvbhGHe4PM5M=JJZRQ2m5_aVZ=4DPG76MT+q5qi3HA+7_wzQ@mail.gmail.com/

Quoted 3 lines

Yes, you are right, this commit is not present in v6.9, and I can find it in the "next" branch only.

I can also confirm this commit fixes the regression for me.

So all we need to resolve this is to ask Greg to pick up the patch for the next 6.9.y. release? Then I'll take care of that in a few hours, unless somebody else does it first or I get some kind of "might be a bad idea for now" signal from anyone.

Ciao, Thorsten

#6 lore raw
Quoted 21 lines · Linux regression tracking (Thorsten Leemhuis)
Quoted 9 lines · Oleksandr Natalenko
Quoted 8 lines · SELČ Johannes Berg
Quoted 7 lines · Oleksandr Natalenko

Also /cc Johannes because of this commit:

6092077ad09ce wifi: mac80211: introduce 'channel request'

Quoted 2 lines · SELČ Oleksandr Natalenko

Hello Felix, Lorenzo et al.

Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
Quoted 4 lines

With v6.9 kernel the following card:

01:00.0 Unclassified device [0002]: MEDIATEK Corp. MT7915E 802.11ax PCI Express Wireless Network Adapter [14c3:7915] doesn't work any more. Upon mt7915e module insertion the following splat happens:

6.9 didn't get commit 2f7cf3b61d85 ("wifi: mt76: mt7915: add missing chanctx ops")? Huh?

FWIW, seems there was and earlier report about this that I missed:
https://lore.kernel.org/all/CAAMvbhGHe4PM5M=JJZRQ2m5_aVZ=4DPG76MT+q5qi3HA+7_wzQ@mail.gmail.com/

Quoted 8 lines
Quoted 3 lines

Yes, you are right, this commit is not present in v6.9, and I can find it in the "next" branch only.

I can also confirm this commit fixes the regression for me.

So all we need to resolve this is to ask Greg to pick up the patch for the next 6.9.y. release? Then I'll take care of that in a few hours, unless somebody else does it first or I get some kind of "might be a bad idea for now" signal from anyone.

Now picked up for 6.9.y.

greg k-h

#7 lore raw
In reply to Oleksandr Natalenko
Quoted 18 lines · Oleksandr Natalenko

Hello Johannes.

Quoted 15 lines · SELČ Johannes Berg
Quoted 13 lines · Oleksandr Natalenko

Also /cc Johannes because of this commit:

6092077ad09ce wifi: mac80211: introduce 'channel request'

Quoted 8 lines · SELČ Oleksandr Natalenko

Hello Felix, Lorenzo et al.

With v6.9 kernel the following card:

01:00.0 Unclassified device [0002]: MEDIATEK Corp. MT7915E 802.11ax PCI Express Wireless Network Adapter [14c3:7915]

doesn't work any more. Upon mt7915e module insertion the following splat happens:

Quoted 6 lines
Quoted 2 lines

6.9 didn't get commit 2f7cf3b61d85 ("wifi: mt76: mt7915: add missing chanctx ops")? Huh?

Yes, you are right, this commit is not present in v6.9, and I can find it in the "next" branch only.

I can also confirm this commit fixes the regression for me.

Thanks for testing.

#regzbot fix: 2f7cf3b61d85

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#8 lore raw
In reply to Johannes Berg
Quoted 10 lines · Johannes Berg
Quoted 9 lines · Oleksandr Natalenko

Also /cc Johannes because of this commit:

6092077ad09ce wifi: mac80211: introduce 'channel request'

Quoted 4 lines · SELČ Oleksandr Natalenko

Hello Felix, Lorenzo et al.

With v6.9 kernel the following card:

Quoted 7 lines
Quoted 4 lines
Quoted 4 lines

01:00.0 Unclassified device [0002]: MEDIATEK Corp. MT7915E 802.11ax PCI Express Wireless Network Adapter [14c3:7915]

doesn't work any more. Upon mt7915e module insertion the following splat happens:

6.9 didn't get commit 2f7cf3b61d85 ("wifi: mt76: mt7915: add missing chanctx ops")? Huh?

Ah, it will be only in v6.10-rc1. Oleksandr, can you try this commit:

https://git.kernel.org/linus/2f7cf3b61d85

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#9 lore raw
In reply to Johannes Berg
Quoted 10 lines · Johannes Berg
Quoted 9 lines · Oleksandr Natalenko

Also /cc Johannes because of this commit:

6092077ad09ce wifi: mac80211: introduce 'channel request'

Quoted 4 lines · SELČ Oleksandr Natalenko

Hello Felix, Lorenzo et al.

With v6.9 kernel the following card:

Quoted 8 lines
Quoted 5 lines
Quoted 5 lines

01:00.0 Unclassified device [0002]: MEDIATEK Corp. MT7915E 802.11ax PCI Express Wireless Network Adapter [14c3:7915]

doesn't work any more. Upon mt7915e module insertion the following splat happens:

6.9 didn't get commit 2f7cf3b61d85 ("wifi: mt76: mt7915: add missing chanctx ops")? Huh?

Yeah, commit 2f7cf3b61d85 should have been taken to wireless tree but it fell through the cracks. I didn't realise that it's an important bugfix and the commit message didn't give any indication of that either.

But commit 2f7cf3b61d85 is now in Linus' tree so it would be good if someone could submit it to stable releases.

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#10 lore raw
Quoted 21 lines · Kalle Valo
Quoted 10 lines · Johannes Berg
Quoted 9 lines · Oleksandr Natalenko

Also /cc Johannes because of this commit:

6092077ad09ce wifi: mac80211: introduce 'channel request'

Quoted 4 lines · SELČ Oleksandr Natalenko

Hello Felix, Lorenzo et al.

With v6.9 kernel the following card:

Quoted 8 lines
Quoted 5 lines
Quoted 5 lines

01:00.0 Unclassified device [0002]: MEDIATEK Corp. MT7915E 802.11ax PCI Express Wireless Network Adapter [14c3:7915]

doesn't work any more. Upon mt7915e module insertion the following splat happens:

6.9 didn't get commit 2f7cf3b61d85 ("wifi: mt76: mt7915: add missing chanctx ops")? Huh?

Quoted 6 lines

Yeah, commit 2f7cf3b61d85 should have been taken to wireless tree but it fell through the cracks. I didn't realise that it's an important bugfix and the commit message didn't give any indication of that either.

But commit 2f7cf3b61d85 is now in Linus' tree so it would be good if someone could submit it to stable releases.

Johannes pointed out to me that the commit is already in stable:

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-6.9.y&id=ddb02739a2be54ed922bce3cb57d5f901590ee70

So all should be good now.

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#11 lore raw
In reply to Kalle Valo
Quoted 21 lines · Kalle Valo
Quoted 10 lines · Johannes Berg
Quoted 9 lines · Oleksandr Natalenko

Also /cc Johannes because of this commit:

6092077ad09ce wifi: mac80211: introduce 'channel request'

Quoted 4 lines · SELČ Oleksandr Natalenko

Hello Felix, Lorenzo et al.

With v6.9 kernel the following card:

Quoted 8 lines
Quoted 5 lines
Quoted 5 lines

01:00.0 Unclassified device [0002]: MEDIATEK Corp. MT7915E 802.11ax PCI Express Wireless Network Adapter [14c3:7915]

doesn't work any more. Upon mt7915e module insertion the following splat happens:

6.9 didn't get commit 2f7cf3b61d85 ("wifi: mt76: mt7915: add missing chanctx ops")? Huh?

Quoted 6 lines

Yeah, commit 2f7cf3b61d85 should have been taken to wireless tree but it fell through the cracks. I didn't realise that it's an important bugfix and the commit message didn't give any indication of that either.

But commit 2f7cf3b61d85 is now in Linus' tree so it would be good if someone could submit it to stable releases.

It's already in 6.9.1, does it need to go anywhere else?

thanks,

greg k-h

#12 lore raw
Quoted 10 lines · Greg KH
Quoted 7 lines

Yeah, commit 2f7cf3b61d85 should have been taken to wireless tree but it fell through the cracks. I didn't realise that it's an important bugfix and the commit message didn't give any indication of that either.

But commit 2f7cf3b61d85 is now in Linus' tree so it would be good if someone could submit it to stable releases.

It's already in 6.9.1, does it need to go anywhere else?

No, but apparently we need a similar commit for mt7915e or something? I have no idea why I missed those. I'll take a look tomorrow.

johannes

#13 lore raw
In reply to Oleksandr Natalenko
Quoted 40 lines · Oleksandr Natalenko

Hello Felix, Lorenzo et al.

With v6.9 kernel the following card:

01:00.0 Unclassified device [0002]: MEDIATEK Corp. MT7915E 802.11ax PCI Express Wireless Network Adapter [14c3:7915]

doesn't work any more. Upon mt7915e module insertion the following splat happens:

mt7915e 0000:01:00.0: enabling device (0000 -> 0002)

WARNING: CPU: 3 PID: 1648 at net/mac80211/main.c:794
ieee80211_alloc_hw_nm+0x9a3/0x9f0 [mac80211]
Call Trace:
 <TASK>
 mt76_alloc_device+0x24/0x290 [mt76 46e2c4f11be089903469a4d6045c71cb7842b4cd]
 mt7915_mmio_probe+0x33/0x1d0 [mt7915e 9657e1926e619568545a08636674805d5e665c85]
 mt7915_pci_probe+0xe1/0x3a0 [mt7915e 9657e1926e619568545a08636674805d5e665c85]
 pci_device_probe+0xf0/0x2d0
 really_probe+0xde/0x3b0
 __driver_probe_device+0x78/0x110
 driver_probe_device+0x1f/0x130
 __driver_attach+0x91/0x1e0
 bus_for_each_dev+0x105/0x160
 bus_add_driver+0x137/0x270
 driver_register+0x72/0xd0
 mt7915_init+0x44/0xff0 [mt7915e 9657e1926e619568545a08636674805d5e665c85]
 do_one_initcall+0x5b/0x310
 do_init_module+0x60/0x220
 init_module_from_file+0x89/0xe0
 idempotent_init_module+0x121/0x2b0
 __x64_sys_finit_module+0x5e/0xb0
 do_syscall_64+0x82/0x160
 entry_SYSCALL_64_after_hwframe+0x76/0x7e

mt7915e 0000:01:00.0: probe with driver mt7915e failed with error -12

and the card stays non-functional. Re-inserting the module triggers the same behaviour.

The following condition is triggered:

Quoted 8 lines

794 if (WARN_ON(!ops->add_chanctx ||

 795                             !ops->remove_chanctx ||
 796                             !ops->change_chanctx ||
 797                             !ops->assign_vif_chanctx ||
 798                             !ops->unassign_vif_chanctx))

799 return NULL;

This worked with v6.8 and earlier just fine.

Thanks for the report. I'll add this to regzbot for easier tracking:

#regzbot introduced: v6.8..v6.9 ^

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches