Skip to contentSkip to conversation

f2fs: compress: Avoid memory leak on cc->cpages

PATCH Markus Elfring 2 participants 3 messages Jul 20, 2020

lore
Share & tools
lore
#0 lore raw
Quoted 3 lines

Memory allocated for storing compressed pages' poitner should be released after f2fs_write_compressed_pages(), otherwise it will cause memory leak issue.

* Would an imperative wording be more appropriate (without a typo) for the change description?

* Will the tag “Fixes” become helpful for the commit message?

Regards,
Markus

_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

#1 lore raw
Quoted 8 lines · Markus Elfring
Quoted 3 lines

Memory allocated for storing compressed pages' poitner should be released after f2fs_write_compressed_pages(), otherwise it will cause memory leak issue.

* Would an imperative wording be more appropriate (without a typo) for the change description?

* Will the tag “Fixes” become helpful for the commit message?

It looks this is replied from patch-robot? since I found all comments you replied are almost the same.

And what's funny is that the reply starts being caught by another patch-bot from Greg...

https://lkml.org/lkml/2020/6/28/157

Quoted 5 lines

Regards,
Markus
.

#2 lore raw
Quoted 11 lines
Quoted 8 lines
Quoted 3 lines

Memory allocated for storing compressed pages' poitner should be released after f2fs_write_compressed_pages(), otherwise it will cause memory leak issue.

* Would an imperative wording be more appropriate (without a typo) for the change description?

* Will the tag “Fixes” become helpful for the commit message?

It looks this is replied from patch-robot? since I found all comments you replied are almost the same.

I dare to repeat such suggestions because several patches contain improvable details (not only in the affected source code).

Regards,
Markus

_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel