Skip to contentSkip to conversation

Remove unnecessary condition check

PATCH In review Diego Calleja 2 participants 2 messages Aug 12, 2019 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove unnecessary condition check

extent_io.c:__extent_writepage_io has this code:

if (!compressed)

	...

else if (compressed)

---
 fs/btrfs/extent_io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/extent_io.c +1 -1
index 1ff438fd5bc2..a53fb7b8a262 100644
@@ -3498,7 +3498,7 @@ static noinline_for_stack int __extent_writepage_io(struct inode *inode,
 				btrfs_writepage_endio_finish_ordered(page, cur,
 							    cur + iosize - 1,
 							    1);
-			else if (compressed) {
+			else {
 				/* we don't want to end_page_writeback on
 				 * a compressed extent.  this happens
 				 * elsewhere
Signature · 1 line
2.22.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Diego Calleja

extent_io.c:__extent_writepage_io has this code:

if (!compressed)

	...

else if (compressed)

Quoted 18 lines
---
 fs/btrfs/extent_io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/extent_io.c +1 -1
index 1ff438fd5bc2..a53fb7b8a262 100644
@@ -3498,7 +3498,7 @@ static noinline_for_stack int __extent_writepage_io(struct inode *inode,
 				btrfs_writepage_endio_finish_ordered(page, cur,
 							    cur + iosize - 1,
 							    1);
-			else if (compressed) {
+			else {
 				/* we don't want to end_page_writeback on
 				 * a compressed extent.  this happens
 				 * elsewhere