Skip to contentSkip to conversation

ACPI: driver: Drop driver_data pointer clearing from two drivers

PATCH New Rafael J. Wysocki 1 participant 1 message Feb 13 ACPI

lore
Share & tools
lore

Rafael J. Wysocki

author maintainer
#0 lore raw

PATCH 1/1 ACPI: driver: Drop driver_data pointer clearing from two drivers

From: Rafael J. Wysocki <[email protected]>

It is not necessary to clear the driver_data pointer in the ACPI companion device object on driver remove in the EC and SMBUS HC ACPI drivers because that pointer is not used there any more after recent changes.

Drop the unnecessary statements.

---

Applies on top of the current mainline.

---
 drivers/acpi/ec.c    |    2 --
 drivers/acpi/sbshc.c |    2 --
 2 files changed, 4 deletions(-)
drivers/acpi/ec.c +0 -2
@@ -1754,12 +1754,10 @@ err:
 
 static void acpi_ec_remove(struct platform_device *pdev)
 {
-	struct acpi_device *device = ACPI_COMPANION(&pdev->dev);
 	struct acpi_ec *ec = platform_get_drvdata(pdev);
 
 	release_region(ec->data_addr, 1);
 	release_region(ec->command_addr, 1);
-	device->driver_data = NULL;
 	if (ec != boot_ec) {
 		ec_remove_handlers(ec);
 		acpi_ec_free(ec);
drivers/acpi/sbshc.c +0 -2
@@ -275,13 +275,11 @@ static int acpi_smbus_hc_probe(struct pl
 
 static void acpi_smbus_hc_remove(struct platform_device *pdev)
 {
-	struct acpi_device *device = ACPI_COMPANION(&pdev->dev);
 	struct acpi_smb_hc *hc = platform_get_drvdata(pdev);
 
 	acpi_ec_remove_query_handler(hc->ec, hc->query_bit);
 	acpi_os_wait_events_complete();
 	kfree(hc);
-	device->driver_data = NULL;
 }
 
 module_platform_driver(acpi_smb_hc_driver);