Skip to contentSkip to conversation

dt-bindings: synopsys-dw-mshc-common: add "fifo-access-32bit" property

PATCH Krzysztof Kozlowski 2 participants 4 messages Mar 12, 2023 1 message not in the archive MMC, SD and SDIO

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 11 lines · Sergey Lisov
Quoted 11 lines · Sergey Lisov
Quoted 9 lines
Quoted 6 lines

Anyway, I said last time this looks compatible-specific, so I don't think we need another property.

Best regards,
Krzysztof

I agree, but I'm afraid of introducing regressions by enabling this workaround on systems that don't actually need it.

Quoted 7 lines
Quoted 1 line

I don't understand why would you enable it for systems which do not need it?

OK, then how do I find out which boards have the bug? My only idea is "search for samsung,exynos7-dw-mshc through all devicetrees, find vendor kernels for each of those boards, and check if they have the workaround". Is it really that better than enabling it selectively only for known-affected boards?

There is no way this is board specific. This is SoC specific. I mentioned it last time.

Best regards,
Krzysztof

#2 lore raw
Quoted 2 lines

There is no way this is board specific. This is SoC specific. I mentioned it last time.

The same compatible string ("samsung,exynos7-dw-mshc{,-smu}") is used by several devices on different Exynos SoCs. And I was only able to find a vendor kernel fork for one of them (exynos7885-jackpotlte, it has the workaround, but it depends on a configuration option and I don't have the config file for that device).

#3 lore raw
In reply to Krzysztof Kozlowski
Quoted 2 lines

There is no way this is board specific. This is SoC specific. I mentioned it last time.

The same compatible string ("samsung,exynos7-dw-mshc{,-smu}") is used by several devices on different Exynos SoCs. And I was only able to find a vendor kernel fork for one of them (exynos7885-jackpotlte, it has the workaround, but it depends on a configuration option and I don't have the config file for that device).

#4 lore raw
In reply to Krzysztof Kozlowski
Quoted 2 lines

There is no way this is board specific. This is SoC specific. I mentioned it last time.

The same compatible string ("samsung,exynos7-dw-mshc{,-smu}") is used by several devices on different Exynos SoCs. And I was only able to find a vendor kernel fork for one of them (exynos7885-jackpotlte, it has the workaround, but it depends on a configuration option and I don't have the config file for that device).