Skip to contentSkip to conversation

stable-rc/linux-5.10.y bisection: baseline.bootrr.deferred-probe-empty on rk3399-rock-pi-4b

DISCUSSION Mark Brown 1 participant 1 message Oct 16, 2023 1 message not in the archive Stable branch

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Mark Brown

author
#1 lore raw

On Mon, Oct 16, 2023 at 10:05:52AM -0700, KernelCI bot wrote:

The KernelCI bisection bot has found out that the new feature enablement in 77806f63c317 ("arm64: dts: rockchip: add ES8316 codec for ROCK Pi 4") in v5.10-rc is missing some dependency, it causes there to be a device that fails deferred probe. Full report below with logs and so on:

Quoted 153 lines

* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *

* This automated bisection report was sent to you on the basis  *
* that you may be involved with the breaking commit it has      *
* found.  No manual investigation has been done to verify it,   *
* and the root cause of the problem may be somewhere else.      *
*                                                               *
* If you do send a fix, please include this trailer:            *
*   Reported-by: "kernelci.org bot" <[email protected]>          *
*                                                               *
* Hope this helps!                                              *

* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *

stable-rc/linux-5.10.y bisection: baseline.bootrr.deferred-probe-empty on rk3399-rock-pi-4b

Summary:

  Start:      f622826e6370 Linux 5.10.199-rc1
  Plain log:  https://storage.kernelci.org/stable-rc/linux-5.10.y/v5.10.198-84-gf622826e6370/arm64/defconfig/gcc-10/lab-collabora/baseline-rk3399-rock-pi-4b.txt
  HTML log:   https://storage.kernelci.org/stable-rc/linux-5.10.y/v5.10.198-84-gf622826e6370/arm64/defconfig/gcc-10/lab-collabora/baseline-rk3399-rock-pi-4b.html
  Result:     77806f63c317 arm64: dts: rockchip: add ES8316 codec for ROCK Pi 4

Checks:
revert: PASS
verify: PASS

Parameters:

  Tree:       stable-rc
  URL:        https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
  Branch:     linux-5.10.y
  Target:     rk3399-rock-pi-4b
  CPU arch:   arm64
  Lab:        lab-collabora
  Compiler:   gcc-10
  Config:     defconfig
  Test case:  baseline.bootrr.deferred-probe-empty

Breaking commit found:

-------------------------------------------------------------------------------
commit 77806f63c317cab3392f3ab7d4c6d392fb4a5da9

Author: Alex Bee <[email protected]>
Date:   Fri Jun 18 20:12:55 2021 +0200

arm64: dts: rockchip: add ES8316 codec for ROCK Pi 4

[ Upstream commit 65bd2b8bdb3bddc37bea695789713916327e1c1f ]

ROCK Pi 4 boards have the codec connected to i2s0 and it is accessible via i2c1 address 0x11.
Add an audio-graph-card for it.

Signed-off-by Alex Bee <[email protected]>
Link https://lore.kernel.org/r/[email protected] open here
Signed-off-by Heiko Stuebner <[email protected]>

Stable-dep-of: cee572756aa2 ("arm64: dts: rockchip: Disable HS400 for eMMC on ROCK Pi 4")

Signed-off-by Sasha Levin <[email protected]>
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi +28 -1
index 6dc6dee6c13e..f80cdb021f7f 100644
@@ -31,6 +31,12 @@ sdio_pwrseq: sdio-pwrseq {
 		reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>;
 	};
 
+	sound {
+		compatible = "audio-graph-card";
+		label = "Analog";
+		dais = <&i2s0_p0>;
+	};
+
 	vcc12v_dcin: dc-12v {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc12v_dcin";

@@ -417,6 +423,20 @@ &i2c1 {
 	i2c-scl-rising-time-ns = <300>;
 	i2c-scl-falling-time-ns = <15>;
 	status = "okay";
+
+	es8316: codec@11 {
+		compatible = "everest,es8316";
+		reg = <0x11>;
+		clocks = <&cru SCLK_I2S_8CH_OUT>;
+		clock-names = "mclk";
+		#sound-dai-cells = <0>;
+
+		port {
+			es8316_p0_0: endpoint {
+				remote-endpoint = <&i2s0_p0_0>;
+			};
+		};
+	};
 };
 
 &i2c3 {

@@ -435,6 +455,14 @@ &i2s0 {
 	rockchip,playback-channels = <8>;
 	rockchip,capture-channels = <8>;
 	status = "okay";
+
+	i2s0_p0: port {
+		i2s0_p0_0: endpoint {
+			dai-format = "i2s";
+			mclk-fs = <256>;
+			remote-endpoint = <&es8316_p0_0>;
+		};
+	};
 };
 
 &i2s1 {
-------------------------------------------------------------------------------

Git bisection log:

-------------------------------------------------------------------------------
git bisect start
# good: [da742ebfa00c3add4a358dd79ec92161c07e1435] Linux 5.10.191
git bisect good da742ebfa00c3add4a358dd79ec92161c07e1435
# bad: [f622826e6370c6d2feea54f778f491562a3df5d7] Linux 5.10.199-rc1
git bisect bad f622826e6370c6d2feea54f778f491562a3df5d7
# bad: [ffed0c8fcf043946f2bf09bd2a9caa1ca5289959] scsi: mpt3sas: Perform additional retries if doorbell read returns 0 git bisect bad ffed0c8fcf043946f2bf09bd2a9caa1ca5289959
# bad: [92704dd05521841357173973e43d822f99af477b] media: pulse8-cec: handle possible ping error
git bisect bad 92704dd05521841357173973e43d822f99af477b
# bad: [23e59874657c6396abb82544f6f60d100d84ee6a] objtool/x86: Fixup frame-pointer vs rethunk
git bisect bad 23e59874657c6396abb82544f6f60d100d84ee6a
# good: [3b76d92636791261c004979fd1c94edc68058d3e] tracing/probes: Fix to update dynamic data counter if fetcharg uses it git bisect good 3b76d92636791261c004979fd1c94edc68058d3e
# bad: [fba59a4b55ae582b0b2a86cb2f854385c69f2761] arm64: dts: rockchip: add SPDIF node for ROCK Pi 4 git bisect bad fba59a4b55ae582b0b2a86cb2f854385c69f2761
# good: [bd30aa9c7febb6e709670cd5154194189ca3b7b5] xfrm: add NULL check in xfrm_update_ae_params
git bisect good bd30aa9c7febb6e709670cd5154194189ca3b7b5
# good: [0a9040dedec21fbf362437d35f5e6f57735c06d2] i40e: fix misleading debug logs
git bisect good 0a9040dedec21fbf362437d35f5e6f57735c06d2
# good: [73990370d63d7416e5efd41669d4a8407bc41e92] bus: ti-sysc: Flush posted write on enable before reset git bisect good 73990370d63d7416e5efd41669d4a8407bc41e92
# good: [1411c3e86e66cc30f4dee15937276ed33598b787] arm64: dts: rockchip: use USB host by default on rk3399-rock-pi-4 git bisect good 1411c3e86e66cc30f4dee15937276ed33598b787
# bad: [77806f63c317cab3392f3ab7d4c6d392fb4a5da9] arm64: dts: rockchip: add ES8316 codec for ROCK Pi 4 git bisect bad 77806f63c317cab3392f3ab7d4c6d392fb4a5da9

# first bad commit: [77806f63c317cab3392f3ab7d4c6d392fb4a5da9] arm64: dts: rockchip: add ES8316 codec for ROCK Pi 4
-------------------------------------------------------------------------------

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47485): https://groups.io/g/kernelci-results/message/47485
Mute This Topic: https://groups.io/mt/102000345/1131744
Group Owner: [email protected]
Unsubscribe: https://groups.io/g/kernelci-results/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-