staging: cxt1e1: remove redundant memset() call
PATCH 2/2 staging: cxt1e1: remove redundant memset() call
The name array doens't need to set to 0. Because
sprintf/snprintf adds a terminating '\0'.
And also it doesn't need to assign name array
address to np pointer.
Signed-off-by Daeseok Youn <[email protected]>
--- drivers/staging/cxt1e1/linux.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-)
drivers/staging/cxt1e1/linux.c +3 -5
@@ -204,15 +204,13 @@ status_t c4_wq_port_init(mpi_t *pi) { -char name[16 ], *np;/* NOTE: name of the queue limited by system +char name[16 ];/* NOTE: name of the queue limited by system * to 10 characters */ -if (pi->wq_port)return 0 ;/* already initialized */ - np = name; -memset (name,0 ,16 ); -sprintf (np,"%s%d" , pi->up->devname, pi->portnum);/* IE pmcc4-01) */ +/* IE pmcc4-01 */ +snprintf (name,sizeof (name),"%s%d" , pi->up->devname, pi->portnum);#ifdef RLD_RESTART_DEBUG pr_info(">> %s: creating workqueue <%s> for Port %d.\n",
Signature · 1 line
1.7.4.4