Skip to contentSkip to conversation

s390: qeth: Avoid unneeded command name lookup

PATCH Jean Delvare 1 participant 1 message Sep 12, 2018 1 message not in the archive s390

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi Julian,

Quoted 3 lines · Julian Wiedmann

Thanks Jean, but I'd rather pass on this one. I don't see an improvement in readability, and performance just isn't a concern for this specific path... there's hardly any traffic on the interface's control plane.

Sure, you will know better. The initial optimization of qeth_get_ipa_msg() and qeth_get_ipa_cmd_name() made me wonder if maybe performance was considered important on these paths, and this is why I wanted to pay attention that my changes would not cause a performance regression. If there is no such concern then all is well and this second patch is indeed not needed.

Thanks,

Signature · 2 lines
Jean Delvare
SUSE L3 Support