INPUT: gpio_keys.c: Added OF support and enabled use with I2C GPIO expanders
A message that is not in the archive (sent off-list or not yet received): 6613128190865466111@unknownmsgid
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 17 lines · On Thu, 2 Jun 2011 15:18:29 +0530 Shubhrajyoti Datta…
Quoted 3 lines · On Wed, Jun 1, 2011 at 2:37 PM, <[email protected]> wrote:
From: David Jander <[email protected]>
You may want to briefly explain the changes.
<Snip>
Quoted 9 lines
(quoted diff) +1
-0+ input = input_allocate_device(); if (!ddata || !input) { dev_err(dev, "failed to allocate state\n");@@ -465,12 +585,12 @@ static int __devinit gpio_keys_probe(struct platform_device *pdev) ddata->disable = pdata->disable; mutex_init(&ddata->disable_lock);
Quoted 8 lines
Review static int __devinit gpio_keys_probe(struct · line 593
Quoted 7 lines
(quoted diff) +2
-2- platform_set_drvdata(pdev, ddata); + dev_set_drvdata(dev, ddata); input_set_drvdata(input, ddata); - input->name = pdev->name; + input->name = "GPIO_keyboard";Why this change?
Good question.... somehow it isn't necessary anymore, and it was quite wrong anyway. Thanks for pointing out, must have slipped over this....
Best regards,
Signature · 2 lines
David Jander Protonic Holland.