Skip to contentSkip to conversation

media: ti: Use devm_platform_get_and_ioremap_resource() in ti_csi2rx_probe()

PATCH Superseded Markus Elfring 2 participants 4 messages Feb 5, 2024 – Feb 7, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: ti: Use devm_platform_get_and_ioremap_resource() in ti_csi2rx_probe()

From: Markus Elfring <[email protected]>
Date: Mon, 5 Feb 2024 13:14:00 +0100

A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6 ("drivers: provide devm_platform_get_and_ioremap_resource()").
Thus reuse existing functionality instead of keeping duplicate source code.

This issue was detected by using the Coccinelle software.

---
 drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c +1 -3
index 2b078c5d7f5d..6ff066097346 100644
@@ -1100,9 +1100,7 @@ static int ti_csi2rx_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, csi);
 
 	mutex_init(&csi->mutex);
-
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	csi->shim = devm_ioremap_resource(&pdev->dev, res);
+	csi->shim = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
 	if (IS_ERR(csi->shim)) {
 		ret = PTR_ERR(csi->shim);
 		goto err_mutex;

--
2.43.0

Reviewed-by on v1 1/1
#1 lore raw

Hi Markus,

Thanks for the patch.

Quoted 19 lines · Markus Elfring

From: Markus Elfring <[email protected]>
Date: Mon, 5 Feb 2024 13:14:00 +0100

A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6 ("drivers: provide devm_platform_get_and_ioremap_resource()").
Thus reuse existing functionality instead of keeping duplicate source code.

This issue was detected by using the Coccinelle software.

---
 drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c +0 -0
index 2b078c5d7f5d..6ff066097346 100644

drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c static int ti_csi2rx_probe(struct platform_device *pdev) · line 1104

Quoted 5 lines
drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c +0 -2
@@ -1100,9 +1100,7 @@ static int ti_csi2rx_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, csi);
 
 	mutex_init(&csi->mutex);
-
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

As this "res" variable is not used anywhere else, it would be better to drop the declaration for it and instead call:

    csi->shim = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);

With that change,

Quoted 8 lines
drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c +1 -2
-	csi->shim = devm_ioremap_resource(&pdev->dev, res);
+	csi->shim = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
 	if (IS_ERR(csi->shim)) {
 		ret = PTR_ERR(csi->shim);
 		goto err_mutex;
--

2.43.0

Signature · 4 lines
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145
#2 lore raw

PATCH v2 1/1 media: ti: Use devm_platform_ioremap_resource() in ti_csi2rx_probe()

From: Markus Elfring <[email protected]>
Date: Tue, 6 Feb 2024 15:30:13 +0100

A wrapper function is available since the commit 7945f929f1a77a1c8887a97ca07f87626858ff42 ("drivers: provide devm_platform_ioremap_resource()").

* Thus reuse existing functionality instead of keeping duplicate source code.

* Delete a local variable which became unnecessary with this refactoring.

This issue was transformed by using the Coccinelle software.

---

v2:
The transformation pattern was adjusted based on advices by known contributors.

Examples:
* Doug Anderson
* Geert Uytterhoeven
* Robin Murphy

 drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c +1 -4
index 2b078c5d7f5d..54aba055c96b 100644
@@ -1089,7 +1089,6 @@ static void ti_csi2rx_cleanup_vb2q(struct ti_csi2rx_dev *csi)
 static int ti_csi2rx_probe(struct platform_device *pdev)
 {
 	struct ti_csi2rx_dev *csi;
-	struct resource *res;
 	int ret;
 
 	csi = devm_kzalloc(&pdev->dev, sizeof(*csi), GFP_KERNEL);
@@ -1100,9 +1099,7 @@ static int ti_csi2rx_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, csi);
 
 	mutex_init(&csi->mutex);
-
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	csi->shim = devm_ioremap_resource(&pdev->dev, res);
+	csi->shim = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(csi->shim)) {
 		ret = PTR_ERR(csi->shim);
 		goto err_mutex;

--
2.43.0

Reviewed-by on v2 1/1
#3 lore raw

Re: [PATCH v2] media: ti: Use devm_platform_ioremap_resource() in ti_csi2rx_probe()

Hi Markus,

Quoted 6 lines · Markus Elfring

From: Markus Elfring <[email protected]>
Date: Tue, 6 Feb 2024 15:30:13 +0100

A wrapper function is available since the commit 7945f929f1a77a1c8887a97ca07f87626858ff42 ("drivers: provide devm_platform_ioremap_resource()").

Quoted 8 lines

* Thus reuse existing functionality instead of keeping duplicate source code.

* Delete a local variable which became unnecessary with this refactoring.

This issue was transformed by using the Coccinelle software.

Quoted 40 lines

---

v2:
The transformation pattern was adjusted based on advices by known contributors.

Examples:
* Doug Anderson
* Geert Uytterhoeven
* Robin Murphy

 drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c +1 -5
index 2b078c5d7f5d..54aba055c96b 100644
@@ -1089,7 +1089,6 @@ static void ti_csi2rx_cleanup_vb2q(struct ti_csi2rx_dev *csi)
 static int ti_csi2rx_probe(struct platform_device *pdev)
 {
 	struct ti_csi2rx_dev *csi;
-	struct resource *res;
 	int ret;
 
 	csi = devm_kzalloc(&pdev->dev, sizeof(*csi), GFP_KERNEL);
@@ -1100,9 +1099,7 @@ static int ti_csi2rx_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, csi);
 
 	mutex_init(&csi->mutex);
-
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	csi->shim = devm_ioremap_resource(&pdev->dev, res);
+	csi->shim = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(csi->shim)) {
 		ret = PTR_ERR(csi->shim);
 		goto err_mutex;
--

2.43.0

Signature · 4 lines
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145