Skip to contentSkip to conversation

mmc: sdio: fix kernel panic when remove non-standard SDIO card

PATCH 欧阳炜钊(Weizhao Ouyang) 2 participants 3 messages Oct 12, 2022 – Oct 14, 2022 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw
Quoted 17 lines · Ulf Hansson
Quoted 9 lines · Weizhao Ouyang

From: Matthew Ma <[email protected]>

SDIO tuple is only allocated for standard SDIO card, especially it causes memory corruption issues when the non-standard SDIO card has removed since the card device's reference counter does not increase for it at sdio_init_func(), but all SDIO card device reference counter has decreased at sdio_release_func().

Quoted 4 lines
Fixes 1a632f8cdc33 ("sdio: split up common and function CIS parsing")
Quoted 5 lines

Apologize for the delay!

Wow, that's a very old bug you fixed! However, it looks like the fixed commit should be changed to 6f51be3d37df ("sdio: allow non-standard SDIO cards").

Thanks, I messed the tag.

Quoted 5 lines

I tried to apply the patch, but the patch format seems to be corrupt. Did you use git format-patch and did run ./scripts/checkpatch.pl on it?

Yeah I used checkpatch.pl with strict mode to check this patch, and it has no obvious style problems. What's the format error you got?

Thanks,
Weizhao

#1 lore raw
Quoted 28 lines · 欧阳炜钊(Weizhao Ouyang)
Quoted 17 lines · Ulf Hansson
Quoted 9 lines · Weizhao Ouyang

From: Matthew Ma <[email protected]>

SDIO tuple is only allocated for standard SDIO card, especially it causes memory corruption issues when the non-standard SDIO card has removed since the card device's reference counter does not increase for it at sdio_init_func(), but all SDIO card device reference counter has decreased at sdio_release_func().

Quoted 4 lines
Fixes 1a632f8cdc33 ("sdio: split up common and function CIS parsing")
Quoted 5 lines

Apologize for the delay!

Wow, that's a very old bug you fixed! However, it looks like the fixed commit should be changed to 6f51be3d37df ("sdio: allow non-standard SDIO cards").

Thanks, I messed the tag.

Quoted 1 line
Quoted 7 lines
Quoted 4 lines

I tried to apply the patch, but the patch format seems to be corrupt. Did you use git format-patch and did run ./scripts/checkpatch.pl on it?

Yeah I used checkpatch.pl with strict mode to check this patch, and it has no obvious style problems. What's the format error you got?

ERROR: patch seems to be corrupt (line wrapped?)
#130: FILE: drivers/mmc/core/sdio_bus.c:291:
struct sdio_func *func = dev_to_sdio_func(dev);

total: 1 errors, 0 warnings, 9 lines checked

If you haven't read the submitting-patches guidelines [1], I strongly recommend you to have a look.
For example, it explains why you should use git send-email, if you aren't doing that already.

Kind regards
Uffe

[1]
https://www.kernel.org/doc/html/v6.0/process/submitting-patches.html

#2 lore raw
Quoted 37 lines · Ulf Hansson
Quoted 4 lines · 欧阳炜钊(Weizhao Ouyang)
Quoted 2 lines · Ulf Hansson

On Tue, 27 Sept 2022 at 04:04, Weizhao Ouyang

<[email protected]>

Quoted 29 lines
Quoted 15 lines
Quoted 9 lines · wrote:

From: Matthew Ma <[email protected]>

SDIO tuple is only allocated for standard SDIO card, especially it causes memory corruption issues when the non-standard SDIO card has removed since the card device's reference counter does not increase for it at sdio_init_func(), but all SDIO card device reference counter has decreased at sdio_release_func().

Quoted 4 lines
Fixes 1a632f8cdc33 ("sdio: split up common and function CIS parsing")
Quoted 5 lines

Apologize for the delay!

Wow, that's a very old bug you fixed! However, it looks like the fixed commit should be changed to 6f51be3d37df ("sdio: allow non-standard SDIO cards").

Thanks, I messed the tag.

Quoted 5 lines

I tried to apply the patch, but the patch format seems to be corrupt. Did you use git format-patch and did run ./scripts/checkpatch.pl on it?

Quoted 9 lines
Quoted 2 lines

Yeah I used checkpatch.pl with strict mode to check this patch, and it has no obvious style problems. What's the format error you got?

ERROR: patch seems to be corrupt (line wrapped?)
#130: FILE: drivers/mmc/core/sdio_bus.c:291:
struct sdio_func *func = dev_to_sdio_func(dev);

total: 1 errors, 0 warnings, 9 lines checked

Sorry our email hosting service made some issue on formatting, I will send an updated patch ASAP.

Thanks,
Weizhao