Skip to contentSkip to conversation

Enabling i915.fastboot=1 by default

DISCUSSION Hans de Goede 3 participants 7 messages Jun 6, 2018 – Jun 7, 2018

lore
Share & tools
lore
#0 lore raw

Hi All,

So I'm working on making Linux boot in a complete flickerfree manner (no modesets, no black screens).

I have this working on various machines with Intel gfx, but I need to pass i915.fastboot=1 on the kernel commandline.

I know there was some talk about enabling this by default a while ago, but it seems that that still has not happened (yet?).

I'm wondering what is holding this back ? Maybe we can change it from a bool to an int, init it to -1 and when it is -1 have some automatic detection code which disables it where it is known to be troublesome and otherwise enables it by default?

Regards,

Hans

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#1 lore raw

Op 06-06-18 om 11:09 schreef Hans de Goede:

Quoted 13 lines

Hi All,

So I'm working on making Linux boot in a complete flickerfree manner (no modesets, no black screens).

I have this working on various machines with Intel gfx, but I need to pass i915.fastboot=1 on the kernel commandline.

I know there was some talk about enabling this by default a while ago, but it seems that that still has not happened (yet?).

Quoted 5 lines

I'm wondering what is holding this back ? Maybe we can change it from a bool to an int, init it to -1 and when it is -1 have some automatic detection code which disables it where it is known to be troublesome and otherwise enables it by default?

Main reason are bugs like https://bugs.freedesktop.org/show_bug.cgi?id=103781 and our hw readout not being perfect. On some haswell/broadwell eDP laptops we stop generating vblanks when we fastboot, and in general we don't trust our code enough for that.

The automatic detection code is already in place, we modeset if the mode is not compatible enough, but we don't catch all the cases where this might happen.

~Maarten

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

Hi,

Quoted 20 lines · Maarten Lankhorst

Op 06-06-18 om 11:09 schreef Hans de Goede:

Quoted 13 lines

Hi All,

So I'm working on making Linux boot in a complete flickerfree manner (no modesets, no black screens).

I have this working on various machines with Intel gfx, but I need to pass i915.fastboot=1 on the kernel commandline.

I know there was some talk about enabling this by default a while ago, but it seems that that still has not happened (yet?).

Quoted 5 lines

I'm wondering what is holding this back ? Maybe we can change it from a bool to an int, init it to -1 and when it is -1 have some automatic detection code which disables it where it is known to be troublesome and otherwise enables it by default?

Quoted 6 lines

Main reason are bugs like https://bugs.freedesktop.org/show_bug.cgi?id=103781 and our hw readout not being perfect. On some haswell/broadwell eDP laptops we stop generating vblanks when we fastboot, and in general we don't trust our code enough for that.

The automatic detection code is already in place, we modeset if the mode is not compatible enough, but we don't catch all the cases where this might happen.

Right but the "mode is not compatible" check will be always necessary, because e.g. some BIOs-es insist in bringing up the display in 1024x768 instead of its native mode.

What I meant is, something like check which generation we are on (and maybe if a specific type of output is used or not if that does not convolute the code too much).

E.g. you mention vblank issues with haswell/broadwell eDP, so if i915.fastboot=-1 we would then disable fastboot if we are on a haswell or broadwell and eDP is used.

Or we could simply disable it on all haswell/broadwell devices when i915.fastboot=-1 used, but maybe enable on skylake and newer?

Regards,

Hans
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

Op 06-06-18 om 11:54 schreef Hans de Goede:

Quoted 27 lines

Hi,

Quoted 24 lines · Maarten Lankhorst

Op 06-06-18 om 11:09 schreef Hans de Goede:

Quoted 13 lines

Hi All,

So I'm working on making Linux boot in a complete flickerfree manner (no modesets, no black screens).

I have this working on various machines with Intel gfx, but I need to pass i915.fastboot=1 on the kernel commandline.

I know there was some talk about enabling this by default a while ago, but it seems that that still has not happened (yet?).

Quoted 5 lines

I'm wondering what is holding this back ? Maybe we can change it from a bool to an int, init it to -1 and when it is -1 have some automatic detection code which disables it where it is known to be troublesome and otherwise enables it by default?

Main reason are bugs like https://bugs.freedesktop.org/show_bug.cgi?id=103781 and our hw readout not being perfect. On some haswell/broadwell eDP laptops we stop generating vblanks when we fastboot, and in general we don't trust our code enough for that.

Quoted 6 lines
Quoted 2 lines

The automatic detection code is already in place, we modeset if the mode is not compatible enough, but we don't catch all the cases where this might happen.

Right but the "mode is not compatible" check will be always necessary, because e.g. some BIOs-es insist in bringing up the display in 1024x768 instead of its native mode.

It's not just the mode we're checking, any parameter in intel_pipe_config_compare is checked and adjusted. This code is also run after each modeset. If the panel fitter is used we don't need to modeset from 1024x768, we will just disable the panel fitter.

Quoted 7 lines

What I meant is, something like check which generation we are on (and maybe if a specific type of output is used or not if that does not convolute the code too much).

E.g. you mention vblank issues with haswell/broadwell eDP, so if i915.fastboot=-1 we would then disable fastboot if we are on a haswell or broadwell and eDP is used.

I think we shouldn't put any code in adding workarounds or detection, but fix those bugs and then retry enabling things.

Quoted 3 lines

Or we could simply disable it on all haswell/broadwell devices when i915.fastboot=-1 used, but maybe enable on skylake and newer?

First step is making sure we use the code for everything except the initial modeset, already had a patch for that, but it needs some fixing since new warnings pop up..

https://patchwork.freedesktop.org/series/43248/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

Hi,

Quoted 43 lines · Maarten Lankhorst

Op 06-06-18 om 11:54 schreef Hans de Goede:

Quoted 27 lines

Hi,

Quoted 24 lines · Maarten Lankhorst

Op 06-06-18 om 11:09 schreef Hans de Goede:

Quoted 13 lines

Hi All,

So I'm working on making Linux boot in a complete flickerfree manner (no modesets, no black screens).

I have this working on various machines with Intel gfx, but I need to pass i915.fastboot=1 on the kernel commandline.

I know there was some talk about enabling this by default a while ago, but it seems that that still has not happened (yet?).

Quoted 5 lines

I'm wondering what is holding this back ? Maybe we can change it from a bool to an int, init it to -1 and when it is -1 have some automatic detection code which disables it where it is known to be troublesome and otherwise enables it by default?

Main reason are bugs like https://bugs.freedesktop.org/show_bug.cgi?id=103781 and our hw readout not being perfect. On some haswell/broadwell eDP laptops we stop generating vblanks when we fastboot, and in general we don't trust our code enough for that.

Quoted 6 lines
Quoted 2 lines

The automatic detection code is already in place, we modeset if the mode is not compatible enough, but we don't catch all the cases where this might happen.

Right but the "mode is not compatible" check will be always necessary, because e.g. some BIOs-es insist in bringing up the display in 1024x768 instead of its native mode.

It's not just the mode we're checking, any parameter in intel_pipe_config_compare is checked and adjusted. This code is also run after each modeset. If the panel fitter is used we don't need to modeset from 1024x768, we will just disable the panel fitter.

Quoted 4 lines

What I meant is, something like check which generation we are on (and maybe if a specific type of output is used or not if that does not convolute the code too much).

Quoted 6 lines
Quoted 3 lines

E.g. you mention vblank issues with haswell/broadwell eDP, so if i915.fastboot=-1 we would then disable fastboot if we are on a haswell or broadwell and eDP is used.

I think we shouldn't put any code in adding workarounds or detection, but fix those bugs and then retry enabling things.

But enabling it for all generations at once feels to me like we will never end up enabling it because of an issue on some generations only. There are plenty of other cases where features are enabled by default on a generation by generation basis. I agree that ideally we end up enabling this everywhere, but enabling it by default everywhere at once feel like you are aiming a bit too high.

Quoted 7 lines
Quoted 3 lines

Or we could simply disable it on all haswell/broadwell devices when i915.fastboot=-1 used, but maybe enable on skylake and newer?

First step is making sure we use the code for everything except the initial modeset, already had a patch for that, but it needs some fixing since new warnings pop up..

https://patchwork.freedesktop.org/series/43248/

That sounds like a good first step, I'm afraid I don't have time to look into the test failures myself. If you have some time to take a second look at this that would be great.

Regards,

Hans
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
Quoted 53 lines · Hans de Goede

Hi,

Quoted 43 lines · Maarten Lankhorst

Op 06-06-18 om 11:54 schreef Hans de Goede:

Quoted 27 lines

Hi,

Quoted 24 lines · Maarten Lankhorst

Op 06-06-18 om 11:09 schreef Hans de Goede:

Quoted 13 lines

Hi All,

So I'm working on making Linux boot in a complete flickerfree manner (no modesets, no black screens).

I have this working on various machines with Intel gfx, but I need to pass i915.fastboot=1 on the kernel commandline.

I know there was some talk about enabling this by default a while ago, but it seems that that still has not happened (yet?).

Quoted 5 lines

I'm wondering what is holding this back ? Maybe we can change it from a bool to an int, init it to -1 and when it is -1 have some automatic detection code which disables it where it is known to be troublesome and otherwise enables it by default?

Main reason are bugs like https://bugs.freedesktop.org/show_bug.cgi?id=103781 and our hw readout not being perfect. On some haswell/broadwell eDP laptops we stop generating vblanks when we fastboot, and in general we don't trust our code enough for that.

Quoted 6 lines
Quoted 2 lines

The automatic detection code is already in place, we modeset if the mode is not compatible enough, but we don't catch all the cases where this might happen.

Right but the "mode is not compatible" check will be always necessary, because e.g. some BIOs-es insist in bringing up the display in 1024x768 instead of its native mode.

It's not just the mode we're checking, any parameter in intel_pipe_config_compare is checked and adjusted. This code is also run after each modeset. If the panel fitter is used we don't need to modeset from 1024x768, we will just disable the panel fitter.

Quoted 4 lines

What I meant is, something like check which generation we are on (and maybe if a specific type of output is used or not if that does not convolute the code too much).

Quoted 6 lines
Quoted 3 lines

E.g. you mention vblank issues with haswell/broadwell eDP, so if i915.fastboot=-1 we would then disable fastboot if we are on a haswell or broadwell and eDP is used.

I think we shouldn't put any code in adding workarounds or detection, but fix those bugs and then retry enabling things.

Quoted 7 lines

But enabling it for all generations at once feels to me like we will never end up enabling it because of an issue on some generations only. There are plenty of other cases where features are enabled by default on a generation by generation basis. I agree that ideally we end up enabling this everywhere, but enabling it by default everywhere at once feel like you are aiming a bit too high.

I agree with Hans on this point. It is not a matter of workaround or detection, but a matter of bandwidth to deal with validation and incoming bugs, specially when the behaviour changes for different gens.

On the PSR front, for instance, we are focused on enabling first on SKL and expand that for other platforms.

Quoted 13 lines
Quoted 8 lines
Quoted 4 lines

Or we could simply disable it on all haswell/broadwell devices when i915.fastboot=-1 used, but maybe enable on skylake and newer?

First step is making sure we use the code for everything except the initial modeset, already had a patch for that, but it needs some fixing since new warnings pop up..

https://patchwork.freedesktop.org/series/43248/

That sounds like a good first step, I'm afraid I don't have time to look into the test failures myself. If you have some time to take a second look at this that would be great.

Quoted 7 lines

Regards,

Hans
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

Hi,

Quoted 62 lines · Rodrigo Vivi
Quoted 53 lines · Hans de Goede

Hi,

Quoted 43 lines · Maarten Lankhorst

Op 06-06-18 om 11:54 schreef Hans de Goede:

Quoted 27 lines

Hi,

Quoted 24 lines · Maarten Lankhorst

Op 06-06-18 om 11:09 schreef Hans de Goede:

Quoted 13 lines

Hi All,

So I'm working on making Linux boot in a complete flickerfree manner (no modesets, no black screens).

I have this working on various machines with Intel gfx, but I need to pass i915.fastboot=1 on the kernel commandline.

I know there was some talk about enabling this by default a while ago, but it seems that that still has not happened (yet?).

Quoted 5 lines

I'm wondering what is holding this back ? Maybe we can change it from a bool to an int, init it to -1 and when it is -1 have some automatic detection code which disables it where it is known to be troublesome and otherwise enables it by default?

Main reason are bugs like https://bugs.freedesktop.org/show_bug.cgi?id=103781 and our hw readout not being perfect. On some haswell/broadwell eDP laptops we stop generating vblanks when we fastboot, and in general we don't trust our code enough for that.

Quoted 6 lines
Quoted 2 lines

The automatic detection code is already in place, we modeset if the mode is not compatible enough, but we don't catch all the cases where this might happen.

Right but the "mode is not compatible" check will be always necessary, because e.g. some BIOs-es insist in bringing up the display in 1024x768 instead of its native mode.

It's not just the mode we're checking, any parameter in intel_pipe_config_compare is checked and adjusted. This code is also run after each modeset. If the panel fitter is used we don't need to modeset from 1024x768, we will just disable the panel fitter.

Quoted 4 lines

What I meant is, something like check which generation we are on (and maybe if a specific type of output is used or not if that does not convolute the code too much).

Quoted 6 lines
Quoted 3 lines

E.g. you mention vblank issues with haswell/broadwell eDP, so if i915.fastboot=-1 we would then disable fastboot if we are on a haswell or broadwell and eDP is used.

I think we shouldn't put any code in adding workarounds or detection, but fix those bugs and then retry enabling things.

Quoted 7 lines

But enabling it for all generations at once feels to me like we will never end up enabling it because of an issue on some generations only. There are plenty of other cases where features are enabled by default on a generation by generation basis. I agree that ideally we end up enabling this everywhere, but enabling it by default everywhere at once feel like you are aiming a bit too high.

Quoted 4 lines

I agree with Hans on this point. It is not a matter of workaround or detection, but a matter of bandwidth to deal with validation and incoming bugs, specially when the behaviour changes for different gens.

Ok, so perhaps we can try to enable this now on some hardware? Say skylake+ and byt + cht + apollo-lake ?

Regards,

Hans
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx