Skip to contentSkip to conversation

New version of ClownToolKit

DISCUSSION Bodo Eggert 4 participants 4 messages Aug 16, 2006 – Aug 17, 2006 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 11 lines · Sam Ravnborg

A small nitpick about the way ou build the ekrnel module:

In mk_and_insmod you can replace:
make -C /usr/src/linux SUBDIRS=$PWD modules
with
LIBDIR=/lib/modules/uname -r
make -C $LIBDIR/source O=$LIBDIR/build SUBDIRS=pwd modules

For a normal kernel installation this will do the right thing. source points to the kernel source and build point to the output directory (they are often equal but not always).

Please don't tell module authors to unconditionally use uname -r. I frequently build kernels for differentd hosts, and if I don't, I'll certainly compile the needed modules before installing the kernel. Therefore /lib/modules/uname -r is most certainly the completely wrong place to look for the kernel source.

Signature · 4 lines
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF
verbreiteten Lügen zu sabotieren.

http://david.woodhou.se/why-not-spf.html
#3 lore raw
Quoted 14 lines · Bodo Eggert
Quoted 11 lines · Sam Ravnborg

A small nitpick about the way ou build the ekrnel module:

In mk_and_insmod you can replace:
make -C /usr/src/linux SUBDIRS=$PWD modules
with
LIBDIR=/lib/modules/uname -r
make -C $LIBDIR/source O=$LIBDIR/build SUBDIRS=pwd modules

For a normal kernel installation this will do the right thing. source points to the kernel source and build point to the output directory (they are often equal but not always).

Quoted 5 lines

Please don't tell module authors to unconditionally use uname -r. I frequently build kernels for differentd hosts, and if I don't, I'll certainly compile the needed modules before installing the kernel. Therefore /lib/modules/uname -r is most certainly the completely wrong place to look for the kernel source.

/lib/modules/uname -r is the general solution that works for most people and should be at least default. It is certainly better than /usr/src/linux.
But yes they better make it override able.

Sam

#4 lore raw
Quoted 13 lines
Quoted 7 lines
Quoted 6 lines

LIBDIR=/lib/modules/uname -r
make -C $LIBDIR/source O=$LIBDIR/build SUBDIRS=pwd modules

For a normal kernel installation this will do the right thing. source points to the kernel source and build point to the output directory (they are often equal but not always).

Quoted 5 lines

Please don't tell module authors to unconditionally use uname -r. I frequently build kernels for differentd hosts, and if I don't, I'll certainly compile the needed modules before installing the kernel. Therefore /lib/modules/uname -r is most certainly the completely wrong place to look for the kernel source.

Quoted 4 lines

/lib/modules/uname -r is the general solution that works for most people and should be at least default. It is certainly better than /usr/src/linux.
But yes they better make it override able.

In some outoftree modules of mine, the Makefile reads like this

MODULES_DIR := /lib/modules/$(shell uname -r)
KSRC_DIR := ${MODULES_DIR}/source
KOBJ_DIR := ${MODULES_DIR}/build

all: modules
modules:

	make -C "${KOBJ_DIR}" M="$$PWD";

and one can easily override it by calling make MODULES_DIR=/foo/bar (instead of just make).

Jan Engelhardt

#5 lore raw
Quoted 26 lines · Jan Engelhardt
Quoted 13 lines
Quoted 7 lines
Quoted 6 lines

LIBDIR=/lib/modules/uname -r
make -C $LIBDIR/source O=$LIBDIR/build SUBDIRS=pwd modules

For a normal kernel installation this will do the right thing. source points to the kernel source and build point to the output directory (they are often equal but not always).

Quoted 5 lines

Please don't tell module authors to unconditionally use uname -r. I frequently build kernels for differentd hosts, and if I don't, I'll certainly compile the needed modules before installing the kernel. Therefore /lib/modules/uname -r is most certainly the completely wrong place to look for the kernel source.

Quoted 4 lines

/lib/modules/uname -r is the general solution that works for most people and should be at least default. It is certainly better than /usr/src/linux.
But yes they better make it override able.

In some outoftree modules of mine, the Makefile reads like this

MODULES_DIR := /lib/modules/$(shell uname -r)
KSRC_DIR := ${MODULES_DIR}/source
KOBJ_DIR := ${MODULES_DIR}/build

all: modules
modules:

Quoted 7 lines
	make -C "${KOBJ_DIR}" M="$$PWD";

and one can easily override it by calling make MODULES_DIR=/foo/bar (instead of just make).

Jan Engelhardt

Thank you all for all those tips, I will use this last one.

Vincent Perrier