Skip to contentSkip to conversation

THE LINUX/I386 BOOT PROTOCOL - Breaking the 256 limit (ping)

PATCH Bodo Eggert 2 participants 2 messages Aug 31, 2006 4 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 10 lines · Andi Kleen
Quoted 9 lines · H. Peter Anvin
Quoted 6 lines · Alon Bar-Lev

This is not entirely true...
All architectures sets saved_command_line variable... So I can add __init to the saved_command_line and copy its contents into kmalloced persistence_command_line at main.c.

Quoted 7 lines
Quoted 3 lines

My opinion is that you should change saved_command_line (which already implies a copy) to be the kmalloc'd version and call the fixed-sized buffer something else.

It might be safer to rename everything. Then all users could be caught and audited. This would ensure saved_command_line is not accessed before the kmalloc'ed copy exists.

If you set the new *saved_cmdline=saved_cmdline_init, the users don't need to be adjusted at all, and you won't have trouble with code that may be run before or after kmallocking (if it exists).

Signature · 4 lines
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF
verbreiteten Lügen zu sabotieren.

http://david.woodhou.se/why-not-spf.html
#5 lore raw
Quoted 13 lines · Bodo Eggert
Quoted 12 lines · Andi Kleen
Quoted 11 lines · H. Peter Anvin
Quoted 6 lines · Alon Bar-Lev

This is not entirely true...
All architectures sets saved_command_line variable... So I can add __init to the saved_command_line and copy its contents into kmalloced persistence_command_line at main.c.

My opinion is that you should change saved_command_line (which already implies a copy) to be the kmalloc'd version and call the fixed-sized buffer something else.

Quoted 7 lines
Quoted 3 lines

It might be safer to rename everything. Then all users could be caught and audited. This would ensure saved_command_line is not accessed before the kmalloc'ed copy exists.

If you set the new *saved_cmdline=saved_cmdline_init, the users don't need to be adjusted at all, and you won't have trouble with code that may be run before or after kmallocking (if it exists).

True for C code, but not for assembly.

-hpa