pinctrl: airoha: fix led1 gpio11 typo and phy4 duplicated map value
Subsystems (3)
PATCH 1/1 pinctrl: airoha: fix led1 gpio11 typo and phy4 duplicated map value
Two bugs in LED1 configuration:
1. an7583_phy1_led1_func_group uses "gpio1" instead of "gpio11" for
LAN3_LED1, causing wrong GPIO assignment (AN7583 only).
2. phy4_led1_func_group and an7583_phy4_led1_func_group use MAP(2)
duplicated with phy3, should use MAP(3) to match phy4 sequence.
Fixes 1c8ace2d0725 ("pinctrl: airoha: Add support for EN7581 SoC")
Fixes 3ffeb17a9a27 ("pinctrl: airoha: add support for Airoha AN7583 PINs")
Signed-off-by Wayen Yan <[email protected]>
--- drivers/pinctrl/mediatek/pinctrl-airoha.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/pinctrl/mediatek/pinctrl-airoha.c +9 -9
@@ -1618,13 +1618,13 @@ static const struct airoha_pinctrl_func_group phy3_led1_func_group[] = {static const struct airoha_pinctrl_func_group phy4_led1_func_group[] = {AIROHA_PINCTRL_PHY_LED1 ("gpio43" ,GPIO_LAN0_LED1_MODE_MASK , -LAN0_LED_MAPPING_MASK ,LAN0_PHY_LED_MAP (2 )), +LAN0_LED_MAPPING_MASK ,LAN0_PHY_LED_MAP (3 )),AIROHA_PINCTRL_PHY_LED1 ("gpio44" ,GPIO_LAN1_LED1_MODE_MASK , -LAN1_LED_MAPPING_MASK ,LAN1_PHY_LED_MAP (2 )), +LAN1_LED_MAPPING_MASK ,LAN1_PHY_LED_MAP (3 )),AIROHA_PINCTRL_PHY_LED1 ("gpio45" ,GPIO_LAN2_LED1_MODE_MASK , -LAN2_LED_MAPPING_MASK ,LAN2_PHY_LED_MAP (2 )), +LAN2_LED_MAPPING_MASK ,LAN2_PHY_LED_MAP (3 )),AIROHA_PINCTRL_PHY_LED1 ("gpio46" ,GPIO_LAN3_LED1_MODE_MASK , -LAN3_LED_MAPPING_MASK ,LAN3_PHY_LED_MAP (2 )), +LAN3_LED_MAPPING_MASK ,LAN3_PHY_LED_MAP (3 )), };static const struct airoha_pinctrl_func_group an7583_phy1_led0_func_group[] = {
@@ -1678,7 +1678,7 @@ static const struct airoha_pinctrl_func_group an7583_phy1_led1_func_group[] = { LAN1_LED_MAPPING_MASK, LAN1_PHY_LED_MAP(0)), AIROHA_PINCTRL_PHY_LED1("gpio10", GPIO_LAN2_LED1_MODE_MASK, LAN2_LED_MAPPING_MASK, LAN2_PHY_LED_MAP(0)), - AIROHA_PINCTRL_PHY_LED1("gpio1", GPIO_LAN3_LED1_MODE_MASK, + AIROHA_PINCTRL_PHY_LED1("gpio11", GPIO_LAN3_LED1_MODE_MASK, LAN3_LED_MAPPING_MASK, LAN3_PHY_LED_MAP(0)), };
@@ -1706,13 +1706,13 @@ static const struct airoha_pinctrl_func_group an7583_phy3_led1_func_group[] = {static const struct airoha_pinctrl_func_group an7583_phy4_led1_func_group[] = {AIROHA_PINCTRL_PHY_LED1 ("gpio8" ,GPIO_LAN0_LED1_MODE_MASK , -LAN0_LED_MAPPING_MASK ,LAN0_PHY_LED_MAP (2 )), +LAN0_LED_MAPPING_MASK ,LAN0_PHY_LED_MAP (3 )),AIROHA_PINCTRL_PHY_LED1 ("gpio9" ,GPIO_LAN1_LED1_MODE_MASK , -LAN1_LED_MAPPING_MASK ,LAN1_PHY_LED_MAP (2 )), +LAN1_LED_MAPPING_MASK ,LAN1_PHY_LED_MAP (3 )),AIROHA_PINCTRL_PHY_LED1 ("gpio10" ,GPIO_LAN2_LED1_MODE_MASK , -LAN2_LED_MAPPING_MASK ,LAN2_PHY_LED_MAP (2 )), +LAN2_LED_MAPPING_MASK ,LAN2_PHY_LED_MAP (3 )),AIROHA_PINCTRL_PHY_LED1 ("gpio11" ,GPIO_LAN3_LED1_MODE_MASK , -LAN3_LED_MAPPING_MASK ,LAN3_PHY_LED_MAP (2 )), +LAN3_LED_MAPPING_MASK ,LAN3_PHY_LED_MAP (3 )), };static const struct airoha_pinctrl_func en7581_pinctrl_funcs[] = {
Signature · 1 line
2.51.0