rtc-coh901331: Fix braces in resume code.
PATCH 1/1 rtc-coh901331: Fix braces in resume code.
The else part of the if statement is indented but does not have braces around it. It clearly should since it uses clk_enable and clk_disable which are supposed to balance.
Signed-off-by James Hogan <[email protected]>
--- drivers/rtc/rtc-coh901331.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
drivers/rtc/rtc-coh901331.c +3 -2
@@ -271,12 +271,13 @@ static int coh901331_resume(struct platform_device *pdev) {struct coh901331_port *rtap =dev_get_drvdata (&pdev->dev); -if (device_may_wakeup (&pdev->dev)) +if (device_may_wakeup (&pdev->dev)) {disable_irq_wake (rtap->irq); -else + }else {clk_enable (rtap->clk);writel (rtap->irqmaskstore, rtap->virtbase +COH901331_IRQ_MASK );clk_disable (rtap->clk); + }return 0 ; }#else
Signature · 1 line
1.5.5.6
[James]
Quoted 5 lines
The else part of the if statement is indented but does not have braces around it. It clearly should since it uses
clk_enableandclk_disablewhich are supposed to balance.Signed-off-by James Hogan <[email protected]>
OMG, thanks for spotting this!
Acked-by Linus Walleij <[email protected]>
Yours,
Linus Walleij
Quoted 5 lines · On Wed, 3 Mar 2010 11:55:15 +0000 James Hogan <[email protected]> wrote:
The else part of the if statement is indented but does not have braces around it. It clearly should since it uses
clk_enableandclk_disablewhich are supposed to balance.Signed-off-by James Hogan <[email protected]>
Acked-by Alessandro Zummo <[email protected]>
Signature · 6 lines
Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it