Skip to contentSkip to conversation

staging: fbtft: fix checkpatch errors in fbtft-bus.c

PATCH In review Shivesh 3 participants 3 messages Jul 18 – Jul 19

Subsystems (3)
lore
Share & tools
lore

Shivesh

author
#0 lore raw

PATCH 1/1 staging: fbtft: fix checkpatch errors in fbtft-bus.c

From 7e9684b26176644bc92c2285acc7444f3f7ddb4d Mon Sep 17 00:00:00 2001
From: Shivesh <[email protected]>
Date: Sat, 18 Jul 2026 18:08:04 +0000
Subject: [PATCH] staging: fbtft: fix checkpatch errors in fbtft-bus.c

Fix space-related checkpatch errors in macro invocations. When the modifier argument is empty, remove the trailing comma to avoid 'space required after comma' and 'space prohibited before close parenthesis' conflicting errors.

---
 drivers/staging/fbtft/fbtft-bus.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fbtft-bus.c +2 -2
index 30e436ff19e4..409770891c54 100644
@@ -62,9 +62,9 @@ out:									      \
 }                                                                             \
 EXPORT_SYMBOL(func);
 
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
 define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
 
 void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
 {
Signature · 1 line
2.53.0

From 7e9684b26176644bc92c2285acc7444f3f7ddb4d Mon Sep 17 00:00:00 2001
From: Shivesh <[email protected]>
Date: Sat, 18 Jul 2026 18:08:04 +0000
Subject: [PATCH] staging: fbtft: fix checkpatch errors in fbtft-bus.c

Fix space-related checkpatch errors in macro invocations. When the modifier argument is empty, remove the trailing comma to avoid 'space required after comma' and 'space prohibited before close parenthesis' conflicting errors.

---
 drivers/staging/fbtft/fbtft-bus.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fbtft-bus.c +2 -2
index 30e436ff19e4..409770891c54 100644
@@ -62,9 +62,9 @@ out:									      \
 }                                                                             \
 EXPORT_SYMBOL(func);
 
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
 define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
 
 void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
 {
Signature · 1 line
2.53.0
#1 lore raw
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Removing the trailing comma from the `define_fbtft_write_reg` macro invocations reduces the number…

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Removing the trailing comma from the define_fbtft_write_reg macro invocations reduces the number of arguments passed from 4 to 3. Since the macro is defined with exactly 4 parameters, this will cause a C preprocessor build failure. --

--- Patch [1]: [PATCH] staging: fbtft: fix checkpatch errors in fbtft-bus.c --- commit 282c7bb2732808bae2a5a39160285600d23aa964
Author: Shivesh <[email protected]>

staging: fbtft: fix checkpatch errors in fbtft-bus.c

This commit attempts to fix space-related checkpatch errors in fbtft-bus.c. It does this by removing the trailing comma from macro invocations when the modifier argument is empty.

drivers/staging/fbtft/fbtft-bus.c out: \ · line 65

Quoted 8 lines
drivers/staging/fbtft/fbtft-bus.c +1 -1
@@ -62,9 +62,9 @@ out:									      \
 }                                                                             \
 EXPORT_SYMBOL(func);
 
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)

[Severity: Low]
Does removing the trailing comma here cause a build failure?

The define_fbtft_write_reg macro is defined earlier in the file to mandate exactly 4 parameters:

#define define_fbtft_write_reg(func, buffer_type, data_type, modifier)

By removing the comma, the invocation for 8-bit bus writes only provides 3 arguments instead of 4, which will cause a C preprocessor error.

drivers/staging/fbtft/fbtft-bus.c out: \ · line 67

Quoted 3 lines
drivers/staging/fbtft/fbtft-bus.c +1 -1
 define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)

[Severity: Low]
Similarly, will this invocation fail to compile since it also drops the argument count to 3 instead of the required 4?

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
#2 lore raw
In reply to Shivesh
Quoted 10 lines · Shivesh

From 7e9684b26176644bc92c2285acc7444f3f7ddb4d Mon Sep 17 00:00:00 2001
From: Shivesh <[email protected]>
Date: Sat, 18 Jul 2026 18:08:04 +0000
Subject: [PATCH] staging: fbtft: fix checkpatch errors in fbtft-bus.c

Fix space-related checkpatch errors in macro invocations. When the modifier argument is empty, remove the trailing comma to avoid 'space required after comma' and 'space prohibited before close parenthesis' conflicting errors.

Format of the sending the patch is wrong, and you even haven't compiled the code. NAK.

Signature · 2 lines
With Best Regards,
Andy Shevchenko