ntfs: validate usa_ofs before preserving the update sequence number
Subsystems (2)
PATCH v2 1/1 ntfs: validate usa_ofs before preserving the update sequence number
When ntfs_mft_record_alloc() reuses a free mft record it reads the old update sequence number straight from the on-disk record:
usn = *(__le16 *)((u8 *)m + le16_to_cpu(m->usa_ofs));
Here m points into the raw $MFT page-cache folio, which still holds unvalidated, MST-protected bytes: the folio is read by a plain iomap_read_folio() and neither post_read_mst_fixup() nor ntfs_mft_record_check() has run on it (both work on private copies). m->usa_ofs is therefore an untrusted u16, and a corrupted record can put it past the end of the record so the two-byte read lands outside the folio. Reading such a record while creating a file gives, under KASAN:
BUG: KASAN: use-after-free in ntfs_mft_record_alloc+... Read of size 2 at addr ... ntfs_mft_record_alloc -> __ntfs_create -> ntfs_create -> path_openat
Only preserve the old update sequence number when usa_ofs is even and in range, mirroring the check ntfs_mft_record_check() already applies; otherwise leave usn zero, which the existing restore below skips.
---
For v2:
- drop the explanatory comment above the check (per review).
- fix blankspace issues
fs/ntfs/mft.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
fs/ntfs/mft.c +5 -1
@@ -2333,7 +2333,11 @@ int ntfs_mft_record_alloc(struct ntfs_volume *vol, const int mode,* wrong with the previous mft record. */ seq_no = m->sequence_number; - usn = *(__le16 *)((u8 *)m +le16_to_cpu (m->usa_ofs)); +if (!(le16_to_cpu (m->usa_ofs) &1 ) && +le16_to_cpu (m->usa_ofs) +sizeof (usn) <= vol->mft_record_size) + usn = *(__le16 *)((u8 *)m +le16_to_cpu (m->usa_ofs)); +else + usn =0 ; err =ntfs_mft_record_layout (vol, bit, m);if (unlikely (err)) { ntfs_error(vol->sb, "Failed to layout allocated mft record 0x%llx.",
Signature · 1 line
2.47.3
2026년 8월 20일 (목) 오후 3:42, Dennis Tighe <[email protected]>님이 작성:
Quoted 18 lines
When
ntfs_mft_record_alloc()reuses a free mft record it reads the old update sequence number straight from the on-disk record:usn = *(__le16 *)((u8 *)m + le16_to_cpu(m->usa_ofs));Here m points into the raw $MFT page-cache folio, which still holds unvalidated, MST-protected bytes: the folio is read by a plain
iomap_read_folio()and neitherpost_read_mst_fixup()norntfs_mft_record_check()has run on it (both work on private copies).m->usa_ofsis therefore an untrusted u16, and a corrupted record can put it past the end of the record so the two-byte read lands outside the folio. Reading such a record while creating a file gives, under KASAN:BUG: KASAN: use-after-free in ntfs_mft_record_alloc+... Read of size 2 at addr ... ntfs_mft_record_alloc -> __ntfs_create -> ntfs_create -> path_openat
Quoted 7 lines
Only preserve the old update sequence number when
usa_ofsis even and in range, mirroring the checkntfs_mft_record_check()already applies; otherwise leave usn zero, which the existing restore below skips.Fixes 495e90fa3348 ("ntfs: update attrib operations")Assisted-by Claude:claude-opus-4-8Signed-off-by Dennis Tighe <[email protected]>
Looks good to me.
Signature · 2 lines
Thanks, Hyunchul
Quoted 18 lines · Dennis Tighe
When
ntfs_mft_record_alloc()reuses a free mft record it reads the old update sequence number straight from the on-disk record:usn = *(__le16 *)((u8 *)m + le16_to_cpu(m->usa_ofs));Here m points into the raw $MFT page-cache folio, which still holds unvalidated, MST-protected bytes: the folio is read by a plain
iomap_read_folio()and neitherpost_read_mst_fixup()norntfs_mft_record_check()has run on it (both work on private copies).m->usa_ofsis therefore an untrusted u16, and a corrupted record can put it past the end of the record so the two-byte read lands outside the folio. Reading such a record while creating a file gives, under KASAN:BUG: KASAN: use-after-free in ntfs_mft_record_alloc+... Read of size 2 at addr ... ntfs_mft_record_alloc -> __ntfs_create -> ntfs_create -> path_openat
Quoted 7 lines
Only preserve the old update sequence number when
usa_ofsis even and in range, mirroring the checkntfs_mft_record_check()already applies; otherwise leave usn zero, which the existing restore below skips.Fixes 495e90fa3348 ("ntfs: update attrib operations")Assisted-by Claude:claude-opus-4-8Signed-off-by Dennis Tighe <[email protected]>
Applied it to #ntfs-next.
Thanks!