ntfs: do not mark the volume clean in sync_fs when errors were recorded
PATCH 1/1 ntfs: do not mark the volume clean in sync_fs when errors were recorded
ntfs_put_super() and the remount-read-only path both clear the dirty bit only when NVolErrors(vol) is false. ntfs_sync_fs() clears it unconditionally, so any sync() on a volume that recorded an error marks that volume clean. A volume without this set is then seen as not needing recovery and it does not run one, so whatever went wrong is never repaired.
This change skips resetting the dirty bit when there are volume errors.
Reproduced on a volume whose $MFTMirr does not match $MFT, which sets the error flag while leaving the mount read-write: after a write and a sync, the on-disk volume flags read 0x0000 with this driver and 0x0001 with the guard in place.
--- fs/ntfs/super.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/ntfs/super.c +2 -1
@@ -1862,7 +1862,8 @@ static int ntfs_sync_fs(struct super_block *sb, int wait)return 0 ;/* If there are some dirty buffers in the bdev inode */ -if (ntfs_clear_volume_flags (vol,VOLUME_IS_DIRTY )) { +if (!NVolErrors (vol) && +ntfs_clear_volume_flags (vol,VOLUME_IS_DIRTY )) {ntfs_warning (sb,"Failed to clear dirty bit in volume information flags. Run chkdsk." ); err = -EIO ; }
Signature · 1 line
2.43.0
2026년 8월 24일 (월) 오후 2:08, Dennis Tighe <[email protected]>님이 작성:
Quoted 9 lines
ntfs_put_super()and the remount-read-only path both clear the dirty bit only when NVolErrors(vol) is false.ntfs_sync_fs()clears it unconditionally, so anysync()on a volume that recorded an error marks that volume clean. A volume without this set is then seen as not needing recovery and it does not run one, so whatever went wrong is never repaired.This change skips resetting the dirty bit when there are volume errors.
Quoted 8 lines
Reproduced on a volume whose $MFTMirr does not match $MFT, which sets the error flag while leaving the mount read-write: after a write and a sync, the on-disk volume flags read
0x0000with this driver and0x0001with the guard in place.Fixes 6251f0b0de7d ("ntfs: update super block operations")Assisted-by claude:claude-opus-5Signed-off-by Dennis Tighe <[email protected]>
Looks good to me.
Quoted 21 lines
--- fs/ntfs/super.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)fs/ntfs/super.c +2
-2@@ -1862,7 +1862,8 @@ static int ntfs_sync_fs(struct super_block *sb, int wait)return 0 ;/* If there are some dirty buffers in the bdev inode */ -if (ntfs_clear_volume_flags (vol,VOLUME_IS_DIRTY )) { +if (!NVolErrors (vol) && +ntfs_clear_volume_flags (vol,VOLUME_IS_DIRTY )) {ntfs_warning (sb,"Failed to clear dirty bit in volume information flags. Run chkdsk." ); err = -EIO ; } --2.43.0
Signature · 2 lines
Thanks, Hyunchul
Quoted 9 lines · Dennis Tighe
ntfs_put_super()and the remount-read-only path both clear the dirty bit only when NVolErrors(vol) is false.ntfs_sync_fs()clears it unconditionally, so anysync()on a volume that recorded an error marks that volume clean. A volume without this set is then seen as not needing recovery and it does not run one, so whatever went wrong is never repaired.This change skips resetting the dirty bit when there are volume errors.
Quoted 8 lines
Reproduced on a volume whose $MFTMirr does not match $MFT, which sets the error flag while leaving the mount read-write: after a write and a sync, the on-disk volume flags read
0x0000with this driver and0x0001with the guard in place.Fixes 6251f0b0de7d ("ntfs: update super block operations")Assisted-by claude:claude-opus-5Signed-off-by Dennis Tighe <[email protected]>
Applied it to #ntfs-next.
Thanks!