New item at list end for backwards compatibility
From: Robert Berger <[email protected]>
I received this off-list from Robert, it's a bugfix to mkimage, where the IH_TYPE_ enumeration changed recently and broke backward mkimage backward compatibility.
Peng, can you respin the patch, test it and repost it ? Thanks
---
include/image.h +0 -1
@@ -251,7 +251,6 @@ enum {IH_TYPE_FLATDT ,/* Binary Flat Device Tree Blob */ IH_TYPE_KWBIMAGE ,/* Kirkwood Boot Image */ IH_TYPE_IMXIMAGE ,/* Freescale IMXBoot Image */ -IH_TYPE_IMX8IMAGE ,/* Freescale IMX8Boot Image */ IH_TYPE_UBLIMAGE ,/* Davinci UBL Image */ IH_TYPE_OMAPIMAGE ,/* TI OMAP Config Header Image */ IH_TYPE_AISIMAGE, /* TI Davinci AIS Image */
@@ -278,6 +277,7 @@ enum { IH_TYPE_PMMC, /* TI Power Management Micro-Controller
Firmware */
IH_TYPE_STM32IMAGE, /* STMicroelectronics STM32 Image */
IH_TYPE_SOCFPGAIMAGE_V1, /* Altera SOCFPGA A10 Preloader */
+ IH_TYPE_IMX8IMAGE, /* Freescale IMX8Boot Image */ IH_TYPE_COUNT, /* Number of image types */
};
Signature · 2 lines
Best regards, Marek Vasut
Hi Marek, Robert,
Quoted 8 lines · Marek Vasut
From: Robert Berger <[email protected]>
Signed-off-by Robert Berger <[email protected]>I received this off-list from Robert, it's a bugfix to mkimage, where the
IH_TYPE_enumeration changed recently and broke backward mkimage backward compatibility.
That's true - new image type must be always appended for compatible reason.
Quoted 1 line
Peng, can you respin the patch, test it and repost it ? Thanks
I am reviewing and applying Peng's - but Peng posted a patch for i.MX8M, patch for i.MX8 was already applied.
If nobody complains, I fix this myself by applying Peng's i.MX8M (not MX8) patch, I mean this one:
http://patchwork.ozlabs.org/patch/1000376/
Note: this also breaks compatibility
Regards,
Stefano
Quoted 24 lines
---
include/image.h +0
-1@@ -251,7 +251,6 @@ enum {IH_TYPE_FLATDT ,/* Binary Flat Device Tree Blob */ IH_TYPE_KWBIMAGE ,/* Kirkwood Boot Image */ IH_TYPE_IMXIMAGE ,/* Freescale IMXBoot Image */ -IH_TYPE_IMX8IMAGE ,/* Freescale IMX8Boot Image */ IH_TYPE_UBLIMAGE ,/* Davinci UBL Image */ IH_TYPE_OMAPIMAGE ,/* TI OMAP Config Header Image */ IH_TYPE_AISIMAGE, /* TI Davinci AIS Image */@@ -278,6 +277,7 @@ enum { IH_TYPE_PMMC, /* TI Power Management Micro-ControllerFirmware */
IH_TYPE_STM32IMAGE, /* STMicroelectronics STM32 Image */ IH_TYPE_SOCFPGAIMAGE_V1, /* Altera SOCFPGA A10 Preloader */ + IH_TYPE_IMX8IMAGE, /* Freescale IMX8Boot Image */
IH_TYPE_COUNT, /* Number of image types */
};
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
Quoted 19 lines · Stefano Babic
Hi Marek, Robert,
Quoted 8 lines · Marek Vasut
From: Robert Berger <[email protected]>
Signed-off-by Robert Berger <[email protected]>I received this off-list from Robert, it's a bugfix to mkimage, where the
IH_TYPE_enumeration changed recently and broke backward mkimage backward compatibility.That's true - new image type must be always appended for compatible reason.
Quoted 1 line
Peng, can you respin the patch, test it and repost it ? Thanks
I am reviewing and applying Peng's - but Peng posted a patch for i.MX8M, patch for i.MX8 was already applied.
Quoted 6 lines
If nobody complains, I fix this myself by applying Peng's i.MX8M (not MX8) patch, I mean this one:
http://patchwork.ozlabs.org/patch/1000376/Note: this also breaks compatibility
I think the first problem is that the comment "Do not change values for backward compatibility." is not clear enough because I see lots of middle of the list insertions which in turn change all of the values that follow. A downside of an enum I suppose. What we need to do is yank the IMX8 part out to fix all of the broken images, and put the new ones at the back, and Cc the various distro folks as they'll want to make sure to pick this fix up.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181208/49ab75a3/attachment.sig>
Hi Tom,
Quoted 23 lines · Tom Rini
Quoted 22 lines · Stefano Babic
Hi Marek, Robert,
Quoted 8 lines · Marek Vasut
From: Robert Berger <[email protected]>
Signed-off-by Robert Berger <[email protected]>I received this off-list from Robert, it's a bugfix to mkimage, where the
IH_TYPE_enumeration changed recently and broke backward mkimage backward compatibility.That's true - new image type must be always appended for compatible reason.
Quoted 1 line
Peng, can you respin the patch, test it and repost it ? Thanks
I am reviewing and applying Peng's - but Peng posted a patch for i.MX8M, patch for i.MX8 was already applied.
If nobody complains, I fix this myself by applying Peng's i.MX8M (not MX8) patch, I mean this one:
Quoted 8 lines
Quoted 3 lines
http://patchwork.ozlabs.org/patch/1000376/Note: this also breaks compatibility
I think the first problem is that the comment "Do not change values for backward compatibility." is not clear enough because I see lots of middle of the list insertions which in turn change all of the values that follow. A downside of an enum I suppose.
Yes, I remember I caused this issue myself some years ago when I added an image for TI. The comment is weak, maybe this is one of the rare cases where a strict list of #define with values could be better.
Quoted 3 lines
What we need to do is
yank the IMX8 part out to fix all of the broken images, and put the new ones at the back,
Right
Quoted 3 lines
and Cc the various distro folks as they'll want to make sure to pick this fix up.
Best regards,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================