Skip to contentSkip to conversation

Question for upstream

DISCUSSION Payne Yang 3 participants 5 messages Sep 25, 2019

lore
Share & tools
lore

Payne Yang

author
#0 lore raw

Hi Team,

I reference package dbus-sensors to implement feature for FPGA monitor. Which way is correct for upstream ??

1. Use patch file and add bbappend on dbus-sensors

2. Create oem folder in my meta-XXX/recipes-phosphor/XXX-sensors including some common header from dbus-sensors (eg. Utils.cpp & Utils.hpp)

3. Create Pull Request on dbus-sensors for my implementation

Best Regards,
Payne

#1 lore raw

Create a gerrit review on dbus-sensors with your implementation.

author
#2 lore raw

Hi Tanous,

Got it.
By the way, I have to include a specific fpga library in this implementation. Should I update it also ?

Quoted 8 lines

-----Original Message-----
From: Tanous, Ed <[email protected]>
Sent: Wednesday, September 25, 2019 11:39 AM
To: Payne Yang <[email protected]>
Cc: [email protected]
Subject: [External] Re: Question for upstream

Create a gerrit review on dbus-sensors with your implementation.

#3 lore raw
Quoted 5 lines · Payne Yang

Hi Tanous,

Got it.
By the way, I have to include a specific fpga library in this implementation. Should I update it also ?

The library should most likely be its own recipe, and dbus-sensors should get a DEPENDS added to its recipe.

Quoted 9 lines
Quoted 9 lines

-----Original Message-----
From: Tanous, Ed <[email protected]>
Sent: Wednesday, September 25, 2019 11:39 AM
To: Payne Yang <[email protected]>
Cc: [email protected]
Subject: [External] Re: Question for upstream

Create a gerrit review on dbus-sensors with your implementation.

#4 lore raw
In reply to Payne Yang
Quoted 2 lines · Payne Yang

By the way, I have to include a specific fpga library in this implementation. Should I update it also ?

Based on the initial premise, I was assuming this was just yet another hwmon temperature sensor in dbus-sensors. This is sounding more and more complex, and the answer to your questions is going to depend on what's there, what the licenses are, what the sizes are, how much extra stuff we're pulling in with this library, and whether or not it's able to be disabled by the people that won't be using it.

I think a lot of your questions would be answered by filling out a design template and submitting it to the docs repo. I would expect the "impacts" section would include some statement like "requires library X from vendor Y with license Z" and in that review, we'd be able to evaluate whether or not we want to support that, and what the model would be.

One thing to remember: everything in dbus sensors is intended to be configurable at runtime, so please try to avoid hardcoding addresses/buses in your application, and follow the pattern of some of the other sensors that are there.

-Ed