EDAC: Fix in e752x mc driver
Subsystems (2)
PATCH 1/3 EDAC: Fix in e752x mc driver
From: Mike Chan <[email protected]>
Diff against 2.6.19
This fix/change returns the offset into the page for
the ce/ue error, instead of just 0. The e752x dram controller reads 34:6 of the
linear address with the error.
Mike Chan
Signed-off-by Mike Chan <[email protected]>
Signed-off-by doug thompson <[email protected]>
---
e752x_edac.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-)
drivers/edac/e752x_edac.c +11 -6
@@ -285,8 +285,9 @@ static void do_process_ce(struct mem_ctlif (!pvt->map_type) row =7 - row; -edac_mc_handle_ce (mci, page,0 , sec1_syndrome, row, channel, -"e752x CE" ); +/* e752x mc reads 34:6 of the DRAM linear address */ +edac_mc_handle_ce (mci, page,offset_in_page (sec1_add <<4 ), + sec1_syndrome, row, channel,"e752x CE" ); } static inline void process_ce(struct mem_ctl_info *mci, u16 error_one,
@@ -319,8 +320,10 @@ static void do_process_ue(struct mem_ctl ((block_page >> 1) & 3) :edac_mc_find_csrow_by_page (mci, block_page); -edac_mc_handle_ue (mci, block_page,0 , row, -"e752x UE from Read" ); +/* e752x mc reads 34:6 of the DRAM linear address */ +edac_mc_handle_ue (mci, block_page, +offset_in_page (error_2b <<4 ), + row,"e752x UE from Read" ); }if (error_one &0x0404 ) { error_2b = scrb_add;
@@ -333,8 +336,10 @@ static void do_process_ue(struct mem_ctl ((block_page >> 1) & 3) :edac_mc_find_csrow_by_page (mci, block_page); -edac_mc_handle_ue (mci, block_page,0 , row, -"e752x UE from Scruber" ); +/* e752x mc reads 34:6 of the DRAM linear address */ +edac_mc_handle_ue (mci, block_page, +offset_in_page (error_2b <<4 ), + row,"e752x UE from Scruber" ); } }
Quoted 9 lines · On Wed, 13 Dec 2006 17:17:45 -0800 (PST) Doug Thompson <[email protected]> wrote:
From: Mike Chan <[email protected]>
Diff against 2.6.19
This fix/change returns the offset into the page for
the ce/ue error, instead of just 0. The e752x dram controller reads 34:6 of the
linear address with the error.
Quoted 4 lines
Mike Chan
Signed-off-by Mike Chan <[email protected]>Signed-off-by doug thompson <[email protected]>
Acked-by Alan Cox <[email protected]>