Skip to contentSkip to conversation

io_uring: ensure async buffered read-retry is setup properly

PATCH New Jens Axboe 1 participant 1 message Sep 25, 2020

Subsystems (2)
lore
Share & tools
lore

Jens Axboe

author maintainer
#0 lore raw

PATCH 1/1 io_uring: ensure async buffered read-retry is setup properly

A previous commit for fixing up short reads botched the async retry path, so we ended up going to worker threads more often than we should. Fix this up, so retries work the way they originally were intended to.

Fixes 227c0c9673d8 ("io_uring: internally retry short reads")

---

fs/io_uring.c +2 -4
index ad828fa19af4..11b8e428300d 100644
@@ -3172,10 +3172,8 @@ static int io_read(struct io_kiocb *req, bool force_nonblock,
 			goto done;
 		/* some cases will consume bytes even on error returns */
 		iov_iter_revert(iter, iov_count - iov_iter_count(iter));
-		ret = io_setup_async_rw(req, iovec, inline_vecs, iter, false);
-		if (ret)
-			goto out_free;
-		return -EAGAIN;
+		ret = 0;
+		goto copy_iov;
 	} else if (ret < 0) {
 		/* make sure -ERESTARTSYS -> -EINTR is done */
 		goto done;
Signature · 1 line
Jens Axboe