Skip to contentSkip to conversation

I2C: S3C24X0: Resolve build error for VCMA9

PATCH New Rajeshwari Shinde 4 participants 4 messages Jan 14, 2013 1 message not in the archive

Subsystems (2)
Arm Samsung Exynos I2C
lore
Share & tools
lore

Rajeshwari Shinde

author
#1 lore raw

PATCH v2 1/1 I2C: S3C24X0: Resolve build error for VCMA9

In reply to a message not in the archive

This patch resolves the following build errors for I2C driver in VCMA9:

In file included from s3c24x0_i2c.c:40:0:
s3c24x0_i2c.h:38:17: error: field 'id' has incomplete type s3c24x0_i2c.c:70:39: error: 'CONFIG_MAX_I2C_NUM' undeclared here (not in a function) s3c24x0_i2c.c:70:31: warning: 'i2c_bus' defined but not used [-Wunused-variable] s3c24x0_i2c.c:72:12: warning:
'i2c_busses' defined but not used [-Wunused-variable]

Signed-off-by Rajeshwari Shinde <[email protected]>

---
Changes since V1:
- Changes the commit message to add the errors.
- changed enum periph_id to int

 drivers/i2c/s3c24x0_i2c.c |    4 +++-
 drivers/i2c/s3c24x0_i2c.h |    3 +--
 2 files changed, 4 insertions(+), 3 deletions(-)
drivers/i2c/s3c24x0_i2c.c +3 -1
index 7ec01ec..769a2ba 100644
@@ -67,9 +67,11 @@
  * variables to live in SRAM
  */
 static unsigned int g_current_bus __attribute__((section(".data")));
+#ifdef CONFIG_OF_CONTROL
+static int i2c_busses __attribute__((section(".data")));
 static struct s3c24x0_i2c_bus i2c_bus[CONFIG_MAX_I2C_NUM]
 			__attribute__((section(".data")));
-static int i2c_busses __attribute__((section(".data")));
+#endif
 
 #if !(defined CONFIG_EXYNOS4 || defined CONFIG_EXYNOS5)
 static int GetI2CSDA(void)
drivers/i2c/s3c24x0_i2c.h +1 -2
index 1243bf1..a56d749 100644
@@ -35,7 +35,6 @@ struct s3c24x0_i2c_bus {
 	int node;	/* device tree node */
 	int bus_num;	/* i2c bus number */
 	struct s3c24x0_i2c *regs;
-	enum periph_id id;
+	int id;
 };
-
 #endif /* _S3C24X0_I2C_H */
Signature · 1 line
1.7.4.4
#2 lore raw

PATCH v2 1/1 I2C: S3C24X0: Resolve build error for VCMA9

Hello Rajeshwari,

Quoted 9 lines · Rajeshwari Shinde

This patch resolves the following build errors for I2C driver in VCMA9:

In file included from s3c24x0_i2c.c:40:0:
s3c24x0_i2c.h:38:17: error: field 'id' has incomplete type s3c24x0_i2c.c:70:39: error: 'CONFIG_MAX_I2C_NUM' undeclared here (not in a function) s3c24x0_i2c.c:70:31: warning: 'i2c_bus' defined but not used [-Wunused-variable] s3c24x0_i2c.c:72:12: warning:
'i2c_busses' defined but not used [-Wunused-variable]

Which U-Boot do you use? I just tried current head of mainline:

[hs at pollux u-boot]$ git log
commit fd70aa41468be4324275910f85578cb5be6a0439

Author: angelo <[email protected]>
Date:   Fri Nov 23 12:23:39 2012 +0000

m68k/lib: fix serial driver relocation

Fix coldfire serial driver bindings no more relocated to ram after last changes to drivers/serial/serial.c (regression).
Serial initialization in ram has to be called after that gd->reloc_off is calculated.

Signed-off-by Angelo Dureghello <[email protected]>
Cc Jason Jin <[email protected]>
Acked-by Jens Scharsig (BuS Elektronik) <[email protected]>
Tested-by Jens Scharsig (BuS Elektronik) <[email protected]>

and it compiles clean with eldk-5.2:

[hs at pollux u-boot]$ ./MAKEALL VCMA9
Configuring for VCMA9 board...
text data bss dec hex filename
523055 15112 296056 834223 cbaaf ./u-boot

--------------------- SUMMARY ---------------------------- Boards compiled: 1
----------------------------------------------------------
[hs at pollux u-boot]$

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#3 lore raw

PATCH v2 1/1 I2C: S3C24X0: Resolve build error for VCMA9

Hi Heiko,

I built it on latest tree u-boot-samsung.
For VCMA9_config I got the the errors.

Regards,
Rajeshwari Shinde.

Quoted 1 line · Heiko Schocher
Signature · 2 lines
Regards,
Rajeshwari Shinde
#4 lore raw

PATCH v2 1/1 I2C: S3C24X0: Resolve build error for VCMA9

In reply to Rajeshwari Shinde
Quoted 10 lines · Rajeshwari Shinde

This patch resolves the following build errors for I2C driver in VCMA9:

In file included from s3c24x0_i2c.c:40:0:
s3c24x0_i2c.h:38:17: error: field 'id' has incomplete type s3c24x0_i2c.c:70:39: error: 'CONFIG_MAX_I2C_NUM' undeclared here (not in a function) s3c24x0_i2c.c:70:31: warning: 'i2c_bus' defined but not used [-Wunused-variable] s3c24x0_i2c.c:72:12: warning:
'i2c_busses' defined but not used [-Wunused-variable]

Quoted 9 lines
Signed-off-by Rajeshwari Shinde <[email protected]>

---
Changes since V1:
- Changes the commit message to add the errors.
- changed enum periph_id to int

 drivers/i2c/s3c24x0_i2c.c |    4 +++-
 drivers/i2c/s3c24x0_i2c.h |    3 +--
 2 files changed, 4 insertions(+), 3 deletions(-)

applied to u-boot-samsung.

Thanks,
Minkyu Kang.