v4l2-ctl: print delta to current clock in verbose mode
PATCH 1/1 v4l2-ctl: print delta to current clock in verbose mode
If the Buffer Timestamp Clock is _MONOTONIC, print the delta to the current clock time. Useful for debugging / insights.
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
utils/v4l2-ctl/v4l2-ctl-streaming.cpp +0 -0
@@ -556,9 +556,15 @@ static void print_concise_buffer(FILE *f, cv4l_buffer &buf, cv4l_fmt &fmt,
double ts = buf.g_timestamp().tv_sec + buf.g_timestamp().tv_usec / 1000000.0; fprintf(f, " ts: %.06f", ts);
if (last_ts <= 0.0)
- fprintf(f, " delta: %.03f ms", (ts - last_ts) * 1000.0);
+ fprintf(f, " delta last: %.03f ms", (ts - last_ts) * 1000.0); last_ts = ts;
+ if ((buf.g_flags() & V4L2_BUF_FLAG_TIMESTAMP_MASK) == V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC) { + timespec ts_clock;
+ clock_gettime(CLOCK_MONOTONIC, &ts_clock);
+ fprintf(f, " delta now: %+.03f ms", ((ts_clock.tv_sec + ts_clock.tv_nsec / 1000000000.0) - ts) * 1000.0); + }
+
if (fps_ts.has_fps(true))
fprintf(stderr, " fps: %.02f", fps_ts.fps());
Signature · 1 line
2.29.0
Hi Max,
Quoted 29 lines · Max Schulze
If the Buffer Timestamp Clock is
_MONOTONIC, print the delta to the current clock time. Useful for debugging / insights.Signed-off-by Max Schuze <[email protected]>--- utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)utils/v4l2-ctl/v4l2-ctl-streaming.cpp +5
-1@@ -556,9 +556,15 @@ static void print_concise_buffer(FILE *f, cv4l_buffer &buf, cv4l_fmt &fmt, double ts = buf.g_timestamp().tv_sec + buf.g_timestamp().tv_usec / 1000000.0; fprintf(f, " ts: %.06f", ts); if (last_ts <= 0.0) - fprintf(f, " delta: %.03f ms", (ts - last_ts) * 1000.0); + fprintf(f, " delta last: %.03f ms", (ts - last_ts) * 1000.0); last_ts = ts; + if ((buf.g_flags() & V4L2_BUF_FLAG_TIMESTAMP_MASK) == V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC) { + timespec ts_clock; + clock_gettime(CLOCK_MONOTONIC, &ts_clock); + fprintf(f, " delta now: %+.03f ms", ((ts_clock.tv_sec +
Quoted 1 line
ts_clock.tv_nsec / 1000000000.0) - ts) * 1000.0);
I have no objection to this, but I think this needs to be enabled with a new option (e.g. --stream-show-delta-now) to avoid cluttering the output too much.
Regards,
Hans
Quoted 5 lines
+ }
+
if (fps_ts.has_fps(true))fprintf(stderr, " fps: %.02f", fps_ts.fps());
Hello Hans,
Quoted 27 lines · Hans Verkuil
Hi Max,
Quoted 24 lines · Max Schulze
If the Buffer Timestamp Clock is
_MONOTONIC, print the delta to the current clock time. Useful for debugging / insights.Signed-off-by Max Schuze <[email protected]>--- utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)utils/v4l2-ctl/v4l2-ctl-streaming.cpp +1
-1@@ -556,9 +556,15 @@ static void print_concise_buffer(FILE *f, cv4l_buffer &buf, cv4l_fmt &fmt, double ts = buf.g_timestamp().tv_sec + buf.g_timestamp().tv_usec / 1000000.0; fprintf(f, " ts: %.06f", ts); if (last_ts <= 0.0) - fprintf(f, " delta: %.03f ms", (ts - last_ts) * 1000.0); + fprintf(f, " delta last: %.03f ms", (ts - last_ts) * 1000.0); last_ts = ts;
Quoted 10 lines
Quoted 6 lines
utils/v4l2-ctl/v4l2-ctl-streaming.cpp +4
-0+ if ((buf.g_flags() & V4L2_BUF_FLAG_TIMESTAMP_MASK) == V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC) { + timespec ts_clock; + clock_gettime(CLOCK_MONOTONIC, &ts_clock); + fprintf(f, " delta now: %+.03f ms", ((ts_clock.tv_sec +ts_clock.tv_nsec / 1000000000.0) - ts) * 1000.0);
I have no objection to this, but I think this needs to be enabled with a new option (e.g. --stream-show-delta-now) to avoid cluttering the output too much.
Note we already need to be in verbose mode and not skip_ts .
Example output:
Quoted 5 lines
cap dqbuf: 0 seq: 0 bytesused: 512000 ts: 137342.420951 delta last: 137342420.951 ms delta now: +56.301 ms (ts-monotonic, ts-src-soe) cap dqbuf: 1 seq: 2 bytesused: 512000 ts: 137342.484954 delta now: +28.171 ms dropped: 1 (ts-monotonic, ts-src-soe) cap dqbuf: 2 seq: 3 bytesused: 512000 ts: 137342.520953 delta now: +24.296 ms (ts-monotonic, ts-src-soe)
cap dqbuf: 3 seq: 4 bytesused: 512000 ts: 137342.556925 delta now: +24.269 ms (ts-monotonic, ts-src-soe)
cap dqbuf: 0 seq: 5 bytesused: 512000 ts: 137342.592909 delta now: +24.216 ms fps: 29.08 (ts-monotonic, ts-src-soe)
BTW: is this the supposed way to display the "delta last", [...] "show the timestamp delta between two successive frames." ?
Do you want me to make another patch with mentioned command line option?
Best,
Max
Quoted 54 lines · Max Schulze
Hello Hans,
Quoted 27 lines · Hans Verkuil
Hi Max,
Quoted 24 lines · Max Schulze
If the Buffer Timestamp Clock is
_MONOTONIC, print the delta to the current clock time. Useful for debugging / insights.Signed-off-by Max Schuze <[email protected]>--- utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)utils/v4l2-ctl/v4l2-ctl-streaming.cpp +1
-1@@ -556,9 +556,15 @@ static void print_concise_buffer(FILE *f, cv4l_buffer &buf, cv4l_fmt &fmt, double ts = buf.g_timestamp().tv_sec + buf.g_timestamp().tv_usec / 1000000.0; fprintf(f, " ts: %.06f", ts); if (last_ts <= 0.0) - fprintf(f, " delta: %.03f ms", (ts - last_ts) * 1000.0); + fprintf(f, " delta last: %.03f ms", (ts - last_ts) * 1000.0); last_ts = ts;Quoted 10 lines
Quoted 6 lines
utils/v4l2-ctl/v4l2-ctl-streaming.cpp +4
-0+ if ((buf.g_flags() & V4L2_BUF_FLAG_TIMESTAMP_MASK) == V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC) { + timespec ts_clock; + clock_gettime(CLOCK_MONOTONIC, &ts_clock); + fprintf(f, " delta now: %+.03f ms", ((ts_clock.tv_sec +ts_clock.tv_nsec / 1000000000.0) - ts) * 1000.0);
I have no objection to this, but I think this needs to be enabled with a new option (e.g. --stream-show-delta-now) to avoid cluttering the output too much.
Note we already need to be in verbose mode and not
skip_ts.Example output:
Quoted 10 lines
cap dqbuf: 0 seq: 0 bytesused: 512000 ts: 137342.420951 delta
last: 137342420.951 ms delta now: +56.301 ms (ts-monotonic, ts-src-soe) cap dqbuf: 1 seq: 2 bytesused: 512000 ts: 137342.484954 delta
now: +28.171 ms dropped: 1 (ts-monotonic, ts-src-soe)
cap dqbuf: 2 seq: 3 bytesused: 512000 ts: 137342.520953 delta
now: +24.296 ms (ts-monotonic, ts-src-soe)
cap dqbuf: 3 seq: 4 bytesused: 512000 ts: 137342.556925 delta
now: +24.269 ms (ts-monotonic, ts-src-soe)
cap dqbuf: 0 seq: 5 bytesused: 512000 ts: 137342.592909 delta
now: +24.216 ms fps: 29.08 (ts-monotonic, ts-src-soe)
Quoted 2 lines
BTW: is this the supposed way to display the "delta last", [...] "show the timestamp delta between two successive frames." ?
Yes.
Quoted 3 lines
Do you want me to make another patch with mentioned command line option?
Yes please!
Regards,
Hans
Quoted 6 lines
Best,
Max
PATCH v2 1/1 v4l2-ctl: print delta to current clock in verbose mode
If the Buffer Timestamp Clock is _MONOTONIC, print the delta to the current clock time
needs --stream-show-delta-now together with --verbose
---
Changes since v1:
* Hide behind command-line Option
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 12 +++++++++++- utils/v4l2-ctl/v4l2-ctl.cpp | 1 + utils/v4l2-ctl/v4l2-ctl.h | 1 +
3 files changed, 13 insertions(+), 1 deletion(-)
utils/v4l2-ctl/v4l2-ctl-streaming.cpp +0 -0
@@ -326,6 +326,10 @@ void streaming_usage()
" --stream-out-dmabuf\n"
" output video using dmabuf [VIDIOC_(D)QBUF]\n"
" Requires a corresponding --stream-mmap option.\n" + " --stream-show-delta-now\n"
+ " output the difference between the buffer timestamp and current\n" + " clock, if the buffer timestamp source is the monotonic clock.\n" + " requires --verbose\n"
" --list-patterns list available patterns for use with --stream-pattern.\n" " --list-buffers list all video buffers [VIDIOC_QUERYBUF]\n"
" --list-buffers-out list all video output buffers [VIDIOC_QUERYBUF]\n" @@ -556,9 +560,15 @@ static void print_concise_buffer(FILE *f, cv4l_buffer &buf, cv4l_fmt &fmt, double ts = buf.g_timestamp().tv_sec + buf.g_timestamp().tv_usec / 1000000.0; fprintf(f, " ts: %.06f", ts);
if (last_ts <= 0.0)
- fprintf(f, " delta: %.03f ms", (ts - last_ts) * 1000.0);
+ fprintf(f, " delta last: %.03f ms", (ts - last_ts) * 1000.0);
last_ts = ts;
+ if (options[OptStreamShowDeltaNow] && (buf.g_flags() & V4L2_BUF_FLAG_TIMESTAMP_MASK) == V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC) { + timespec ts_clock;
+ clock_gettime(CLOCK_MONOTONIC, &ts_clock);
+ fprintf(f, " delta now: %+.03f ms", ((ts_clock.tv_sec + ts_clock.tv_nsec / 1000000000.0) - ts) * 1000.0); + }
+
if (fps_ts.has_fps(true))
fprintf(stderr, " fps: %.02f", fps_ts.fps());
utils/v4l2-ctl/v4l2-ctl.cpp +0 -0
@@ -265,6 +265,7 @@ static struct option long_options[] = {
{"stream-out-mmap", optional_argument, nullptr, OptStreamOutMmap}, {"stream-out-user", optional_argument, nullptr, OptStreamOutUser}, {"stream-out-dmabuf", no_argument, nullptr, OptStreamOutDmaBuf}, + {"stream-show-delta-now", no_argument, nullptr, OptStreamShowDeltaNow}, {"list-patterns", no_argument, nullptr, OptListPatterns}, {"version", no_argument, nullptr, OptVersion},
{nullptr, 0, nullptr, 0}
utils/v4l2-ctl/v4l2-ctl.h +0 -0
@@ -245,6 +245,7 @@ enum Option {
OptStreamOutMmap,
OptStreamOutUser,
OptStreamOutDmaBuf,
+ OptStreamShowDeltaNow,
OptListPatterns,
OptHelpTuner,
OptHelpIO,
Signature · 1 line
2.29.0