Skip to contentSkip to conversation

Where do we stand with the Xen patches?

DISCUSSION [email protected] 3 participants 3 messages May 17, 2009

lore
Share & tools
lore
#0 lore raw
Quoted 16 lines
Quoted 9 lines

Aside from some whitespace issues around some Impact: lines, I don't know of any outstanding problems. (I just pushed an updates to these branches to fix those, and fold a change to address Jesse's comment.)

Please tell me if you have any further issues which prevents you from pulling these changes. Otherwise I'd appreciate it if you pulled them soon, as we're already on -rc5, and I have more changes I'd like to prep for the next merge window.

As in the past, my main worry is performance overhead of paravirt in general.

The patches that dont affect any native kernel fast path are probably OK (but still pending final review).

Quoted 8 lines

Regarding patches that do change the fastpath i'll do a round of measurements of CONFIG_PARAVIRT against !CONFIG_PARAVIRT kernels, and make up my mind based on that.

You could accelerate this by sending some "perf stat" hard numbers to give us an idea about where we stand today.

Ingo

maybe this is iust a stupid comment (please forgive, iŽm no advanced kernel hacker), but canŽt the code inserted by the patches and which changes the fastpath just #IFDEFed at the critical offsets ? (as building a dom0 kernel is just another build target, isnt it ?)

regards
roland
______________________________________________________
GRATIS für alle WEB.DE-Nutzer: Die maxdome Movie-FLAT! Jetzt freischalten unter http://movieflat.web.de

#1 lore raw
Quoted 23 lines · On Sun, 17 May 2009, [email protected] wrote:
Quoted 23 lines
Quoted 9 lines

Aside from some whitespace issues around some Impact: lines, I don't know of any outstanding problems. (I just pushed an updates to these branches to fix those, and fold a change to address Jesse's comment.)

Please tell me if you have any further issues which prevents you from pulling these changes. Otherwise I'd appreciate it if you pulled them soon, as we're already on -rc5, and I have more changes I'd like to prep for the next merge window.

As in the past, my main worry is performance overhead of paravirt in general.

The patches that dont affect any native kernel fast path are probably OK (but still pending final review).

Regarding patches that do change the fastpath i'll do a round of measurements of CONFIG_PARAVIRT against !CONFIG_PARAVIRT kernels, and make up my mind based on that.

You could accelerate this by sending some "perf stat" hard numbers to give us an idea about where we stand today.

Quoted 6 lines
Quoted 1 line

Ingo

maybe this is iust a stupid comment (please forgive, i?m no advanced kernel hacker), but can?t the code inserted by the patches and which changes the fastpath just #IFDEFed at the critical offsets ? (as building a dom0 kernel is just another build target, isnt it ?)

no, if dom0 is going to be widely deployed, it will be because the distros turn on dom0 support by default. as a result any penalties due to xen support will be felt by all users of those distros (even if they don't use xen)

David Lang

#2 lore raw
Quoted 7 lines · On Sun, 17 May 2009 12:25:38 -0700 (PDT) [email protected] wrote:
Quoted 5 lines · On Sun, 17 May 2009, [email protected] wrote:

maybe this is iust a stupid comment (please forgive, i?m no advanced kernel hacker), but can?t the code inserted by the patches and which changes the fastpath just #IFDEFed at the critical offsets ? (as building a dom0 kernel is just another build target, isnt it ?)

Quoted 5 lines

no, if dom0 is going to be widely deployed, it will be because the distros turn on dom0 support by default. as a result any penalties due to xen support will be felt by all users of those distros (even if they don't use xen)

at minimum we need to split CONFIG_PARAVIRT up into
"want to be nice to hypervisors" and "I want to be Xen Dom0"; they look to largely not overlap.... so lets not make the costs overlap either.

Signature · 3 lines
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org