io_uring/rw: return IOU_ISSUE_SKIP_COMPLETE for multishot retry
Jens Axboe
maintainerPATCH 1/1 io_uring/rw: return IOU_ISSUE_SKIP_COMPLETE for multishot retry
If read multishot is being invoked from the poll retry handler, then we should return IOU_ISSUE_SKIP_COMPLETE rather than -EAGAIN. If not, then a CQE will be posted with -EAGAIN rather than triggering the retry when the file is flagged as readable again.
Reported-by Sargun Dhillon <[email protected]>
Fixes fc68fcda04910 ("io_uring/rw: add support for IORING_OP_READ_MULTISHOT")
Signed-off-by Jens Axboe <[email protected]>
---
io_uring/rw.c +2 -0
@@ -947,6 +947,8 @@ int io_read_mshot(struct io_kiocb *req, unsigned int issue_flags)*/ if (io_kbuf_recycle (req, issue_flags)) rw->len =0 ; +if (issue_flags &IO_URING_F_MULTISHOT ) +return IOU_ISSUE_SKIP_COMPLETE ;return -EAGAIN ; }
Signature · 1 line
Jens Axboe