Skip to contentSkip to conversation

scsi: aic7xxx: Remove null pointer checks before kfree()

PATCH Markus Elfring 3 participants 6 messages Apr 5, 2020 – Apr 9, 2020 SCSI

lore
Share & tools
lore
#0 lore raw
Quoted 1 line

NULL check before kfree is unnecessary so remove it.

I hope that you would like to take another update suggestion into account (besides a typo correction for your commit message).
https://lore.kernel.org/patchwork/patch/1220189/
https://lore.kernel.org/linux-scsi/[email protected]/

Do you find a previous update suggestion like “SCSI-aic7...: Delete unnecessary checks before the function call "kfree"” also interesting?
https://lore.kernel.org/linux-scsi/[email protected]/
https://lore.kernel.org/patchwork/patch/540593/
https://lkml.org/lkml/2015/2/5/650

Regards,
Markus

#1 lore raw

Sorry about nnnnoise, please just ignore it.

Quoted 16 lines · Markus Elfring
Quoted 2 lines

NULL check before kfree is unnecessary so remove it.

I hope that you would like to take another update suggestion into account (besides a typo correction for your commit message).
https://lore.kernel.org/patchwork/patch/1220189/
https://lore.kernel.org/linux-scsi/[email protected]/

Do you find a previous update suggestion like “SCSI-aic7...: Delete unnecessary checks before the function call "kfree"” also interesting?
https://lore.kernel.org/linux-scsi/[email protected]/
https://lore.kernel.org/patchwork/patch/540593/
https://lkml.org/lkml/2015/2/5/650

Regards,
Markus

#2 lore raw
In reply to Markus Elfring

Markus,

Quoted 6 lines · Markus Elfring
Quoted 1 line

NULL check before kfree is unnecessary so remove it.

I hope that you would like to take another update suggestion into account (besides a typo correction for your commit message).
https://lore.kernel.org/patchwork/patch/1220189/
https://lore.kernel.org/linux-scsi/[email protected]/

I'm not sure I understand the relevance. Are you saying I should reference this other patch?

Quoted 7 lines

Do you find a previous update suggestion like “SCSI-aic7...: Delete unnecessary checks before the function call "kfree"” also interesting?
https://lore.kernel.org/linux-scsi/[email protected]/
https://lore.kernel.org/patchwork/patch/540593/
https://lkml.org/lkml/2015/2/5/650

Thanks for the reference. I'll mention it in the commit if I do a v2.

Best,
Alex

Quoted 2 lines

Regards,
Markus

#3 lore raw
Quoted 6 lines
Quoted 4 lines

I hope that you would like to take another update suggestion into account (besides a typo correction for your commit message).
https://lore.kernel.org/patchwork/patch/1220189/
https://lore.kernel.org/linux-scsi/[email protected]/

I'm not sure I understand the relevance.

I pointed your patch out for another contributor.

Quoted 1 line

Are you saying I should reference this other patch?

I suggest to take another look at the development history for presented patches according to a known source code search pattern.

Quoted 1 line

Thanks for the reference. I'll mention it in the commit if I do a v2.

I am curious under which circumstances the affected source files will actually be improved in ways which were suggested a few times.

Regards,
Markus

#4 lore raw
Quoted 7 lines · Markus Elfring
Quoted 6 lines
Quoted 4 lines

I hope that you would like to take another update suggestion into account (besides a typo correction for your commit message).
https://lore.kernel.org/patchwork/patch/1220189/
https://lore.kernel.org/linux-scsi/[email protected]/

I'm not sure I understand the relevance.

Quoted 7 lines

I pointed your patch out for another contributor.

Quoted 1 line

Are you saying I should reference this other patch?

I suggest to take another look at the development history for presented patches according to a known source code search pattern.

Ok, cool. How should I go about that?

The thing is that this seems like an obvious improvement (albeit not a terribly critical one). It reduces SLoC and removes an unnecessary check. AFAICS the patch you mention wasn't rejected on technical grounds, but simply wasn't picked up. If there is a reason why this change isn't warranted then I'd like to know why so I can send better patches in future :-)

Quoted 9 lines
Quoted 3 lines

Thanks for the reference. I'll mention it in the commit if I do a v2.

I am curious under which circumstances the affected source files will actually be improved in ways which were suggested a few times.

Regards,
Markus

#5 lore raw
Quoted 1 line

The thing is that this seems like an obvious improvement

Such a view can be promising.

Quoted 1 line

(albeit not a terribly critical one).

The prioritisation influences change integration considerably.

Quoted 1 line

It reduces SLoC and removes an unnecessary check.

I hope that such goals will be reconsidered also for this software module.

Quoted 2 lines

AFAICS the patch you mention wasn't rejected on technical grounds, but simply wasn't picked up.

The usual factors were involved for free software development.

Quoted 2 lines

If there is a reason why this change isn't warranted
then I'd like to know why so I can send better patches in future :-)

I hope that also your change interests can increase chances for software evolution in desired directions.
With which delays will specific improvements be achieved?

Regards,
Markus