Skip to contentSkip to conversation

UAS: Rename urbs by pipe

PATCH Luben Tuikov 1 participant 1 message Nov 8, 2010

lore
Share & tools
lore
#0 lore raw
Quoted 8 lines · Luben Tuikov

--- On Mon, 11/8/10, Matthew Wilcox
<[email protected]>

Quoted 5 lines · wrote:
Quoted 3 lines · Luben Tuikov

The reason to do this is to accommodate sending
different IU types using the existing
infrastructure.

Quoted 5 lines
Quoted 1 line

Applied, with a modified changelog entry ...

Again, where is it applied and what is the (new) modified changelog entry? Why would you leave this detail out in your response to the patch?

Please have some professional integrity and EITHER a) ask me to
resubmit the patch with a new change log (what would you like?) or b) discuss it here publicly.

See my previous post on your other modification of the change log to my other patch against your code.

Quoted 38 lines
Quoted 7 lines
Quoted 7 lines

      struct urb *data_out_urb;
      struct list_head list;
  };

-/* I hate forward declarations, but I actually

have a

Quoted 9 lines

loop */

Quoted 1 line

  static int uas_submit_urbs(struct scsi_cmnd

*cmnd,

Quoted 1 line

        struct uas_dev_info
*devinfo, gfp_t gfp);

Quoted 1 line

Except for this spurious chunk.

Sorry, please help us understand: You'll LEAVE a self-gratifying, narcissistic and pompous statement like "I hate forward-declarations"? Why would you use such a strong word? Why would you "hate"? How about: "I don't like" or "I know lk style discourages", etc. Why would you add /one more/ "hate" word into the kernel?

I think everyone sees why this forward-decl is needed.

I wonder if the relation of the number of the "hate" word in the linux kernel versus time correlates to something, anything? Now that's easier to track and analyze in time using git.

Compared to people losing their homes and jobs nowadays, I'll take a forward declaration any time of day and night.

Bottom line: please consider the patch as is.