dbus-glib-native: install dbus-binding-tool to ${STAGING_BINDIR}?
Hi, I've got this change in my local workdir, unfortunately I don't remember what exactly needed the binding tool. Is this ok to commit?
dbus/dbus-glib-native_0.72.bb +2 -1
@@ -1,5 +1,5 @@ SECTION = "base" SECTION = "base" -PR = "r0" +PR = "r1" HOMEPAGE = "http://www.freedesktop.org/Software/dbus" DESCRIPTION = "message bus system for applications to talk to one another" LICENSE = "GPL"
@@ -19,4 +19,5 @@ do_stage() { install -d ${STAGING_DATADIR}/dbus install -m 0644 tools/dbus-bus-introspect.xml ${STAGING_DATADIR}/dbus install -m 0644 tools/dbus-glib-bindings.h ${STAGING_DATADIR}/dbus + install -m 0755 dbus/.libs/dbus-binding-tool ${STAGING_BINDIR}/ }
cheers
Philipp
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
pHilipp Zabel schreef:
Quoted 2 lines
Hi, I've got this change in my local workdir, unfortunately I don't remember what exactly needed the binding tool. Is this ok to commit?
iirc eds-dbus
regards,
Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFGzU48MkyGM64RGpERAtDuAKCKCrgTM0b7WeBHZBDGCxXMEWvxtACdH6QI 1SNiyTom9Wcsa9aKA0I2GoY=
=XSGa
-----END PGP SIGNATURE-----
Quoted 15 lines · pHilipp Zabel
Hi, I've got this change in my local workdir, unfortunately I don't remember what exactly needed the binding tool. Is this ok to commit?
--- packages/dbus/dbus-glib-native_0.72.bb
278c6e1074af019c5bf108638bebfba814ddc160
+++ packages/dbus/dbus-glib-native_0.72.bb5c8a08a3c0bc93f2de4060d523738b5500cd88c0dbus/dbus-glib-native_0.72.bb +1
-1@@ -1,5 +1,5 @@ SECTION = "base" SECTION = "base" -PR = "r0" +PR = "r1" HOMEPAGE = "http://www.freedesktop.org/Software/dbus" DESCRIPTION = "message bus system for applications to talk to one another" LICENSE = "GPL"
dbus/dbus-glib-native_0.72.bb do_stage() { · line 23
Quoted 5 lines
dbus/dbus-glib-native_0.72.bb +1
-0@@ -19,4 +19,5 @@ do_stage() { install -d ${STAGING_DATADIR}/dbus install -m 0644 tools/dbus-bus-introspect.xml ${STAGING_DATADIR}/dbus install -m 0644 tools/dbus-glib-bindings.h ${STAGING_DATADIR}/dbus + install -m 0755 dbus/.libs/dbus-binding-tool ${STAGING_BINDIR}/ }
Does anything speak against using autotools_stage_all here? I'd rather go away from handcoded do_stage() as much as possible.
Regards,
:M:
Signature · 1 line
Michael 'Mickey' Lauer | IT-Freelancer | http://www.vanille-media.de
Quoted 6 lines · Dr. Michael Lauer
Quoted 2 lines · pHilipp Zabel
Hi, I've got this change in my local workdir, unfortunately I don't remember what exactly needed the binding tool. Is this ok to commit?
Does anything speak against using
autotools_stage_allhere? I'd rather go away from handcodeddo_stage()as much as possible.
Not that I know of - let's try.
cheers
Philipp