Skip to contentSkip to conversation

xe-rev1 Branch for ease the intial review / ack.

Intel-xe Vivi, Rodrigo 3 participants 3 messages May 1, 2023 – May 2, 2023

lore
Share & tools
lore
#0 lore raw

Hi Oded,

I have created a xe-rev1 branch in our gitlab [1]
to ease your review.

The patches there are a subset of current drm-xe-next, excluding any patch that is needed for display, but also any other non-display patch that is on top of the display patches.

Let's start with these for now, and iterate next.

The only (big?!) risk for changes on this patch is related to the drm/sched patches that we have underneath the initial mega squash. Depending on the acceptance of the drm/sched changes for the fw scheduling and the 1:1 relationship on the sched and entity.

Other than that, these patches shouldn't change any longer. Unless requested in any review in this round.

Anyway, I truly hope that the review requests can end up in gitlab/issues and addressed with follow-up patches on top.

Thanks a lot for jumping in to help on this upstreaming acceptance.

Cheers,
Rodrigo.

[1] https://gitlab.freedesktop.org/drm/xe/kernel/-/tree/xe-rev1

#1 lore raw
Quoted 22 lines · Rodrigo

Hi Oded,

I have created a xe-rev1 branch in our gitlab [1]
to ease your review.

The patches there are a subset of current drm-xe-next, excluding any patch that is needed for display, but also any other non-display patch that is on top of the display patches.

Let's start with these for now, and iterate next.

The only (big?!) risk for changes on this patch is related to the drm/sched patches that we have underneath the initial mega squash. Depending on the acceptance of the drm/sched changes for the fw scheduling and the 1:1 relationship on the sched and entity.

Other than that, these patches shouldn't change any longer. Unless requested in any review in this round.

Anyway, I truly hope that the review requests can end up in gitlab/issues and addressed with follow-up patches on top.

Quoted 6 lines

Thanks a lot for jumping in to help on this upstreaming acceptance.

Cheers,
Rodrigo.

[1] https://gitlab.freedesktop.org/drm/xe/kernel/-/tree/xe-rev1

Adding Oded.

Francois

#2 lore raw
Quoted 26 lines · Francois Dugast
Quoted 24 lines · Rodrigo

Hi Oded,

I have created a xe-rev1 branch in our gitlab [1]
to ease your review.

The patches there are a subset of current drm-xe-next, excluding any patch that is needed for display, but also any other non-display patch that is on top of the display patches.

Let's start with these for now, and iterate next.

The only (big?!) risk for changes on this patch is related to the drm/sched patches that we have underneath the initial mega squash. Depending on the acceptance of the drm/sched changes for the fw scheduling and the 1:1 relationship on the sched and entity.

Other than that, these patches shouldn't change any longer. Unless requested in any review in this round.

Anyway, I truly hope that the review requests can end up in gitlab/issues and addressed with follow-up patches on top.

Thanks a lot for jumping in to help on this upstreaming acceptance.

Quoted 8 lines
Quoted 4 lines

Cheers,
Rodrigo.

[1] https://gitlab.freedesktop.org/drm/xe/kernel/-/tree/xe-rev1

Adding Oded.

Francois

- my Intel email
Thanks Rodrigo and Francois.
I'll start doing the review today/tomorrow.
I plan to write all the comments in a text file, as we don't have a patch-set in emails.
I think it would be best if I'll just push that file into the review branch itself, so we can track review comments vs. the code. For discussions we can copy the relevant comment to a mail and start a mail thread in this list.

btw, next week I'm on vacation so the review will be on hold during that time, sorry.
Thanks,
Oded