Skip to contentSkip to conversation

pinctrl: da9062: Fix include path

PATCH In review Valdis Klētnieks 2 participants 2 messages Mar 17, 2020

Subsystems (3)
GPIO Pin control Dialog semiconductor drivers
lore
Share & tools
lore

Valdis Klētnieks

author
#0 lore raw

PATCH 1/1 pinctrl: da9062: Fix include path

Found during a allmodconfig build on ARM on an RPi4:

CC drivers/pinctrl/pinctrl-da9062.o
drivers/pinctrl/pinctrl-da9062.c:28:10: fatal error: ../gpio/gpiolib.h: No such file or directory

 #include <../gpio/gpiolib.h>
          ^~~~~~~~~~~~~~~~~~~

compilation terminated.

So... fix the errant include.

Signed-off-by Valdis Kletnieks <[email protected]>
Fixes 56cc3af4e8c8e ("pinctrl: da9062: add driver support")
drivers/pinctrl/pinctrl-da9062.c +1 -1
index f704ee0b2fd9..cfbe529e66c3 100644
@@ -25,7 +25,7 @@
  * We need this get the gpio_desc from a <gpio_chip,offset> tuple to decide if
  * the gpio is active low without a vendor specific dt-binding.
  */
-#include <../gpio/gpiolib.h>
+#include <../drivers/gpio/gpiolib.h>
 
 #define DA9062_TYPE(offset)		(4 * (offset % 2))
 #define DA9062_PIN_SHIFT(offset)	(4 * (offset % 2))
#1 lore raw

Hi,

Quoted 7 lines · Valdis Klētnieks

Found during a allmodconfig build on ARM on an RPi4:

CC drivers/pinctrl/pinctrl-da9062.o
drivers/pinctrl/pinctrl-da9062.c:28:10: fatal error: ../gpio/gpiolib.h: No such file or directory

 #include <../gpio/gpiolib.h>
          ^~~~~~~~~~~~~~~~~~~

compilation terminated.

this should be fixed already:

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/pinctrl/pinctrl-da9062.c?id=2353810dac9ab72d3f835e3fb015c6819a0ef6c2

Regards,
Marco

Quoted 21 lines

So... fix the errant include.

Signed-off-by Valdis Kletnieks <[email protected]>
Fixes 56cc3af4e8c8e ("pinctrl: da9062: add driver support")
drivers/pinctrl/pinctrl-da9062.c +1 -1
index f704ee0b2fd9..cfbe529e66c3 100644
@@ -25,7 +25,7 @@
  * We need this get the gpio_desc from a <gpio_chip,offset> tuple to decide if
  * the gpio is active low without a vendor specific dt-binding.
  */
-#include <../gpio/gpiolib.h>
+#include <../drivers/gpio/gpiolib.h>
 
 #define DA9062_TYPE(offset)		(4 * (offset % 2))
 #define DA9062_PIN_SHIFT(offset)	(4 * (offset % 2))
Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |