lpc_ich: use devres API to allocate private data
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): 774339a2-e7cc-4204-a935-0a1b59e2ece8@zimbra
PATCH 1/1 lpc_ich: use devres API to allocate private data
Signed-off-by Aaron Sierra <[email protected]>
--- drivers/mfd/lpc_ich.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/mfd/lpc_ich.c +2 -5
@@ -878,7 +878,8 @@ static int lpc_ich_probe(struct pci_dev *dev,int ret;bool cell_added = false; - priv =kmalloc (GFP_KERNEL ,sizeof (struct lpc_ich_priv )); + priv =devm_kzalloc (&dev->dev, +sizeof (struct lpc_ich_priv ),GFP_KERNEL );if (!priv)return -ENOMEM ;
@@ -914,7 +915,6 @@ static int lpc_ich_probe(struct pci_dev *dev,dev_warn (&dev->dev,"No MFD cells added\n" );lpc_ich_restore_config_space (dev);pci_set_drvdata (dev,NULL ); -kfree (priv);return -ENODEV ; }
@@ -923,12 +923,9 @@ static int lpc_ich_probe(struct pci_dev *dev,static void lpc_ich_remove (struct pci_dev *dev) { -void *priv =pci_get_drvdata (dev); -mfd_remove_devices (&dev->dev);lpc_ich_restore_config_space (dev);pci_set_drvdata (dev,NULL ); -kfree (priv); }static struct pci_driver lpc_ich_driver = {
Signature · 1 line
1.7.9.5
----- Original Message -----
Quoted 9 lines
From: "Aaron Sierra" <[email protected]>
To: "Samuel Ortiz" <[email protected]>
Cc: "LKML" <[email protected]>
Sent: Thursday, February 14, 2013 11:35:04 AM
Subject: [PATCH]lpc_ich: use devres API to allocate private dataSigned-off-by Aaron Sierra <[email protected]>---
[trim]
drivers/mfd/lpc_ich.c static int lpc_ich_probe(struct pci_dev *dev, · line 882
Quoted 3 lines
drivers/mfd/lpc_ich.c +2
-1- priv =kmalloc (GFP_KERNEL ,sizeof (struct lpc_ich_priv )); + priv =devm_kzalloc (&dev->dev, +sizeof (struct lpc_ich_priv ),GFP_KERNEL );
Samuel,
Perhaps this should now include a comment about this patch also resolving the issue that Anatol reported yesterday?
-Aaron
Samuel Ortiz
AppliedHi Arron,
Quoted 5 lines · Aaron Sierra
Signed-off-by Aaron Sierra <[email protected]>--- drivers/mfd/lpc_ich.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
Applied, thanks.
Cheers,
Samuel.
Signature · 2 lines
Intel Open Source Technology Centre http://oss.intel.com/