Skip to contentSkip to conversation

small compile warning fix

PATCH Petr Vandrovec 2 participants 2 messages Oct 29, 2001 – Oct 30, 2001

lore
Share & tools
lore
#0 lore raw
Quoted 10 lines · Manik Raina

Index: ncplib_kernel.c
===================================================================
RCS file: /vger/linux/fs/ncpfs/ncplib_kernel.c,v
retrieving revision 1.29
diff -u -r1.29 ncplib_kernel.c

ncplib_kernel.c 29 Oct 2001 10:09:27 -0000 renamed from ncplib_kernel.c 18 Sep 2001 22:29:08 -0000 1.29 +0 -0
@@ -52,6 +52,11 @@
    return;

ncplib_kernel.c 29 Oct 2001 10:09:27 -0000 line 62

Quoted 10 lines
ncplib_kernel.c 29 Oct 2001 10:09:27 -0000 renamed from ncplib_kernel.c 18 Sep 2001 22:29:08 -0000 1.29 +5 -0
 }
 
+#ifdef LATER
+/*
+ * This function is not currently in use. This leads to a compiler warning.
+ * Remove #ifdef when in use...
+ */
 static void ncp_add_mem_fromfs(struct ncp_server *server, const char *source, int size)
 {
    assert_server_locked(server);

You can remove it completely. It should not be '#ifdef LATER', but '#ifdef OLDVERSION'... ncp_add_mem_fromfs was invoked with lock on ncp_server structure, but then it directly accessed userspace. It was possible to use this to cause deadlock, so now ncpfs uses bounce buffers and double copy instead of this.

I have some ncpfs patches, but I though that I'll leave them for 2.5.x. Maybe it is time to change this decision.
Best regards,
Petr Vandrovec [email protected]

#1 lore raw
Quoted 13 lines · Petr Vandrovec
Quoted 12 lines · Manik Raina

Index: ncplib_kernel.c
===================================================================
RCS file: /vger/linux/fs/ncpfs/ncplib_kernel.c,v
retrieving revision 1.29
diff -u -r1.29 ncplib_kernel.c

ncplib_kernel.c 29 Oct 2001 10:09:27 -0000 renamed from ncplib_kernel.c 18 Sep 2001 22:29:08 -0000 1.29 +0 -0
@@ -52,6 +52,11 @@
    return;
 }
 
Quoted 15 lines

ncplib_kernel.c 29 Oct 2001 10:09:27 -0000 line 62

Quoted 8 lines
ncplib_kernel.c 29 Oct 2001 10:09:27 -0000 renamed from ncplib_kernel.c 18 Sep 2001 22:29:08 -0000 1.29 +5 -0
+#ifdef LATER
+/*
+ * This function is not currently in use. This leads to a compiler warning.
+ * Remove #ifdef when in use...
+ */
 static void ncp_add_mem_fromfs(struct ncp_server *server, const char *source, int size)
 {
    assert_server_locked(server);

You can remove it completely. It should not be '#ifdef LATER', but '#ifdef OLDVERSION'... ncp_add_mem_fromfs was invoked with lock on ncp_server structure, but then it directly accessed userspace. It was possible to use this to cause deadlock, so now ncpfs uses bounce buffers and double copy instead of this.

would you include this in your patches or would you like me to make it #ifdef OLDVERSION ?

thanks
Manik

Quoted 7 lines

I have some ncpfs patches, but I though that I'll leave them for 2.5.x. Maybe it is time to change this decision.
Best regards,
Petr Vandrovec [email protected]