Skip to contentSkip to conversation

include/linux/slab.h: new KFREE() macro.

PATCH Bodo Eggert 1 participant 1 message Jan 8, 2007 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 8 lines · Amit Choudhary
Quoted 7 lines · --- Christoph Hellwig
Quoted 2 lines · Amit Choudhary

Well, I am not proposing this as a debugging aid. The idea is about correct programming,

atleast

Quoted 2 lines

from my view. Ideally, if you kfree(x), then you should set x to NULL. So, either programmers

Quoted 8 lines
Quoted 4 lines

do

Quoted 1 line

it themselves or a ready made macro do it for them.

No, you should not. I suspect that's the basic point you're missing.

Any strong reason why not? x has some value that does not make sense and can create only problems. And as I explained, it can result in longer code too. So, why keep this value around. Why not re-initialize it to NULL.

1) Because some magic value like 0x23 would be better.
2) Because it hides bugs like double frees or dangeling references while creating a race condition. In the end, you'll get more hard-to-find bugs in exchange for papering over some easy-to-spot bugs.

Quoted 3 lines

If x should not be re-initialized to NULL, then by the same logic, we should not even initialize local variables. And all of us know that local variables should be initialized.

That may hide bugs, too. Therefore this isn't done in the kernel unless you intend to depend on an initial value.

Signature · 4 lines
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF
verbreiteten Lügen zu sabotieren.

http://david.woodhou.se/why-not-spf.html