raw: don't allow the creation of a raw device with minor number 0
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 10 lines · Dave Jones
Quoted 8 lines · On Fri, Jan 12, 2007 at 05:58:41PM -0500, [email protected] wrote:
jengelh> What: RAW driver (CONFIG_RAW_DRIVER) jengelh> When: December 2005 jengelh> Why: declared obsolete since kernel 2.6.3 jengelh> O_DIRECT can be used instead jengelh> Who: Adrian Bunk <[email protected]>It's still present, still used, and so would benefit from being fixed, in my opinion.
ACK, it's a bug, the patch is there, and AFAIR it's simple and correct. Maybe it is suitable for the stable branch, too. If the RAW driver isn't removed, it should be applied.
Quoted 2 lines
Given the tirade against
O_DIRECTon linux-kernel earlier this month, it has me wondering about the validity of this entry.
O_DIRECT on devices is accepted by Linus, since it has much less corner cases.
Quoted 7 lines
Every time we've tried to deprecate this driver in Fedora/RHEL, we've had enough people complain that we've ended up having to turn it back on. (And I'm fairly sure other distros have been in the same position). Some vendors seem way too attached to the older semantics than having to rewrite their apps to use
O_DIRECT, and unnecessarily breaking them so that we can throw away a 306 line driver in the name of cleanliness seems a bit gratuitous.
It must be hard to add #ifndef O_DIRECT / #define O_DIRECT 0 / #endif and to add O_DIRECT to the apropiate open calls ...
(I peeked into the driver, and it seems it's just a wrapper creating an alias
and opening the associated block-device O_DIRECT.)
Signature · 4 lines
We are all born ignorant, but one must work hard to remain stupid.
-- Benjamin Franklin
Friß, Spammer: [email protected] [email protected]