Skip to contentSkip to conversation

Dynamic kernel command-line - arm

PATCH Bodo Eggert 2 participants 2 messages Jan 18, 2007 – Jan 22, 2007 4 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 15 lines · Alon Bar-Lev
Quoted 10 lines · Russell King
Quoted 1 line · Bernhard Walle

2. Set command_line as __initdata.

You can't.

Review

Quoted 2 lines
(quoted diff) +1 -1
-static char command_line[COMMAND_LINE_SIZE];
+static char __initdata command_line[COMMAND_LINE_SIZE];

Uninitialised data is placed in the BSS. Adding __initdata to BSS data causes grief.

There are many places in kernel that uses __initdata for uninitialized variables.

Quoted 6 lines

For example:

static int __initdata is_chipset_set[MAX_HWIFS];

So all these current places are wrong?
If I initialize the data will it be OK.

objdump -t vmlinux |grep -3 is_chipset_set suggests that it's placed into .init.data here, not into .bss.

Signature · 4 lines
Top 100 things you don't want the sysadmin to say:
92. What software license?

Friß, Spammer: [email protected] [email protected]
#5 lore raw
Quoted 18 lines · Bodo Eggert
Quoted 16 lines · Alon Bar-Lev
Quoted 10 lines · Russell King
Quoted 1 line · Bernhard Walle

2. Set command_line as __initdata.

You can't.

Review

Quoted 2 lines
(quoted diff) +1 -1
-static char command_line[COMMAND_LINE_SIZE];
+static char __initdata command_line[COMMAND_LINE_SIZE];

Uninitialised data is placed in the BSS. Adding __initdata to BSS data causes grief.

There are many places in kernel that uses __initdata for uninitialized variables.

For example:

Quoted 7 lines
Quoted 4 lines

static int __initdata is_chipset_set[MAX_HWIFS];

So all these current places are wrong?
If I initialize the data will it be OK.

objdump -t vmlinux |grep -3 is_chipset_set suggests that it's placed into .init.data here, not into .bss.

Russell ?