Skip to contentSkip to conversation

mm: Move common segments checks to separate function

RFC Ken Chen 1 participant 1 message Jan 25, 2007 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

Ken Chen

author
#3 lore raw

Dmitriy Monakhov wrote on Jan 24, 11:00 pm

Quoted 4 lines
Quoted 2 lines

Move common segments checks from __generic_file_aio_{read,write}_nolock() to separate helper function generic_segment_checks().WOW my eyes ....

I'm realy sorry but this patch is litle bit broken. :( I've forgot to check generic_segment_checks() return value.

why not remove the for loop all together? like this:

http://groups.google.com/group/linux.kernel/browse_frm/thread/97550ddba48c8c8b/623ddad30b547702?lnk=st&q=&rnum=9#623ddad30b547702