Skip to contentSkip to conversation

controllers/memcg: Add testcase for kmem_limit_in_bytes of memory cgroup

PATCH New zhaogongyi 1 participant 1 message Apr 15, 2021

v2 of 3 New Latest is v3 →

lore
Share & tools
lore

zhaogongyi

author
#0 lore raw

PATCH v2 1/1 controllers/memcg: Add testcase for kmem_limit_in_bytes of memory cgroup

Hi Richard, Cyril,

Thanks for your review!

1) I can't agree with you more that correctly written test depends on valid assumptions we can make about the operation system the test is supposed to run on

2)when we use tst_res/tst_brk to print information to STDIO, it seems have not trig kmem allocation, I have checked the kernel log, there is only one malloc failed log in dmesg info. And we can see the STDIO info is printed as expected.

3)when we use tst_res/tst_brk to print information to other file, it might trig memory alloction. So, we need remove the calling of tst_res/tst_brk for safety.

I have resubmit the patch according to your review, please see: https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/

Thanks very much!

Best Regards,
Gongyi

Quoted 70 lines

Hello,

Quoted 3 lines · zhaogongyi

Hi Richard,

That's right. I have a Misunderstanding of cgroup.procs. Actrually, we can

write pid or tgid to cgroup.procs instead of pgid.

Quoted 7 lines

I'll update the code as:

	SAFE_FILE_PRINTF(CGROUP_PROCS, "%d", getpid());

BTW I find that the testcase run passed on my local system, it seems that tst_* will not trig memory allocation:

After a short search I found do_tty_write can return ENOMEM due to a call to kmalloc with GFP_KERNEL.

As I said previously stderr can point to many things with different write implementations. Some of these are likely to trigger memory allocation. Please see my previous reply and suggestion.

Also please note the warning message in the kernel log when using memory.kmem.limit_in_bytes.

Quoted 11 lines

tst_test.c:1291: TINFO: Timeout per run is 0h 05m 00s memcg_kmem_limit_in_bytes.c:58: TPASS: fork fail as expected memcg_kmem_limit_in_bytes.c:73: TPASS: kmem alloc is controled by memory.kmem.limit_in_bytes

Summary:

passed   2
failed   0
broken   0
skipped  0
Quoted 22 lines

warnings 0

Thanks very much!

Best Regards,
Gongyi

Quoted 14 lines

Hello,

Quoted 3 lines · zhaogongyi

Hi Richard,

Calling setpgid in this testcase is aim to make the task group be

controlled by memory.kmem.limit_in_bytes since we have set the pgid to cgroup.procs.

Quoted 1 line

Please see cgroup_procs_write_start in cgroup/cgroup.c. It calls find_task_by_vpid which interprets pid as PIDTYPE_PID not

PIDTYPE_PGID.

Quoted 4 lines
Quoted 4 lines

--
Thank you,
Richard.

--
Thank you,
Richard.