Skip to contentSkip to conversation

Oops on 2.4.13

DISCUSSION Petr Vandrovec 2 participants 2 messages Nov 2, 2001

lore
Share & tools
lore
#0 lore raw
Quoted 4 lines · Keith Owens

drivers/video/matrox/matroxfb_crtc2.o - no license, needs patch drivers/video/matrox/matroxfb_g450.o - no license, needs patch drivers/video/matrox/matroxfb_maven.o - no license, needs patch drivers/video/matrox/matroxfb_misc.o - no license, needs patch

They are all GPL-ed. Does it mean that I have to fix that someone else changed kernel API during stable serie?
Thanks,
Petr Vandrovec [email protected]

P.S.: I still do not understand this MODULE_LICENSE() thing. VMware modules will probably contain GPL tag in next release, but kernel hackers refuse to look at these reports anyway (I'm not complaining, this is their right to ignore these reports; but if they say that they are doing that due to non-GPL, they lie). So I think it should be changed from MODULE_LICENSE() to MODULE_CERTIFIED_BY_LINUX_KERNEL_WORKING_GROUP("xxx says it works"). It would match real meaning much better.

#1 lore raw
Quoted 10 lines · Petr Vandrovec
Quoted 4 lines · Keith Owens

drivers/video/matrox/matroxfb_crtc2.o - no license, needs patch drivers/video/matrox/matroxfb_g450.o - no license, needs patch drivers/video/matrox/matroxfb_maven.o - no license, needs patch drivers/video/matrox/matroxfb_misc.o - no license, needs patch

They are all GPL-ed. Does it mean that I have to fix that someone else changed kernel API during stable serie?

yes, they need MODULE_LICENSE

Quoted 8 lines

P.S.: I still do not understand this MODULE_LICENSE() thing. VMware modules will probably contain GPL tag in next release, but kernel hackers refuse to look at these reports anyway (I'm not complaining, this is their right to ignore these reports; but if they say that they are doing that due to non-GPL, they lie). So I think it should be changed from MODULE_LICENSE() to MODULE_CERTIFIED_BY_LINUX_KERNEL_WORKING_GROUP("xxx says it works"). It would match real meaning much better.

Are VMware kernel modules 100% open source? If yes, then that is appropriate.

If VMware kernel modules use ANY closed source libraries (foo.a) etc., then putting MODULE_LICENSE("GPL") on that source is wrong.

Signature · 3 lines
Jeff Garzik      | Only so many songs can be sung
Building 1024    | with two lips, two lungs, and one tongue.
MandrakeSoft     |         - nomeansno